From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF911C4338F for ; Mon, 23 Aug 2021 21:11:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C22360F91 for ; Mon, 23 Aug 2021 21:11:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6C22360F91 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2666289B9E; Mon, 23 Aug 2021 21:11:21 +0000 (UTC) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8C15E89B9E for ; Mon, 23 Aug 2021 21:11:19 +0000 (UTC) Received: from maud (unknown [IPv6:2600:8800:8c06:1000::c8f3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: alyssa) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 4FC031F416C0; Mon, 23 Aug 2021 22:11:14 +0100 (BST) Date: Mon, 23 Aug 2021 17:11:09 -0400 From: Alyssa Rosenzweig To: Steven Price Cc: Alyssa Rosenzweig , dri-devel@lists.freedesktop.org, Rob Herring , Tomeu Vizoso , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org, Chris Morgan Subject: Re: [PATCH 2/3] drm/panfrost: Use u64 for size in lock_region Message-ID: References: <20210820213117.13050-1-alyssa.rosenzweig@collabora.com> <20210820213117.13050-3-alyssa.rosenzweig@collabora.com> <71392001-a5a9-fee2-79a5-91df55ba3081@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <71392001-a5a9-fee2-79a5-91df55ba3081@arm.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > > Mali virtual addresses are 48-bit. Use a u64 instead of size_t to ensure > > we can express the "lock everything" condition as ~0ULL without relying > > on platform-specific behaviour. > > 'platform-specific behaviour' makes it sound like this is something to > do with a particular board. This is 32bit/64bit - it's going to be > broken on 32bit: large lock regions are not going to work. Oh, my. I used the term as a weasel word since the spec is loose on how big a size_t actually is. But if this is causing actual breakage on armv7 we're in trouble. I'll add a Cc stable tag on v2, unless the Fixes implies that? Thanks for pointing this out.