From: Ido Schimmel <idosch@idosch.org>
To: Po-Hsu Lin <po-hsu.lin@canonical.com>
Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
skhan@linuxfoundation.org, petrm@nvidia.co,
oleksandr.mazur@plvision.eu, idosch@nvidia.com, jiri@nvidia.com,
nikolay@nvidia.com, gnault@redhat.com,
simon.horman@netronome.com, baowen.zheng@corigine.com,
danieller@nvidia.com
Subject: Re: [PATCH] selftests/net: Use kselftest skip code for skipped tests
Date: Tue, 24 Aug 2021 10:24:11 +0300 [thread overview]
Message-ID: <YSSemxg1JQRdqxsP@shredder> (raw)
In-Reply-To: <20210823085854.40216-1-po-hsu.lin@canonical.com>
On Mon, Aug 23, 2021 at 04:58:54PM +0800, Po-Hsu Lin wrote:
> There are several test cases in the net directory are still using
> exit 0 or exit 1 when they need to be skipped. Use kselftest
> framework skip code instead so it can help us to distinguish the
> return status.
>
> Criterion to filter out what should be fixed in net directory:
> grep -r "exit [01]" -B1 | grep -i skip
>
> This change might cause some false-positives if people are running
> these test scripts directly and only checking their return codes,
> which will change from 0 to 4. However I think the impact should be
> small as most of our scripts here are already using this skip code.
> And there will be no such issue if running them with the kselftest
> framework.
>
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Tested-by: Ido Schimmel <idosch@nvidia.com>
next prev parent reply other threads:[~2021-08-24 7:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 8:58 [PATCH] selftests/net: Use kselftest skip code for skipped tests Po-Hsu Lin
2021-08-23 10:51 ` Ido Schimmel
2021-08-24 7:24 ` Ido Schimmel [this message]
2021-08-25 3:21 ` Po-Hsu Lin
2021-08-25 0:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSSemxg1JQRdqxsP@shredder \
--to=idosch@idosch.org \
--cc=baowen.zheng@corigine.com \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=gnault@redhat.com \
--cc=idosch@nvidia.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=oleksandr.mazur@plvision.eu \
--cc=petrm@nvidia.co \
--cc=po-hsu.lin@canonical.com \
--cc=simon.horman@netronome.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.