From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 463C1C4338F for ; Tue, 24 Aug 2021 19:59:16 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ECBA661262 for ; Tue, 24 Aug 2021 19:59:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org ECBA661262 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 14AE16E0CD; Tue, 24 Aug 2021 19:59:15 +0000 (UTC) Received: from mx1.smtp.larsendata.com (mx1.smtp.larsendata.com [91.221.196.215]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5D0E66E0CD for ; Tue, 24 Aug 2021 19:59:13 +0000 (UTC) Received: from mail01.mxhotel.dk (mail01.mxhotel.dk [91.221.196.236]) by mx1.smtp.larsendata.com (Halon) with ESMTPS id b7f3984d-0515-11ec-b37b-0050568c148b; Tue, 24 Aug 2021 19:58:58 +0000 (UTC) Received: from ravnborg.org (80-162-45-141-cable.dk.customer.tdc.net [80.162.45.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: sam@ravnborg.org) by mail01.mxhotel.dk (Postfix) with ESMTPSA id 6FFFA194B3F; Tue, 24 Aug 2021 21:59:21 +0200 (CEST) Date: Tue, 24 Aug 2021 21:59:04 +0200 X-Report-Abuse-To: abuse@mxhotel.dk From: Sam Ravnborg To: Shawn Guo Cc: Thierry Reding , Stephan Gerhold , Daniel Vetter , Rob Herring , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 2/2] drm/panel: Add Sony Tulip Truly NT35521 driver Message-ID: References: <20210809051008.6172-1-shawn.guo@linaro.org> <20210809051008.6172-3-shawn.guo@linaro.org> <20210824025831.GB22595@dragon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210824025831.GB22595@dragon> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Aug 24, 2021 at 10:58:31AM +0800, Shawn Guo wrote: > On Mon, Aug 09, 2021 at 01:10:08PM +0800, Shawn Guo wrote: > > It adds a DRM panel driver for Sony Tulip Truly NT35521 5.24" 1280x720 > > DSI panel, which can be found on Sony Xperia M4 Aqua phone. The panel > > backlight is managed through DSI link. > > > > The driver is built using linux-mdss-dsi-panel-driver-generator[1], and > > additionally modeling the 5V control GPIOs with regulators and adding > > Backlight GPIO support. > > > > [1] https://github.com/msm8916-mainline/linux-mdss-dsi-panel-driver-generator > > > > Signed-off-by: Shawn Guo > > Sam, Stephan, > > Thank you for the review comments on v1! How does v2 look to you? I will not have time until next week - sorry. Please ping me if you have no feedback i one week from now. Sam