Re: [PATCH libnetfilter_queue v4 2/4] build: doc: can choose what to build and install

[Duncan Roe <duncan_roe@optusnet.com.au>]

On Tue, Aug 24, 2021 at 12:30:01PM +0200, Pablo Neira Ayuso wrote:
> On Sun, Aug 22, 2021 at 02:14:40PM +1000, Duncan Roe wrote:
> > Update doxygen/Makefile.am to build and install man pages and html documentation
> > conditionally. Involves configure.ac and doxygen.cfg.in, see below.
[...]
> > diff --git a/configure.ac b/configure.ac
> > index 0fe754c..376d4ff 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -10,9 +10,42 @@ AM_INIT_AUTOMAKE([-Wall foreign subdir-objects
> >  	tar-pax no-dist-gzip dist-bzip2 1.6])
> >  m4_ifdef([AM_PROG_AR], [AM_PROG_AR])
> >
> > +case "$host" in
> > +*-*-linux* | *-*-uclinux*) ;;
> > +*) AC_MSG_ERROR([Linux only, dude!]);;
> > +esac
>
> This update is unnecessary, please avoid unnecessary changes in your
> updates, it makes it harder to review.
>
My thinking was that we should check for running under Linux before we assume
that `test` is sane and accepts modern constructs.

Cheers ... Duncan.