From: Greg KH <gregkh@linuxfoundation.org>
To: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Cc: Saurav Girepunje <saurav.girepunje@gmail.com>,
Phillip Potter <phil@philpotter.co.uk>,
Larry Finger <Larry.Finger@lwfinger.net>,
linux-staging@lists.linux.dev,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
saurav.girepunje@hotmail.com
Subject: Re: [PATCH] staging: r8188eu: core: remove condition with no effect
Date: Thu, 26 Aug 2021 12:34:03 +0200 [thread overview]
Message-ID: <YSduG401BA80Xnsb@kroah.com> (raw)
In-Reply-To: <YSJEu3sbnR6uIach@kroah.com>
On Sun, Aug 22, 2021 at 02:36:11PM +0200, Greg KH wrote:
> On Sun, Aug 22, 2021 at 01:06:09PM +0200, Fabio M. De Francesco wrote:
> > On Sunday, August 22, 2021 1:58:10 AM CEST Phillip Potter wrote:
> > > On Sat, 21 Aug 2021 at 21:23, Saurav Girepunje
> > >
> > > <saurav.girepunje@gmail.com> wrote:
> > > > Remove the condition with no effect (if == else) in rtw_led.c
> > > > file.
> > > >
> > > > Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> > > > ---
> > > >
> > > > drivers/staging/r8188eu/core/rtw_led.c | 5 +----
> > > > 1 file changed, 1 insertion(+), 4 deletions(-)
> > >
> > > Thanks for this, looks good.
> > >
> > > Acked-by: Phillip Potter <phil@philpotter.co.uk>
> > >
> > > Regards,
> > > Phil
> >
> > Dear Philip,
> >
> > Before acking, please check at least if it applies to the current version of
> > the tree and check if it compiles without adding warnings and / or errors. :-)
>
> That is not necessary or needed here, I can do that when I apply the
> patch.
As proof of that, this patch applied just fine to my tree right now...
thanks,
greg k-h
next prev parent reply other threads:[~2021-08-26 10:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-21 20:23 [PATCH] staging: r8188eu: core: remove condition with no effect Saurav Girepunje
2021-08-21 23:58 ` Phillip Potter
2021-08-22 11:06 ` Fabio M. De Francesco
2021-08-22 12:36 ` Greg KH
2021-08-26 10:34 ` Greg KH [this message]
2021-08-28 12:24 ` SAURAV GIREPUNJE
2021-08-22 14:58 ` Phillip Potter
2021-08-22 16:24 ` Fabio M. De Francesco
2021-08-22 23:58 ` Phillip Potter
2021-08-25 3:54 ` SAURAV GIREPUNJE
2021-08-22 10:58 ` Michael Straube
-- strict thread matches above, loose matches on Subject: below --
2021-08-29 9:01 Saurav Girepunje
2021-08-29 12:08 ` Pavel Skripkin
2021-08-29 12:48 ` Michael Straube
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YSduG401BA80Xnsb@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=fmdefrancesco@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=phil@philpotter.co.uk \
--cc=saurav.girepunje@gmail.com \
--cc=saurav.girepunje@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.