From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mKdh2-0002wJ-0h for mharc-grub-devel@gnu.org; Mon, 30 Aug 2021 05:35:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKdh0-0002uY-Fb for grub-devel@gnu.org; Mon, 30 Aug 2021 05:35:02 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:43852) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mKdgv-0006nF-FF for grub-devel@gnu.org; Mon, 30 Aug 2021 05:35:02 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id EDF961FDE9; Mon, 30 Aug 2021 09:34:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1630316093; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W8HmWfRbJzTperP10NQawlGoPNm/IlOQKyemUWUhHik=; b=TOMCMPHyn8FdsieIRa0MKnana6yONf95GbkWGCnnS2AsTXKfAMCaIZuPoeVGlwguinxpYe /sHMwA/jGZ87/y/jEVlNA6NZFr37Mp9Xh2LacXzJJ5iDrxJVYGOFsxxjvl9xbMZPLivuQ3 APkOEnsVaNuwIOg6TTLcoyQ9dtaI/Q4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1630316093; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W8HmWfRbJzTperP10NQawlGoPNm/IlOQKyemUWUhHik=; b=pnu8cVZztLkx9oNUOXuPoKtdAeq2+3hdFhuAcvshN1nXMSEr2Bv1VyjO2R6O8ZqkD2ySAm EfgkVWngYH60A5Dg== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id CF9D91365E; Mon, 30 Aug 2021 09:34:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id Xjd2MT2mLGHBNwAAGKfGzw (envelope-from ); Mon, 30 Aug 2021 09:34:53 +0000 Date: Mon, 30 Aug 2021 11:34:52 +0200 From: Petr Vorel To: Daniel Kiper Cc: grub-devel@gnu.org Subject: Re: [PATCH 2/2] autogen.sh: Detect python Message-ID: Reply-To: Petr Vorel References: <20210806064508.4489-1-pvorel@suse.cz> <20210806064508.4489-2-pvorel@suse.cz> <20210809115229.toe34etovoul62ss@tomti.i.net-space.pl> <20210809163605.bwmvx3cfn5zaiv4p@tomti.i.net-space.pl> <20210826143028.ridofxcpljgfbeee@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210826143028.ridofxcpljgfbeee@tomti.i.net-space.pl> Received-SPF: pass client-ip=195.135.220.29; envelope-from=pvorel@suse.cz; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Aug 2021 09:35:02 -0000 Hi Daniel, > On Wed, Aug 18, 2021 at 09:19:23AM +0200, Petr Vorel wrote: > > > On Mon, Aug 09, 2021 at 01:52:29PM +0200, Daniel Kiper wrote: > > > > On Fri, Aug 06, 2021 at 08:45:08AM +0200, Petr Vorel wrote: > > > > > It help to avoid error on distros which has only python3 binary: > > > > > ./autogen.sh: line 20: python: command not found > > > > > Using bash builtin 'command -v' to avoid requiring which as extra > > > > > dependency (usable on containers). > > > > It looks the bash dependency is not specified in the INSTALL file in > > > > "The Requirements" section. May I ask you to add it? > > > ...and python requirement is missing from the list too. Additionally, > > > please update autogen.sh python usage in the INSTALL file. > > There is Python 2.6 or later, not sure if it still works on 2.6 (which is EOL) > > or it requires now 2.7). > I think we should update this requirement to "Python 3.0.0 or later". I'll just note Python 3, because 1) IMHO it would not work on 3.0, first reasonable python 3 version which allowed 2 and 3 reasonably easily coexist together was IMHO 3.3, 2) no distro uses 3.0, they either use match higher 3 version (3.6 at least) or 2.7 (or 2.6 the oldest ones). > > Also "If you use a development snapshot or want to hack on GRUB you may > > need the following." is obsolete (from 2009), I'll move python, autoconf and > > automake to the list on the top. > OK... > There is also: > 3. Type `./bootstrap'. > * autogen.sh (called by bootstrap) uses python. By default the > invocation is "python", but it can be overridden by setting the > variable $PYTHON. > I think this should be updated too. +1. Kind regards, Petr