From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 3472BC433F5
	for <linux-kernel@archiver.kernel.org>; Mon, 13 Sep 2021 18:49:33 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 1EC6E610A2
	for <linux-kernel@archiver.kernel.org>; Mon, 13 Sep 2021 18:49:33 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1344326AbhIMSuq (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Mon, 13 Sep 2021 14:50:46 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:38868 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S233322AbhIMSup (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 13 Sep 2021 14:50:45 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version:
        References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject:
        Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding:
        Content-ID:Content-Description:Content-Disposition:In-Reply-To:References;
        bh=5FAlYJR+L5K5/mBd9HnFp40bPv/czg5qf8z7Hb1WYVw=; b=PWXhzXJZ+LIy86u9GTxMu/azsa
        Xezrgnl7esbVqQxEcugmLxSblI2wIzy7qPfIdahoI1FLLxjDJsvYnP0J/lUP6WmmjlAp0uaYOSexz
        C5YCrYF5Un2Em1vyDbJ02+ESHozfoSRpa2qt6glrq43lx9Q48DBOMbBdzfiiYi2lJ9G8=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2)
        (envelope-from <andrew@lunn.ch>)
        id 1mPr15-006RuN-Sl; Mon, 13 Sep 2021 20:49:19 +0200
Date:   Mon, 13 Sep 2021 20:49:19 +0200
From:   Andrew Lunn <andrew@lunn.ch>
To:     Vladimir Oltean <olteanv@gmail.com>
Cc:     Gerhard Engleder <gerhard@engleder-embedded.com>,
        Vladimir Oltean <vladimir.oltean@nxp.com>,
        netdev <netdev@vger.kernel.org>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Russell King <linux@armlinux.org.uk>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH net] Revert "net: phy: Uniform PHY driver access"
Message-ID: <YT+dL1R/DTVBWQ7D@lunn.ch>
References: <20210912192805.1394305-1-vladimir.oltean@nxp.com>
 <CANr-f5wCpcPM+FbeW+x-JmZt0-WmE=b5Ys1Pa_G7p8v3nLyCcQ@mail.gmail.com>
 <20210912213855.kxoyfqdyxktax6d3@skbuf>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210912213855.kxoyfqdyxktax6d3@skbuf>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> I am not sure why "to_phy_driver" needs cleanup. Au contraire, I think
> the PHY library's usage of struct phy_device :: drv is what is strange
> and potentially buggy, it is the only subsystem I know of that keeps its
> own driver pointer rather than looking at struct device :: driver.

There is one odd driver in the mix. Take a look at xilinx_gmii2rgmii.c.

It probably could be done a better way, but that is what we have.

   Andrew