From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EC34C433F5 for ; Sun, 12 Sep 2021 21:27:49 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE32161039 for ; Sun, 12 Sep 2021 21:27:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DE32161039 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BDFA082B; Sun, 12 Sep 2021 23:26:55 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BDFA082B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1631482065; bh=BcXMonNRj+Qy+7xb7JdXVCoadCtdi/wA4Otl1L6sI8g=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=qqqxQICG2eJStbLrRZzCAJOW+rlE06EY/RJ19FKWeHwlc2aKaeMvoqX4bBDeq1ikj +75C15Sc+qoqEtipMotlCKZBDDt3jxiEcJ3wLS1udT/be4LkjOTCmH07/B4CkyhrS3 Ex0yroS8CATs4A1XY4zXrr8iDWFUmHwJU0SKJ78g= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 4BCE1F80143; Sun, 12 Sep 2021 23:26:55 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 65FC9F8025E; Sun, 12 Sep 2021 23:26:54 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E98EFF80113 for ; Sun, 12 Sep 2021 23:26:45 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E98EFF80113 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WptiwguH" Received: by mail.kernel.org (Postfix) with ESMTPSA id 29A6C60F56; Sun, 12 Sep 2021 21:26:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631482002; bh=BcXMonNRj+Qy+7xb7JdXVCoadCtdi/wA4Otl1L6sI8g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WptiwguHCkRNmCk8xm9iF/EDCE5K2M8qu3VqOAxQX+5L+Zoe+gmKNOtgzXaGgLEkY FgYKPX2APcK0bO+KgTUKvCZzQE6aR4RdRMqJL5L04CFiYRZilTzKv7mLsXYPLd5sRL 2SR+SzQLG8LQZ6twBgfFLGvDv7VdYnQXit243p4gsLxgebEjZRDVK19dpC7ODui3F9 zklup6Q3CyCMm5BufKc8FX3XXBNZSerWfnQreGknadjnuouoQ2Cyk9lYHyapRhZO6L E6PhuFTL5VCahkMj8E654ttCLVB+FqcjMJFnazv7O4XICNG0V5xQ9RFYgKgiRgNTfV wlNrr5eqgihmA== Date: Sun, 12 Sep 2021 17:26:41 -0400 From: Sasha Levin To: Takashi Iwai Subject: Re: [PATCH AUTOSEL 4.4 29/35] ASoC: intel: atom: Revert PCM buffer address setup workaround again Message-ID: References: <20210909120116.150912-1-sashal@kernel.org> <20210909120116.150912-29-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, Sep 09, 2021 at 02:07:14PM +0200, Takashi Iwai wrote: >On Thu, 09 Sep 2021 14:01:10 +0200, >Sasha Levin wrote: >> >> From: Takashi Iwai >> >> [ Upstream commit e28ac04a705e946eddc5e7d2fc712dea3f20fe9e ] >> >> We worked around the breakage of PCM buffer setup by the commit >> 65ca89c2b12c ("ASoC: intel: atom: Fix breakage for PCM buffer address >> setup"), but this isn't necessary since the CONTINUOUS buffer type >> also sets runtime->dma_addr since commit f84ba106a018 ("ALSA: >> memalloc: Store snd_dma_buffer.addr for continuous pages, too"). >> Let's revert the change again. >> >> Link: https://lore.kernel.org/r/20210822072127.9786-1-tiwai@suse.de >> Signed-off-by: Takashi Iwai >> Signed-off-by: Sasha Levin > >Please drop this. Will do, thanks! -- Thanks, Sasha From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6913C433EF for ; Sun, 12 Sep 2021 21:26:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89EA061039 for ; Sun, 12 Sep 2021 21:26:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236499AbhILV16 (ORCPT ); Sun, 12 Sep 2021 17:27:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:37734 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236427AbhILV15 (ORCPT ); Sun, 12 Sep 2021 17:27:57 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 29A6C60F56; Sun, 12 Sep 2021 21:26:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1631482002; bh=BcXMonNRj+Qy+7xb7JdXVCoadCtdi/wA4Otl1L6sI8g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WptiwguHCkRNmCk8xm9iF/EDCE5K2M8qu3VqOAxQX+5L+Zoe+gmKNOtgzXaGgLEkY FgYKPX2APcK0bO+KgTUKvCZzQE6aR4RdRMqJL5L04CFiYRZilTzKv7mLsXYPLd5sRL 2SR+SzQLG8LQZ6twBgfFLGvDv7VdYnQXit243p4gsLxgebEjZRDVK19dpC7ODui3F9 zklup6Q3CyCMm5BufKc8FX3XXBNZSerWfnQreGknadjnuouoQ2Cyk9lYHyapRhZO6L E6PhuFTL5VCahkMj8E654ttCLVB+FqcjMJFnazv7O4XICNG0V5xQ9RFYgKgiRgNTfV wlNrr5eqgihmA== Date: Sun, 12 Sep 2021 17:26:41 -0400 From: Sasha Levin To: Takashi Iwai Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH AUTOSEL 4.4 29/35] ASoC: intel: atom: Revert PCM buffer address setup workaround again Message-ID: References: <20210909120116.150912-1-sashal@kernel.org> <20210909120116.150912-29-sashal@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 09, 2021 at 02:07:14PM +0200, Takashi Iwai wrote: >On Thu, 09 Sep 2021 14:01:10 +0200, >Sasha Levin wrote: >> >> From: Takashi Iwai >> >> [ Upstream commit e28ac04a705e946eddc5e7d2fc712dea3f20fe9e ] >> >> We worked around the breakage of PCM buffer setup by the commit >> 65ca89c2b12c ("ASoC: intel: atom: Fix breakage for PCM buffer address >> setup"), but this isn't necessary since the CONTINUOUS buffer type >> also sets runtime->dma_addr since commit f84ba106a018 ("ALSA: >> memalloc: Store snd_dma_buffer.addr for continuous pages, too"). >> Let's revert the change again. >> >> Link: https://lore.kernel.org/r/20210822072127.9786-1-tiwai@suse.de >> Signed-off-by: Takashi Iwai >> Signed-off-by: Sasha Levin > >Please drop this. Will do, thanks! -- Thanks, Sasha