From mboxrd@z Thu Jan 1 00:00:00 1970 From: Petr Vorel Date: Mon, 13 Sep 2021 16:46:33 +0200 Subject: [LTP] [PATCH 8/8] syscalls/setresuid03: Convert to new API In-Reply-To: <3b789dc4-5232-a6d6-d864-7f75c5a0a030@suse.cz> References: <20210909155126.2720-1-mdoucha@suse.cz> <20210909155126.2720-8-mdoucha@suse.cz> <287a9879ef8b3342cb88225e4e319733@suse.de> <3b789dc4-5232-a6d6-d864-7f75c5a0a030@suse.cz> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it > On 09. 09. 21 18:32, pvorel wrote: > >> -??? if (getpwnam("bin") == NULL) { > >> -??????? tst_brkm(TBROK, NULL, "bin must be a valid user."); > >> +??? if (TST_ERR != tc->exp_errno) { > > nit: checkpatch complains (TST_ERR should be second) > checkpatch.pl wrongly assumes that TST_ERR is a constant. Yep, variable named upper case is confusing for perl script. Sorry for not detecting it myself. I suppose we should whitelist TST_{ERR,PASS,RET} from these checks in our vendored checkpatch.pl. Kind regards, Petr From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF884C433F5 for ; Mon, 13 Sep 2021 14:46:46 +0000 (UTC) Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 602C660FDA for ; Mon, 13 Sep 2021 14:46:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 602C660FDA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux.it Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 7FA093C9289 for ; Mon, 13 Sep 2021 16:46:44 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [217.194.8.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 51D153C1DF5 for ; Mon, 13 Sep 2021 16:46:36 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id C44D31A01011 for ; Mon, 13 Sep 2021 16:46:35 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F05E8219D4; Mon, 13 Sep 2021 14:46:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1631544394; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3RkwO+PSe8RTHj50Rj3kDMxzgH7hDo6gm1A8pPri4Ig=; b=dEEqo66EUznCXoSEZ6DVuNpq/PtUirM2hQXi9ODyNHnq6TH4EHpctGBqxUURrFBwbnfv/l Sp9XQ6yUmjMb8Y0q9+ebX7slI/6SbvTvmjjnRN0iFjcozHEaEPkNFp9l0Piqk4SPf871JR stdEYapScUfKKo2nJFHiODyUjGBxe5E= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1631544394; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3RkwO+PSe8RTHj50Rj3kDMxzgH7hDo6gm1A8pPri4Ig=; b=2Dy6Kh9cqjWFZXMV/+OB1sNc61rIXtRbs3s4v2akNtYUVMx70PCyfF9w9DSjnuN8owyfRe w8V1eMCy0LhtRYBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id A4FCC13AB9; Mon, 13 Sep 2021 14:46:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id B1/FJkpkP2GXbwAAMHmgww (envelope-from ); Mon, 13 Sep 2021 14:46:34 +0000 Date: Mon, 13 Sep 2021 16:46:33 +0200 From: Petr Vorel To: Martin Doucha Message-ID: References: <20210909155126.2720-1-mdoucha@suse.cz> <20210909155126.2720-8-mdoucha@suse.cz> <287a9879ef8b3342cb88225e4e319733@suse.de> <3b789dc4-5232-a6d6-d864-7f75c5a0a030@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3b789dc4-5232-a6d6-d864-7f75c5a0a030@suse.cz> X-Virus-Scanned: clamav-milter 0.102.4 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 8/8] syscalls/setresuid03: Convert to new API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Petr Vorel Cc: pvorel , ltp@lists.linux.it, Richard Palethorpe Content-Type: text/plain; charset="iso-8859-2" Content-Transfer-Encoding: quoted-printable Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Message-ID: <20210913144633.jnHZZ6nKaqVNAaJKffS1nl1emCOR9cIGsJeA0JoY9xE@z> > On 09. 09. 21 18:32, pvorel wrote: > >> -=A0=A0=A0 if (getpwnam("bin") =3D=3D NULL) { > >> -=A0=A0=A0=A0=A0=A0=A0 tst_brkm(TBROK, NULL, "bin must be a valid user= ."); > >> +=A0=A0=A0 if (TST_ERR !=3D tc->exp_errno) { > > nit: checkpatch complains (TST_ERR should be second) > checkpatch.pl wrongly assumes that TST_ERR is a constant. Yep, variable named upper case is confusing for perl script. Sorry for not detecting it myself. I suppose we should whitelist TST_{ERR,PASS,RET} from these checks in our vendored checkpatch.pl. Kind regards, Petr -- = Mailing list info: https://lists.linux.it/listinfo/ltp