From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42CD0C432BE for ; Thu, 2 Sep 2021 12:06:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1FDCF6109E for ; Thu, 2 Sep 2021 12:06:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344129AbhIBMHB (ORCPT ); Thu, 2 Sep 2021 08:07:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43528 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234081AbhIBMHA (ORCPT ); Thu, 2 Sep 2021 08:07:00 -0400 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDE6FC061575 for ; Thu, 2 Sep 2021 05:06:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OFWN9tRAqjXVBWOOIV9ZZ6Jy1jkGoZ0Z+UnlsnwjGdI=; b=o9Q8XmnGgkCLz6DBO6oFYi7bW2 hN9hu/1ks1tCKFlvIUQG9uuIFTzavPWpoCIP8lm5JA1YMSDq/u3ejrmat93FltSnNlQ0SR+LfaZKv iYIv8nuOKLqoBeO6IcBVtvTIn7l7dskPUMRcO/sY4aqVyKuLrvwabw2xtKTtk61+l9XXdzGHG3j+J c330J3ah9ZCxRQPIoXyjOXa2j/xlFqpERuUV+a2qkq3qr2VL4yB2P08ARrWedTXlNrJwPzXFMTQ59 v6TS9bhsfdT/GnwE0rv+CI//GItD7RxOo4Rgy+ChBnOoK1RcNTrB18Nfi8f0+zb2Y8ytRurZFpwvz pofT6LSQ==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLlTP-0007Cz-UD; Thu, 02 Sep 2021 12:05:43 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 6E27830003A; Thu, 2 Sep 2021 14:05:41 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 556CE285E116C; Thu, 2 Sep 2021 14:05:41 +0200 (CEST) Date: Thu, 2 Sep 2021 14:05:41 +0200 From: Peter Zijlstra To: Lai Jiangshan Cc: Joerg Roedel , Lai Jiangshan , linux-kernel@vger.kernel.org, Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Daniel Bristot de Oliveira , Brijesh Singh , Andy Shevchenko , Arvind Sankar , Chester Lin , Juergen Gross , andrew.cooper3@citrix.com Subject: Re: [PATCH 02/24] x86/traps: Move arch/x86/kernel/traps.c to arch/x86/entry/ Message-ID: References: <20210831175025.27570-1-jiangshanlai@gmail.com> <20210831175025.27570-3-jiangshanlai@gmail.com> <1f327579-e62a-df65-0763-e88243829db3@linux.alibaba.com> <4c589fef-8c98-a6fc-693f-b205a7710e42@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4c589fef-8c98-a6fc-693f-b205a7710e42@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 02, 2021 at 07:54:25PM +0800, Lai Jiangshan wrote: > For example, stack-protector is instrumenting many noninstr functions now > if the CONFIG is yes. It is normally Ok and gcc is adding per-function control > on it. IIRC the latest compiler have an attribute for this too, that really should be added to noinstr. Lemme go find.