From: Greg KH <gregkh@linuxfoundation.org>
To: Nirmoy Das <nirmoy.das@amd.com>
Cc: rafael@kernel.org, linux-kernel@vger.kernel.org,
Christian.Koenig@amd.com
Subject: Re: [PATCH 1/1] debugfs: use IS_ERR to check for error
Date: Thu, 2 Sep 2021 12:38:50 +0200 [thread overview]
Message-ID: <YTCpuo00wM7jGSIc@kroah.com> (raw)
In-Reply-To: <20210902102917.2233-1-nirmoy.das@amd.com>
On Thu, Sep 02, 2021 at 12:29:17PM +0200, Nirmoy Das wrote:
> debugfs_create_file() returns encoded error so
> use IS_ERR for checking return value.
>
> References: https://gitlab.freedesktop.org/drm/amd/-/issues/1686
> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
> ---
> fs/debugfs/inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/debugfs/inode.c b/fs/debugfs/inode.c
> index 8129a430d789..2f117c57160d 100644
> --- a/fs/debugfs/inode.c
> +++ b/fs/debugfs/inode.c
> @@ -528,7 +528,7 @@ void debugfs_create_file_size(const char *name, umode_t mode,
> {
> struct dentry *de = debugfs_create_file(name, mode, parent, data, fops);
>
> - if (de)
> + if (!IS_ERR(de))
> d_inode(de)->i_size = file_size;
> }
> EXPORT_SYMBOL_GPL(debugfs_create_file_size);
> --
> 2.32.0
>
Ah, good catch, I'll queue this up after 5.15-rc1 is out, thanks!
greg k-h
next prev parent reply other threads:[~2021-09-02 10:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 10:29 [PATCH 1/1] debugfs: use IS_ERR to check for error Nirmoy Das
2021-09-02 10:31 ` Christian König
2021-09-02 10:38 ` Greg KH [this message]
2021-09-02 12:03 ` Christian König
2021-09-02 12:20 ` Greg KH
2021-09-02 15:10 ` Christian König
2021-09-02 16:34 ` Greg KH
2021-09-02 16:44 ` Das, Nirmoy
2021-09-02 16:48 ` Das, Nirmoy
2021-09-02 17:01 ` Das, Nirmoy
2021-09-03 6:27 ` Christian König
2021-09-21 7:03 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTCpuo00wM7jGSIc@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Christian.Koenig@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nirmoy.das@amd.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.