From: Andrew Lunn <andrew@lunn.ch>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: "Russell King (Oracle)" <linux@armlinux.org.uk>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
netdev@vger.kernel.org,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
linux-kernel@vger.kernel.org,
"Linus Walleij" <linus.walleij@linaro.org>,
"Alvin Šipraga" <alsi@bang-olufsen.dk>,
"ACPI Devel Maling List" <linux-acpi@vger.kernel.org>,
kernel-team <kernel-team@android.com>,
"Len Brown" <lenb@kernel.org>
Subject: Re: [RFC PATCH net-next 1/3] net: phy: don't bind genphy in phy_attach_direct if the specific driver defers probe
Date: Fri, 3 Sep 2021 01:02:06 +0200 [thread overview]
Message-ID: <YTFX7n9qj2cUh0Ap@lunn.ch> (raw)
In-Reply-To: <20210902224506.5h7bnybjbljs5uxz@skbuf>
> > Note that phylink_destroy() is documented as:
> >
> > * Note: the rtnl lock must not be held when calling this function.
> >
...
>
> Any other issues besides needing to take rtnl_mutex top-level when
> calling phylink_destroy?
We should try to keep phylink_create and phylink_destroy symmetrical:
/**
* phylink_create() - create a phylink instance
* @config: a pointer to the target &struct phylink_config
* @fwnode: a pointer to a &struct fwnode_handle describing the network
* interface
* @iface: the desired link mode defined by &typedef phy_interface_t
* @mac_ops: a pointer to a &struct phylink_mac_ops for the MAC.
*
* Create a new phylink instance, and parse the link parameters found in @np.
* This will parse in-band modes, fixed-link or SFP configuration.
*
* Note: the rtnl lock must not be held when calling this function.
Having different locking requirements will catch people out.
Interestingly, there is no ASSERT_NO_RTNL(). Maybe we should add such
a macro.
Andrew
next prev parent reply other threads:[~2021-09-02 23:02 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-01 22:50 [RFC PATCH net-next 0/3] Make the PHY library stop being so greedy when binding the generic PHY driver Vladimir Oltean
2021-09-01 22:50 ` [RFC PATCH net-next 1/3] net: phy: don't bind genphy in phy_attach_direct if the specific driver defers probe Vladimir Oltean
2021-09-02 5:43 ` Greg Kroah-Hartman
2021-09-02 10:11 ` Vladimir Oltean
2021-09-02 10:37 ` Greg Kroah-Hartman
2021-09-02 11:17 ` Vladimir Oltean
2021-09-02 14:37 ` Rafael J. Wysocki
2021-09-02 18:50 ` Russell King (Oracle)
2021-09-02 19:23 ` Vladimir Oltean
2021-09-02 19:51 ` Andrew Lunn
2021-09-02 20:33 ` Florian Fainelli
2021-09-02 21:33 ` Russell King (Oracle)
2021-09-02 21:39 ` Vladimir Oltean
2021-09-02 22:24 ` Russell King (Oracle)
2021-09-02 22:45 ` Vladimir Oltean
2021-09-02 23:02 ` Andrew Lunn [this message]
2021-09-02 23:26 ` Vladimir Oltean
2021-09-03 0:04 ` Russell King (Oracle)
2021-09-03 20:48 ` Vladimir Oltean
2021-09-03 22:06 ` Russell King (Oracle)
2021-09-04 21:59 ` Vladimir Oltean
2021-09-04 23:25 ` Russell King (Oracle)
2021-09-05 0:41 ` Vladimir Oltean
2021-09-03 9:27 ` Ioana Ciornei
2021-09-01 22:50 ` [RFC PATCH net-next 2/3] net: dsa: destroy the phylink instance on any error in dsa_slave_phy_setup Vladimir Oltean
2021-09-02 12:25 ` Russell King (Oracle)
2021-09-02 23:21 ` Florian Fainelli
2021-09-01 22:50 ` [RFC PATCH net-next 3/3] net: dsa: allow the phy_connect() call to return -EPROBE_DEFER Vladimir Oltean
2021-09-02 12:19 ` [RFC PATCH net-next 0/3] Make the PHY library stop being so greedy when binding the generic PHY driver Russell King (Oracle)
2021-09-02 12:35 ` Vladimir Oltean
2021-09-02 12:59 ` Vladimir Oltean
2021-09-02 13:26 ` Russell King (Oracle)
2021-09-02 15:23 ` Vladimir Oltean
2021-09-02 16:31 ` Russell King (Oracle)
2021-09-02 17:10 ` Vladimir Oltean
2021-09-02 17:50 ` Russell King (Oracle)
2021-09-02 19:05 ` Vladimir Oltean
2021-09-02 20:03 ` Russell King (Oracle)
2021-09-02 20:21 ` Vladimir Oltean
2021-09-02 20:29 ` Russell King (Oracle)
2021-09-03 16:22 ` Vladimir Oltean
2021-09-03 17:21 ` Andrew Lunn
2021-09-03 18:58 ` Russell King (Oracle)
2021-09-03 19:56 ` Andrew Lunn
2021-09-03 20:08 ` Russell King (Oracle)
2021-09-03 18:54 ` Russell King (Oracle)
2021-09-03 20:11 ` Vladimir Oltean
2021-09-02 20:07 ` Andrew Lunn
2021-09-02 20:32 ` Vladimir Oltean
2021-09-02 21:39 ` Russell King (Oracle)
2021-09-02 22:05 ` Vladimir Oltean
2021-09-02 23:29 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTFX7n9qj2cUh0Ap@lunn.ch \
--to=andrew@lunn.ch \
--cc=alsi@bang-olufsen.dk \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=kernel-team@android.com \
--cc=kuba@kernel.org \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=rafael@kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.