All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 5/5] checkbashisms: Disable 'type' check
Date: Fri, 3 Sep 2021 12:30:57 +0200	[thread overview]
Message-ID: <YTH5YaacIHvvjxAq@pevik> (raw)
In-Reply-To: <YTDSn6ucuuIsfB19@yuki>

Hi Cyril,

> Hi!
> Looks good.

> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>

Looks like 'command -v' which is POSIX works (tested in bash, dash, busybox sh
and android shell), thus I suggest to drop this patch and use 'command -v'
instead of 'type'.

$ foo(){ echo "in foo";}
$ command -v foo
foo

Kind regards,
Petr

      reply	other threads:[~2021-09-03 10:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-02 11:58 [LTP] [PATCH 5/5] checkbashisms: Disable 'type' check Petr Vorel
2021-09-02 13:33 ` Cyril Hrubis
2021-09-03 10:30   ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YTH5YaacIHvvjxAq@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.