From: Petr Vorel <pvorel@suse.cz>
To: daniel.kiper@oracle.com
Cc: grub-devel@gnu.org
Subject: Re: [PATCH v2 2/2] autogen.sh: Detect python
Date: Fri, 3 Sep 2021 12:49:55 +0200 [thread overview]
Message-ID: <YTH906YyQSV9aBLe@pevik> (raw)
In-Reply-To: <20210831181313.chklf43hfcnh6cp3@tomti.i.net-space.pl>
Hi Daniel,
> On Mon, Aug 30, 2021 at 11:53:17AM +0200, Petr Vorel wrote:
> > It help to avoid error on distros which has only python3 binary:
> > ./autogen.sh: line 20: python: command not found
> > Use python3 as the default as python2 is EOL since Jan 2020, but check
> > also python which is on most distros if not all python2 because
> > code still works on python2.
> > Although it should not be needed keep the possibility to define PYTHON.
> > For detection use "command -v" which is POSIX [3] and supported on all
> > common shells (bash, zsh, dash, busybox sh, mksh) instead requiring
> > "which" as extra dependency (usable on containers).
> > Update INSTALL.
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> I think you missed some minor requests from previous review. I can fix
> them before committing. Anyway, Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
> for both patches...
Not sure what I left, but sure, feel free to further tweak it before merge.
Kind regards,
Petr
> Thank you for fixing these issues.
> Daniel
prev parent reply other threads:[~2021-09-03 10:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-30 9:53 [PATCH v2 1/2] bootstrap: INSTALL: Require GNU patch Petr Vorel
2021-08-30 9:53 ` [PATCH v2 2/2] autogen.sh: Detect python Petr Vorel
2021-08-31 18:13 ` Daniel Kiper
2021-09-03 10:49 ` Petr Vorel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTH906YyQSV9aBLe@pevik \
--to=pvorel@suse.cz \
--cc=daniel.kiper@oracle.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.