From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mM6lo-0004r5-Hh for mharc-grub-devel@gnu.org; Fri, 03 Sep 2021 06:50:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37538) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mM6lm-0004qj-En for grub-devel@gnu.org; Fri, 03 Sep 2021 06:50:02 -0400 Received: from smtp-out2.suse.de ([195.135.220.29]:48122) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mM6lk-0002GW-Je for grub-devel@gnu.org; Fri, 03 Sep 2021 06:50:01 -0400 Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id AE3C3203A3; Fri, 3 Sep 2021 10:49:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1630666197; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+oGb3BGrJLUKx24nR0ulphgwOxsHyt4NrFsvH4aoGiI=; b=hWJg51zwuiBjvF3Q7q6rfPnMgo3pt9FlBx/RoZIVnr3iVmN15JKx3RXRMe+aLBN7PHGZ6a pVtM6H1L21+xCu5l4BPfAeV5EeNUYdnUC2VfQQp64ET69pK6h8bvkDTz3YDkvsyFq4FgsC 2SphAVdSo26mNpfa07u0o0Uo63VkDbg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1630666197; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+oGb3BGrJLUKx24nR0ulphgwOxsHyt4NrFsvH4aoGiI=; b=9yAV/MPiytsX69b5NGohagkFCb6rRjZaGrMUWXuzZlJKlL9p4AoY3O6Q1Whrtp+VFxFug2 ALgvdiRqv8VSnVDA== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 8AE311376B; Fri, 3 Sep 2021 10:49:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id 8xTeH9X9MWF9EwAAGKfGzw (envelope-from ); Fri, 03 Sep 2021 10:49:57 +0000 Date: Fri, 3 Sep 2021 12:49:55 +0200 From: Petr Vorel To: daniel.kiper@oracle.com Cc: grub-devel@gnu.org Subject: Re: [PATCH v2 2/2] autogen.sh: Detect python Message-ID: Reply-To: Petr Vorel References: <20210830095317.15290-1-pvorel@suse.cz> <20210830095317.15290-2-pvorel@suse.cz> <20210831181313.chklf43hfcnh6cp3@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210831181313.chklf43hfcnh6cp3@tomti.i.net-space.pl> Received-SPF: pass client-ip=195.135.220.29; envelope-from=pvorel@suse.cz; helo=smtp-out2.suse.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Sep 2021 10:50:02 -0000 Hi Daniel, > On Mon, Aug 30, 2021 at 11:53:17AM +0200, Petr Vorel wrote: > > It help to avoid error on distros which has only python3 binary: > > ./autogen.sh: line 20: python: command not found > > Use python3 as the default as python2 is EOL since Jan 2020, but check > > also python which is on most distros if not all python2 because > > code still works on python2. > > Although it should not be needed keep the possibility to define PYTHON. > > For detection use "command -v" which is POSIX [3] and supported on all > > common shells (bash, zsh, dash, busybox sh, mksh) instead requiring > > "which" as extra dependency (usable on containers). > > Update INSTALL. > > Signed-off-by: Petr Vorel > I think you missed some minor requests from previous review. I can fix > them before committing. Anyway, Reviewed-by: Daniel Kiper > for both patches... Not sure what I left, but sure, feel free to further tweak it before merge. Kind regards, Petr > Thank you for fixing these issues. > Daniel