From: Peter Zijlstra <peterz@infradead.org>
To: Song Liu <songliubraving@fb.com>
Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
acme@kernel.org, mingo@redhat.com, kjain@linux.ibm.com,
kernel-team@fb.com
Subject: Re: [PATCH v5 bpf-next 2/3] bpf: introduce helper bpf_get_branch_snapshot
Date: Fri, 3 Sep 2021 10:28:02 +0200 [thread overview]
Message-ID: <YTHcki5RLZIIGqbk@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20210902165706.2812867-3-songliubraving@fb.com>
On Thu, Sep 02, 2021 at 09:57:05AM -0700, Song Liu wrote:
> +BPF_CALL_3(bpf_get_branch_snapshot, void *, buf, u32, size, u64, flags)
> +{
> +#ifndef CONFIG_X86
> + return -ENOENT;
> +#else
> + static const u32 br_entry_size = sizeof(struct perf_branch_entry);
> + u32 entry_cnt = size / br_entry_size;
> +
> + if (unlikely(flags))
> + return -EINVAL;
> +
> + if (!buf || (size % br_entry_size != 0))
> + return -EINVAL;
> +
> + entry_cnt = static_call(perf_snapshot_branch_stack)(buf, entry_cnt);
> +
> + if (!entry_cnt)
> + return -ENOENT;
> +
> + return entry_cnt * br_entry_size;
> +#endif
> +}
Do we really need that CONFIG_X86 thing? Seems rather bad practise.
next prev parent reply other threads:[~2021-09-03 8:28 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 16:57 [PATCH v5 bpf-next 0/3] bpf: introduce bpf_get_branch_snapshot Song Liu
2021-09-02 16:57 ` [PATCH v5 bpf-next 1/3] perf: enable branch record for software events Song Liu
2021-09-02 20:49 ` John Fastabend
2021-09-03 8:02 ` Peter Zijlstra
2021-09-03 16:50 ` Song Liu
2021-09-07 18:59 ` Song Liu
2021-09-07 20:50 ` Andrii Nakryiko
2021-09-03 8:27 ` Peter Zijlstra
2021-09-03 16:45 ` Song Liu
2021-09-04 10:18 ` Peter Zijlstra
2021-09-02 16:57 ` [PATCH v5 bpf-next 2/3] bpf: introduce helper bpf_get_branch_snapshot Song Liu
2021-09-02 20:56 ` John Fastabend
2021-09-02 22:04 ` Song Liu
2021-09-02 22:53 ` Andrii Nakryiko
2021-09-02 23:03 ` Song Liu
2021-09-02 23:05 ` Andrii Nakryiko
2021-09-03 1:03 ` Alexei Starovoitov
2021-09-03 8:28 ` Peter Zijlstra [this message]
2021-09-03 16:58 ` Song Liu
2021-09-03 8:47 ` Peter Zijlstra
2021-09-03 17:06 ` Song Liu
2021-09-03 17:10 ` Andrii Nakryiko
2021-09-04 10:24 ` Peter Zijlstra
2021-09-04 10:55 ` Peter Zijlstra
2021-09-02 16:57 ` [PATCH v5 bpf-next 3/3] selftests/bpf: add test for bpf_get_branch_snapshot Song Liu
2021-09-02 21:05 ` John Fastabend
2021-09-02 22:54 ` [PATCH v5 bpf-next 0/3] bpf: introduce bpf_get_branch_snapshot Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTHcki5RLZIIGqbk@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=kernel-team@fb.com \
--cc=kjain@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.