From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:5205:0:0:0:0:0 with SMTP id m5csp1182884lfb; Fri, 3 Sep 2021 04:18:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJytKlIKBQ0HrCxtTRb9kPg5tBO+XjPp0eSfAOhhkqEO7+lgpuZXLQTDODBCDBVs3Ge01jKB X-Received: by 2002:a17:906:4e11:: with SMTP id z17mr3571132eju.483.1630667934222; Fri, 03 Sep 2021 04:18:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1630667934; cv=none; d=google.com; s=arc-20160816; b=pJG7WAlghqkJaR992AOSrUL/raQnT1tc7FxE9MkpExWOl+jePSmhNPXvbHKrqSCQ9V sDcn3+2xGfCMSeeu+rmCiIWFVOeKiZ6Cmn+6AldeIeeqf7ABmisBcnFAhipVNMadAF76 eaq7KrZeJhoK3JoV1U/GMaBmy7qFCdodNROvR6cpvn4wUZFv2YHLQZX+zefScKiSYgac jzjdMEBcQkeaIwv419L5kl2MU7FUZdFfijqSu2HdX50LGzrd1jePFtHfB8v+h5I6fzvj I/y5xDaJuFh814ad6Nd0wLjUuoW7jP1jaZYuxSX2phuaJRFJ4mKGSt4v+ZYYhBGwkWlI VFDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-disposition:user-agent :in-reply-to:mime-version:references:reply-to:message-id:subject:cc :to:from:date:dkim-signature; bh=d9H6Y/x3aFTcQdkDCU9IR24Ruj76cNc11pNOs8U9ZeE=; b=pLW+zpBFgoIbogsiZ+31wHlDghXhJRmOGa9iAqCfP06NY3m+rtxXgEaKSRI2bz7p9k bTYIVgvsJhxG6ux1tkXQtBmcbjE+nBJANHh4HI7pE6KJnk/eL6JupwdzZRHIRAsYSILX 84MzsxASftAqCqEtdxOpvGzRUj0OXp4Z4X/KDOTpvg0ATBWbtnuTyL4TLIJcxxheNf4t y256gtGdNAsarOmE9KCBAQcJ48NieAI0X9VGEpHiztCwFlabJFTzlcDbSJLh/DYWuh3+ xWO5xOWsPncW5EQ0kbnZMo/kjMhqhVrSaE+bH1tj6x4YuTsKF1McPbXVFUIEA/LdX/kD /GBw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Za/QDRAP"; spf=pass (google.com: domain of berrange@redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=berrange@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com. [216.205.24.124]) by mx.google.com with ESMTPS id p15si4962651ejy.519.2021.09.03.04.18.53 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Sep 2021 04:18:54 -0700 (PDT) Received-SPF: pass (google.com: domain of berrange@redhat.com designates 216.205.24.124 as permitted sender) client-ip=216.205.24.124; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Za/QDRAP"; spf=pass (google.com: domain of berrange@redhat.com designates 216.205.24.124 as permitted sender) smtp.mailfrom=berrange@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630667933; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d9H6Y/x3aFTcQdkDCU9IR24Ruj76cNc11pNOs8U9ZeE=; b=Za/QDRAPbwAsBoMAwOS/DwwdTJv5UUi7gTufGGV6+TfsOF7pZcecfKw2BRq/jor9NzNeC6 xaRMbCeT+ldjjivmk9pqbdG21z0HfxPTgrxKzax+2lUB+/7qQ4PYFg2aHcnpHUQ4euYN28 c/ZgdnZHJWOcPBbeSP4666pbmE4B5e8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-391-H8poPZlMOuixug7-bAsqBw-1; Fri, 03 Sep 2021 07:18:51 -0400 X-MC-Unique: H8poPZlMOuixug7-bAsqBw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B0970501E1; Fri, 3 Sep 2021 11:18:48 +0000 (UTC) Received: from redhat.com (unknown [10.39.193.241]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5F03210016F4; Fri, 3 Sep 2021 11:18:19 +0000 (UTC) Date: Fri, 3 Sep 2021 12:18:16 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Cc: qemu-devel@nongnu.org, Fam Zheng , Peter Maydell , Li Zhijian , "Michael S. Tsirkin" , Jason Wang , Christian Schoenebeck , Yuval Shaia , Peter Xu , Gerd Hoffmann , Alexandre Iooss , Eric Blake , qemu-block@nongnu.org, Zhang Chen , Alex =?utf-8?Q?Benn=C3=A9e?= , Helge Deller , David Hildenbrand , Markus Armbruster , "Gonglei (Arei)" , Stefan Weil , Laurent Vivier , Thomas Huth , Eduardo Habkost , Michael Roth , Richard Henderson , Greg Kurz , Alex Williamson , qemu-arm@nongnu.org, Paolo Bonzini , John Snow , David Gibson , Kevin Wolf , Vladimir Sementsov-Ogievskiy , Laurent Vivier , Shannon Zhao , Hanna Reitz , qemu-ppc@nongnu.org, Igor Mammedov , Mahmoud Mandour Subject: Re: [PATCH 03/28] qapi: Replace g_memdup() by g_memdup2_qemu() Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20210903110702.588291-1-philmd@redhat.com> <20210903110702.588291-4-philmd@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210903110702.588291-4-philmd@redhat.com> User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-TUID: V3nGLvXtreK7 On Fri, Sep 03, 2021 at 01:06:37PM +0200, Philippe Mathieu-Daudé wrote: > Per https://discourse.gnome.org/t/port-your-module-from-g-memdup-to-g-memdup2-now/5538 > > The old API took the size of the memory to duplicate as a guint, > whereas most memory functions take memory sizes as a gsize. This > made it easy to accidentally pass a gsize to g_memdup(). For large > values, that would lead to a silent truncation of the size from 64 > to 32 bits, and result in a heap area being returned which is > significantly smaller than what the caller expects. This can likely > be exploited in various modules to cause a heap buffer overflow. > > Replace g_memdup() by the safer g_memdup2_qemu() wrapper. This and all following patches should directly use "g_memdup2" rather than the wrapper which is supposed to remain "secret" in the glib-compat.h header. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FE46C433EF for ; Fri, 3 Sep 2021 11:52:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 26ABB60FDC for ; Fri, 3 Sep 2021 11:52:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 26ABB60FDC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:48228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mM7kF-0005dS-9r for qemu-devel@archiver.kernel.org; Fri, 03 Sep 2021 07:52:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mM7Dl-0001Ae-4A for qemu-devel@nongnu.org; Fri, 03 Sep 2021 07:18:57 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:40464) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mM7Di-0007Fm-2x for qemu-devel@nongnu.org; Fri, 03 Sep 2021 07:18:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630667933; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d9H6Y/x3aFTcQdkDCU9IR24Ruj76cNc11pNOs8U9ZeE=; b=Za/QDRAPbwAsBoMAwOS/DwwdTJv5UUi7gTufGGV6+TfsOF7pZcecfKw2BRq/jor9NzNeC6 xaRMbCeT+ldjjivmk9pqbdG21z0HfxPTgrxKzax+2lUB+/7qQ4PYFg2aHcnpHUQ4euYN28 c/ZgdnZHJWOcPBbeSP4666pbmE4B5e8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-391-H8poPZlMOuixug7-bAsqBw-1; Fri, 03 Sep 2021 07:18:51 -0400 X-MC-Unique: H8poPZlMOuixug7-bAsqBw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B0970501E1; Fri, 3 Sep 2021 11:18:48 +0000 (UTC) Received: from redhat.com (unknown [10.39.193.241]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5F03210016F4; Fri, 3 Sep 2021 11:18:19 +0000 (UTC) Date: Fri, 3 Sep 2021 12:18:16 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Subject: Re: [PATCH 03/28] qapi: Replace g_memdup() by g_memdup2_qemu() Message-ID: References: <20210903110702.588291-1-philmd@redhat.com> <20210903110702.588291-4-philmd@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210903110702.588291-4-philmd@redhat.com> User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -12 X-Spam_score: -1.3 X-Spam_bar: - X-Spam_report: (-1.3 / 5.0 requ) DKIMWL_WL_HIGH=-0.392, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Fam Zheng , Peter Maydell , Li Zhijian , "Michael S. Tsirkin" , Jason Wang , Christian Schoenebeck , qemu-devel@nongnu.org, Peter Xu , Gerd Hoffmann , Alexandre Iooss , Eric Blake , qemu-block@nongnu.org, Shannon Zhao , John Snow , Helge Deller , David Hildenbrand , Markus Armbruster , "Gonglei \(Arei\)" , Michael Roth , Laurent Vivier , Thomas Huth , Eduardo Habkost , Stefan Weil , Richard Henderson , Greg Kurz , Yuval Shaia , Alex Williamson , qemu-arm@nongnu.org, Igor Mammedov , Alex =?utf-8?Q?Benn=C3=A9e?= , David Gibson , Kevin Wolf , Vladimir Sementsov-Ogievskiy , Laurent Vivier , Zhang Chen , Hanna Reitz , qemu-ppc@nongnu.org, Paolo Bonzini , Mahmoud Mandour Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Sep 03, 2021 at 01:06:37PM +0200, Philippe Mathieu-Daudé wrote: > Per https://discourse.gnome.org/t/port-your-module-from-g-memdup-to-g-memdup2-now/5538 > > The old API took the size of the memory to duplicate as a guint, > whereas most memory functions take memory sizes as a gsize. This > made it easy to accidentally pass a gsize to g_memdup(). For large > values, that would lead to a silent truncation of the size from 64 > to 32 bits, and result in a heap area being returned which is > significantly smaller than what the caller expects. This can likely > be exploited in various modules to cause a heap buffer overflow. > > Replace g_memdup() by the safer g_memdup2_qemu() wrapper. This and all following patches should directly use "g_memdup2" rather than the wrapper which is supposed to remain "secret" in the glib-compat.h header. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|