From: Matthias Kaehlcke <mka@chromium.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH] arm64: dts: qcom: sc7180-trogdor: Delete ADC config for unused thermistors
Date: Fri, 3 Sep 2021 12:00:53 -0700 [thread overview]
Message-ID: <YTJw5VwHFoCX4WJe@google.com> (raw)
In-Reply-To: <CAE-0n51s1s6L7G1vxbC8PEZ=FBr9mSch81KUBO6fK_jfO8S_CQ@mail.gmail.com>
On Thu, Sep 02, 2021 at 05:20:43PM -0700, Stephen Boyd wrote:
> Quoting Matthias Kaehlcke (2021-09-02 15:47:44)
> > The charger thermistor on Lazor, CoachZ rev1 and Pompom rev1+2 is
> > either the wrong part or not stuffed at all, the same is true for
> > the skin temperature thermistor on CoachZ rev1. The corresponding
> > thermal zones are already disabled for these devices, in addition
> > delete the ADC nodes of the thermistors.
> >
> > For Lazor and CoachZ rev1 also disable the PM6150 ADC thermal
> > monitor since there are no other temperatures to monitor.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium.org>
> > ---
> >
> > .../arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dts | 12 ++++++++++++
> > arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi | 10 ++++++++++
> > .../arm64/boot/dts/qcom/sc7180-trogdor-pompom-r1.dts | 8 ++++++++
> > .../arm64/boot/dts/qcom/sc7180-trogdor-pompom-r2.dts | 8 ++++++++
> > 4 files changed, 38 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dts
> > index 21b516e0694a..edfcd47e1a00 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-coachz-r1.dts
> > @@ -23,6 +23,18 @@ &charger_thermal {
> > status = "disabled";
> > };
> >
> > +&pm6150_adc {
> > + /delete-node/ skin-temp-thermistor@4e;
> > + /delete-node/ charger-thermistor@4f;
>
> Is there any other child node? I only see two, unless I missed
> something. In which case the whole node can be disabled?
Right, the ADC itself can also be disabled in this case.
>
> > +};
> > +
> > +&pm6150_adc_tm {
> > + status = "disabled";
> > +
> > + /delete-node/ charger-thermistor@0;
> > + /delete-node/ skin-temp-thermistor@1;
> > +};
> > +
> > /*
> > * CoachZ rev1 is stuffed with a 47k NTC as thermistor for skin temperature,
> > * which currently is not supported by the PM6150 ADC driver. Disable the
> > diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi
> > index 00535aaa43c9..57f7b19f83b0 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor-lazor.dtsi
> > @@ -54,6 +54,16 @@ &panel {
> > compatible = "boe,nv133fhm-n62";
> > };
> >
> > +&pm6150_adc {
> > + /delete-node/ charger-thermistor@4f;
>
> Same question here.
Yes, the ADC can be disabled here too.
prev parent reply other threads:[~2021-09-03 19:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 22:47 [PATCH] arm64: dts: qcom: sc7180-trogdor: Delete ADC config for unused thermistors Matthias Kaehlcke
2021-09-03 0:20 ` Stephen Boyd
2021-09-03 19:00 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTJw5VwHFoCX4WJe@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.