From: David Gibson <david@gibson.dropbear.id.au>
To: "Cédric Le Goater" <clg@kaod.org>
Cc: qemu-ppc@nongnu.org, Greg Kurz <groug@kaod.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH v2 02/20] ppc/pnv: Add an assert when calculating the RAM distribution on chips
Date: Mon, 6 Sep 2021 10:59:54 +1000 [thread overview]
Message-ID: <YTVoClNf2FsZbqBS@yekko> (raw)
In-Reply-To: <20210902130928.528803-3-clg@kaod.org>
[-- Attachment #1: Type: text/plain, Size: 965 bytes --]
On Thu, Sep 02, 2021 at 03:09:10PM +0200, Cédric Le Goater wrote:
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
Applied to ppc-for-6.2, thanks.
> ---
>
> v2: fixed assert value ...
>
> hw/ppc/pnv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index 03c86508d2f7..71e45515f136 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -723,6 +723,8 @@ static uint64_t pnv_chip_get_ram_size(PnvMachineState *pnv, int chip_id)
> return QEMU_ALIGN_DOWN(ram_per_chip, 1 * MiB);
> }
>
> + assert(pnv->num_chips > 1);
> +
> ram_per_chip = (machine->ram_size - 1 * GiB) / (pnv->num_chips - 1);
> return chip_id == 0 ? 1 * GiB : QEMU_ALIGN_DOWN(ram_per_chip, 1 * MiB);
> }
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-09-06 3:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 13:09 [PATCH v2 00/20] ppc/pnv: Extend the powernv10 machine Cédric Le Goater
2021-09-02 13:09 ` [PATCH v2 01/20] docs/system: ppc: Update the URL for OpenPOWER firmware images Cédric Le Goater
2021-09-03 9:43 ` Greg Kurz
2021-09-06 0:59 ` David Gibson
2021-09-02 13:09 ` [PATCH v2 02/20] ppc/pnv: Add an assert when calculating the RAM distribution on chips Cédric Le Goater
2021-09-03 9:46 ` Greg Kurz
2021-09-06 0:59 ` David Gibson [this message]
2021-09-02 13:09 ` [PATCH v2 03/20] ppc/xive2: Introduce a XIVE2 core framework Cédric Le Goater
2021-09-02 13:09 ` [PATCH v2 04/20] ppc/xive2: Introduce a presenter matching routine Cédric Le Goater
2021-09-02 13:09 ` [PATCH v2 05/20] ppc/pnv: Add a XIVE2 controller to the POWER10 chip Cédric Le Goater
2021-09-02 13:09 ` [PATCH v2 06/20] ppc/pnv: Add a OCC model for POWER10 Cédric Le Goater
2021-09-02 13:09 ` [PATCH v2 07/20] ppc/pnv: Add POWER10 quads Cédric Le Goater
2021-09-02 13:09 ` [PATCH v2 08/20] ppc/pnv: Add model for POWER10 PHB5 PCIe Host bridge Cédric Le Goater
2021-09-02 13:09 ` [PATCH v2 09/20] ppc/pnv: Add a HOMER model to POWER10 Cédric Le Goater
2021-09-02 13:09 ` [PATCH v2 10/20] ppc/psi: Add support for StoreEOI and 64k ESB pages (POWER10) Cédric Le Goater
2021-09-02 13:09 ` [PATCH v2 11/20] ppc/xive2: Add support for notification injection on ESB pages Cédric Le Goater
2021-09-02 13:09 ` [PATCH v2 12/20] ppc/xive: Add support for PQ state bits offload Cédric Le Goater
2021-09-02 13:09 ` [PATCH v2 13/20] ppc/pnv: Add support for PQ offload on PHB5 Cédric Le Goater
2021-09-02 13:09 ` [PATCH v2 14/20] ppc/pnv: Add support for PHB5 "Address-based trigger" mode Cédric Le Goater
2021-09-02 13:09 ` [PATCH v2 15/20] pnv/xive2: Introduce new capability bits Cédric Le Goater
2021-09-02 13:09 ` [PATCH v2 16/20] ppc/pnv: add XIVE Gen2 TIMA support Cédric Le Goater
2021-09-02 13:09 ` [PATCH v2 17/20] pnv/xive2: Add support XIVE2 P9-compat mode (or Gen1) Cédric Le Goater
2021-09-02 13:09 ` [PATCH v2 18/20] xive2: Add a get_config() handler for the router configuration Cédric Le Goater
2021-09-02 13:09 ` [PATCH v2 19/20] pnv/xive2: Add support for automatic save&restore Cédric Le Goater
2021-09-02 13:09 ` [PATCH v2 20/20] pnv/xive2: Add support for 8bits thread id Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTVoClNf2FsZbqBS@yekko \
--to=david@gibson.dropbear.id.au \
--cc=clg@kaod.org \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.