From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyril Hrubis Date: Mon, 6 Sep 2021 17:17:22 +0200 Subject: [LTP] [PATCH] getuid: Convert getuid01 and getuid03 to new API In-Reply-To: <20210826090511.106853-1-threefifteen.wangkunfeng@huawei.com> References: <20210826090511.106853-1-threefifteen.wangkunfeng@huawei.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi! Looks good, but there is no value in keeping the getuid01.c because it tests same assertion that is covered in getuid03.c as well. So I would keep only getuid01.c and moved the functionality from getuid03.c there. -- Cyril Hrubis chrubis@suse.cz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D59B6C433EF for ; Mon, 6 Sep 2021 15:17:25 +0000 (UTC) Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2375560F12 for ; Mon, 6 Sep 2021 15:17:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2375560F12 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux.it Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id E5D6D3C94E2 for ; Mon, 6 Sep 2021 17:17:22 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [IPv6:2001:4b78:1:20::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id 2D6B03C05A0 for ; Mon, 6 Sep 2021 17:17:12 +0200 (CEST) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id E4E531A009BB for ; Mon, 6 Sep 2021 17:17:11 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 259E62217D; Mon, 6 Sep 2021 15:17:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1630941431; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vexp+N8Hq1xxmQYQQhmLlptBktyNUduMIMuVM1VKDco=; b=Y+Ske27KlEb6JRhMDDrcXcozJIkJjXXKxMjLyyvBxkWIc5kOr+bEc9zYe9Cbf9kVbTtp09 Sutio8kd99DJjGl/4r5UH8ayjCJcBzH2+ERmgzE7WD0L8EPDrvmtgKf4FJl1bSCy4gOMmR L639WHjBTpdBUIqTK3KEfPKRsdkqn98= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1630941431; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vexp+N8Hq1xxmQYQQhmLlptBktyNUduMIMuVM1VKDco=; b=47SfKevAVBSBKvbvUg+zsZflUeQnIq5kAONwjw+S4/RbOZsBTFFaLejAjAJfIRHJcukcjB OajCyjqwmp2DUhAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0AC8A13C29; Mon, 6 Sep 2021 15:17:11 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id QjzPAfcwNmGBbAAAMHmgww (envelope-from ); Mon, 06 Sep 2021 15:17:11 +0000 Date: Mon, 6 Sep 2021 17:17:22 +0200 From: Cyril Hrubis To: Wang Kunfeng Message-ID: References: <20210826090511.106853-1-threefifteen.wangkunfeng@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210826090511.106853-1-threefifteen.wangkunfeng@huawei.com> X-Virus-Scanned: clamav-milter 0.102.4 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH] getuid: Convert getuid01 and getuid03 to new API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Message-ID: <20210906151722.YpFEG1CKitZAdGJGbu6GYKQfst1edmofg_-17cz_NSY@z> Hi! Looks good, but there is no value in keeping the getuid01.c because it tests same assertion that is covered in getuid03.c as well. So I would keep only getuid01.c and moved the functionality from getuid03.c there. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp