Re: [PATCH 2/2] dt-bindings: display: Add binding for LG.Philips SW43101

[Rob Herring <robh@kernel.org>]

On Wed, Sep 01, 2021 at 06:07:30PM +0000, Yassine Oudjana wrote:
> Add a device tree binding for LG.Philips SW43101.
> 
> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
> ---
>  .../display/panel/lgphilips,sw43101.yaml      | 52 +++++++++++++++++++
>  1 file changed, 52 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/lgphilips,sw43101.yaml
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/lgphilips,sw43101.yaml b/Documentation/devicetree/bindings/display/panel/lgphilips,sw43101.yaml
> new file mode 100644
> index 000000000000..da049e9f244e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/lgphilips,sw43101.yaml
> @@ -0,0 +1,52 @@
> +# SPDX-License-Identifier: BSD-3-Clause

Not the right license(s). checkpatch.pl will tell you.

> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/lgphilips,sw43101.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: LG.Philips SW43101 1080x1920 OLED panel
> +
> +maintainers:
> +  - Yassine Oudjana <y.oudjana@protonmail.com>
> +
> +allOf:
> +  - $ref: panel-common.yaml#
> +
> +properties:
> +  compatible:
> +    const: lgphilips,sw43101

Looks like this can be added to panel-simple-dsi.yaml instead. Unless it 
has more than 1 power rail as you didn't document any.

> +
> +  port: true
> +  reg: true
> +  reset-gpios: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - reset-gpios
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/gpio/gpio.h>
> +
> +    dsi {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        panel@0 {
> +            compatible = "lgphilips,sw43101";
> +            reg = <0>;
> +
> +            reset-gpios = <&msmgpio 8 GPIO_ACTIVE_LOW>;
> +
> +            port {
> +                panel_in: endpoint {
> +                    remote-endpoint = <&dsi_out>;
> +                };
> +            };
> +        };
> +    };
> +
> +...
> -- 
> 2.33.0
> 
> 
>