From: Matthias Kaehlcke <mka@chromium.org>
To: skakit@codeaurora.org
Cc: Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
swboyd@chromium.org, kgunda@codeaurora.org,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: qcom: pm8350c: Add pwm support
Date: Wed, 8 Sep 2021 08:29:56 -0700 [thread overview]
Message-ID: <YTjW9LAGhTuszoa4@google.com> (raw)
In-Reply-To: <b10e5f36fb0216a4c951d752f5103099@codeaurora.org>
On Wed, Sep 08, 2021 at 02:37:39PM +0530, skakit@codeaurora.org wrote:
> On 2021-09-07 23:46, Matthias Kaehlcke wrote:
> > On Mon, Sep 06, 2021 at 04:11:07PM +0530, satya priya wrote:
> > > Add pwm support for PM8350C pmic.
> > >
> > > Signed-off-by: satya priya <skakit@codeaurora.org>
> > > ---
> > > arch/arm64/boot/dts/qcom/pm8350c.dtsi | 6 ++++++
> > > 1 file changed, 6 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/pm8350c.dtsi
> > > b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
> > > index e1b75ae..ecdae55 100644
> > > --- a/arch/arm64/boot/dts/qcom/pm8350c.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/pm8350c.dtsi
> > > @@ -29,6 +29,12 @@
> > > interrupt-controller;
> > > #interrupt-cells = <2>;
> > > };
> > > +
> > > + pm8350c_pwm4: pwm {
> >
> > What does the '4' represent, an internal channel number? It should
> > probably be omitted if the PM8350 only has a single output PWM
> > port.
> >
>
> pm8350c has four PWMs, but I think we can drop the '4' here.
Why is only one PWM exposed if the PMIC has for of them? Why number 4
and not one of the others?
next prev parent reply other threads:[~2021-09-08 15:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 10:41 [PATCH 0/3] Add PM8350C PMIC PWM support for backlight satya priya
2021-09-06 10:41 ` [PATCH 1/3] dt-bindings: leds: Add pm8350c pmic support satya priya
2021-09-07 17:48 ` Matthias Kaehlcke
2021-09-07 20:03 ` Stephen Boyd
2021-09-08 13:52 ` Rob Herring
2021-09-06 10:41 ` [PATCH 2/3] leds: Add pm8350c support to Qualcomm LPG driver satya priya
2021-09-07 17:54 ` Matthias Kaehlcke
2021-09-07 17:58 ` Matthias Kaehlcke
2021-09-07 18:02 ` Matthias Kaehlcke
2021-09-07 20:20 ` Stephen Boyd
2021-09-08 9:17 ` skakit
2021-09-08 17:11 ` Bjorn Andersson
2021-09-06 10:41 ` [PATCH 3/3] arm64: dts: qcom: pm8350c: Add pwm support satya priya
2021-09-07 18:16 ` Matthias Kaehlcke
2021-09-08 9:07 ` skakit
2021-09-08 15:29 ` Matthias Kaehlcke [this message]
2021-09-08 17:08 ` Bjorn Andersson
2021-09-09 6:11 ` skakit
2021-09-08 3:34 ` Stephen Boyd
2021-09-08 9:14 ` skakit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTjW9LAGhTuszoa4@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kgunda@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=skakit@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.