From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25239C433EF for ; Thu, 9 Sep 2021 05:36:36 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 9B8FF61178 for ; Thu, 9 Sep 2021 05:36:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9B8FF61178 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 1D6834A19A; Thu, 9 Sep 2021 01:36:35 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@google.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wI0lHokgrwM8; Thu, 9 Sep 2021 01:36:34 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 186AA4B0F3; Thu, 9 Sep 2021 01:36:34 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 15CFD4B0C2 for ; Thu, 9 Sep 2021 01:36:33 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ggBO-3sji-9W for ; Thu, 9 Sep 2021 01:36:21 -0400 (EDT) Received: from mail-il1-f176.google.com (mail-il1-f176.google.com [209.85.166.176]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 904DF4A19A for ; Thu, 9 Sep 2021 01:36:21 -0400 (EDT) Received: by mail-il1-f176.google.com with SMTP id x10so717053ilm.12 for ; Wed, 08 Sep 2021 22:36:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rs5Tku62bnXK35H0Ulh2hfV6Nn9BVEa4pNd3KqkqUPs=; b=GMYQBh6WtXAaT5vNg8hi9Kb7xMdP3NL5qvzhh7Ue+yitvRoS2SOSlMiAf34qHAUOYb fxbnbFHZlBEtGe5Dl1hVQT1yA49nnbTthLHge+Pdh0Qv22zejYyAiivtcBg+ous2chQ9 nDhlQu96I30StM5J6gnplhjyT+qyeJEVbxKpp+xMSoNAXousbBAJirlV1a/CrEyefBhO pI8q4n+Itugi/jPAQrP/0j2b6ipq4nt8miMBop9exEii3zQzzyPmh8XNEtoV+yW8RBS2 zk/iIl8kAp8QzxOoM46ukJRXafhKCM9e6QCgoVq4mW5BBz+409Ab+Y+/+T7iT6wRw7NQ EUAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rs5Tku62bnXK35H0Ulh2hfV6Nn9BVEa4pNd3KqkqUPs=; b=0SBy7PrOAIp8IUIUhIBIKarBm9USinL+RjMK0SztOCmpXloNDbYSGwDAfCfBVu16HY RX6LjI+qHy0tmN/uvMYIpwYKseMUvdYe4gxLpYkXgHMtVkvQUzYFLwCAL4I8nCVCH5ib EdQllimNTz/g7+gOk+GxP/+cHsqHG0NREzWQmWHdTDwY3wUDYtS8UAycsfApZA48zCmb GrD0SrCun9yO2MVFIzYR/JicPc9wIbidspaC39xRYdwsl2LL26gRyU09kd2f6bMcD8aT aOofXHTS1CMwYuEwP+Mj7wmzS8VDCLJeILP6/FdYzzHZ81bq+Rw6oHT8LaJbi3H3qqXc oI0w== X-Gm-Message-State: AOAM531JUqbF0SHR3xKOvzDSQ9pkH7WHuWlgFyiBvomLbESfEUoQYi67 iUXDYCyaCA8XwOuQvcK3vslOUw== X-Google-Smtp-Source: ABdhPJz2tiiZiLS+hXn/+gHFSIX1wmyP8hppIZxSTGQIgnCL75/acuIPebWpw5ZoRZACvU+9n9ydSw== X-Received: by 2002:a92:da49:: with SMTP id p9mr1010706ilq.89.1631165780802; Wed, 08 Sep 2021 22:36:20 -0700 (PDT) Received: from google.com (194.225.68.34.bc.googleusercontent.com. [34.68.225.194]) by smtp.gmail.com with ESMTPSA id c11sm424815ilu.74.2021.09.08.22.36.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Sep 2021 22:36:20 -0700 (PDT) Date: Thu, 9 Sep 2021 05:36:16 +0000 From: Oliver Upton To: Raghavendra Rao Ananta Subject: Re: [PATCH v4 18/18] KVM: selftests: vgic_init: Pull REDIST_REGION_ATTR_ADDR from vgic.h Message-ID: References: <20210909013818.1191270-1-rananta@google.com> <20210909013818.1191270-19-rananta@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210909013818.1191270-19-rananta@google.com> Cc: kvm@vger.kernel.org, Will Deacon , Marc Zyngier , Peter Shier , linux-kernel@vger.kernel.org, Catalin Marinas , Paolo Bonzini , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Thu, Sep 09, 2021 at 01:38:18AM +0000, Raghavendra Rao Ananta wrote: > Pull the definition of REDIST_REGION_ATTR_ADDR from vgic.h. > > Signed-off-by: Raghavendra Rao Ananta > --- > tools/testing/selftests/kvm/aarch64/vgic_init.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Just squash this into the commit where you hoist it into vgic.h. It is fine to glob it together with the other vgic changes since you're dropping it into a completely new header file. -- Thanks, Oliver _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52692C433F5 for ; Thu, 9 Sep 2021 05:38:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F0DE6113E for ; Thu, 9 Sep 2021 05:38:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0F0DE6113E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RZt1i5AqAmcRE5PPxRC64w/3RQEPkVcDHqsyEzmspx8=; b=D/QRyAk6Wv6lGz IK5edjK+4tWY8pf4zMtovHXwvWUrg8omeW8NJFsGzsAbGdY+dl+kwxBoUdq+b860aAxhDcLobeJl2 QZnJQtD5EfWMEAI7pQRXG097l0njkb7SBsOnwCUlk9HgRWovv8H6lvy46IV/N8BN3xA5KR4bDFWzI +N5YADgoD0cvuRx4ftlgPKUcL8myYn4MaukKe93iaWpC3pvNd+Z3IZ3PQgE00JMPsmmko9GI+zKyp GP/Si5FLPYjQG0OupLW+LHk/HFGlu2Y1rkH588kY+RW9lgZN8VRSLdxmDx3qdpoxuiLAYgzMwEnr7 sBIM7k4f668/y1enqEUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOCjZ-008FY4-Rc; Thu, 09 Sep 2021 05:36:26 +0000 Received: from mail-il1-x131.google.com ([2607:f8b0:4864:20::131]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mOCjV-008FXJ-Sl for linux-arm-kernel@lists.infradead.org; Thu, 09 Sep 2021 05:36:23 +0000 Received: by mail-il1-x131.google.com with SMTP id v16so727838ilo.10 for ; Wed, 08 Sep 2021 22:36:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rs5Tku62bnXK35H0Ulh2hfV6Nn9BVEa4pNd3KqkqUPs=; b=GMYQBh6WtXAaT5vNg8hi9Kb7xMdP3NL5qvzhh7Ue+yitvRoS2SOSlMiAf34qHAUOYb fxbnbFHZlBEtGe5Dl1hVQT1yA49nnbTthLHge+Pdh0Qv22zejYyAiivtcBg+ous2chQ9 nDhlQu96I30StM5J6gnplhjyT+qyeJEVbxKpp+xMSoNAXousbBAJirlV1a/CrEyefBhO pI8q4n+Itugi/jPAQrP/0j2b6ipq4nt8miMBop9exEii3zQzzyPmh8XNEtoV+yW8RBS2 zk/iIl8kAp8QzxOoM46ukJRXafhKCM9e6QCgoVq4mW5BBz+409Ab+Y+/+T7iT6wRw7NQ EUAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rs5Tku62bnXK35H0Ulh2hfV6Nn9BVEa4pNd3KqkqUPs=; b=OxdIwKUoMEHJ68a6iZZES7OMIml3GwEmS18+1O0Qq1eqdRhWIgqGJ5NXR3QN7JcxLl FUurvIANH8wfbioVJDim0KaqujUooP9yRWppp1RP3I4CLM/7AtK4hMB4zsSGVglEv7iX 3tLrDhJ1uI5GTviE3ckzkrS2Ja82hnwp8JOyki0W0SHY4e8iFbesZCipyluvswnRD6iF y+XNsauQZHfHayE4J6nWNi4wMev76LUIPmQRPpJAqv1EZYvPwfL10P4mfQyI2yeT1nO2 pu1+0AwcJtR7NzWtReSwzKN51u4EIo6OxZAkMAK2eOyI0m8+EGaLOP2R9P5BqwM4FCe5 P7zA== X-Gm-Message-State: AOAM530XwSsJCxBaFmxloN2qkmubOyW/31syG8uP22GoI2wKPSYWpGyZ 0MrSs34r4+MtHx4/wVuiYM3Epg== X-Google-Smtp-Source: ABdhPJz2tiiZiLS+hXn/+gHFSIX1wmyP8hppIZxSTGQIgnCL75/acuIPebWpw5ZoRZACvU+9n9ydSw== X-Received: by 2002:a92:da49:: with SMTP id p9mr1010706ilq.89.1631165780802; Wed, 08 Sep 2021 22:36:20 -0700 (PDT) Received: from google.com (194.225.68.34.bc.googleusercontent.com. [34.68.225.194]) by smtp.gmail.com with ESMTPSA id c11sm424815ilu.74.2021.09.08.22.36.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Sep 2021 22:36:20 -0700 (PDT) Date: Thu, 9 Sep 2021 05:36:16 +0000 From: Oliver Upton To: Raghavendra Rao Ananta Cc: Paolo Bonzini , Marc Zyngier , Andrew Jones , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Peter Shier , Ricardo Koller , Reiji Watanabe , Jing Zhang , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v4 18/18] KVM: selftests: vgic_init: Pull REDIST_REGION_ATTR_ADDR from vgic.h Message-ID: References: <20210909013818.1191270-1-rananta@google.com> <20210909013818.1191270-19-rananta@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210909013818.1191270-19-rananta@google.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210908_223621_998759_881B6EDB X-CRM114-Status: GOOD ( 12.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 09, 2021 at 01:38:18AM +0000, Raghavendra Rao Ananta wrote: > Pull the definition of REDIST_REGION_ATTR_ADDR from vgic.h. > > Signed-off-by: Raghavendra Rao Ananta > --- > tools/testing/selftests/kvm/aarch64/vgic_init.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Just squash this into the commit where you hoist it into vgic.h. It is fine to glob it together with the other vgic changes since you're dropping it into a completely new header file. -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7A50C433F5 for ; Thu, 9 Sep 2021 05:36:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A44646113E for ; Thu, 9 Sep 2021 05:36:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350792AbhIIFhb (ORCPT ); Thu, 9 Sep 2021 01:37:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350756AbhIIFha (ORCPT ); Thu, 9 Sep 2021 01:37:30 -0400 Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A920BC061757 for ; Wed, 8 Sep 2021 22:36:21 -0700 (PDT) Received: by mail-il1-x12c.google.com with SMTP id h29so749072ila.2 for ; Wed, 08 Sep 2021 22:36:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rs5Tku62bnXK35H0Ulh2hfV6Nn9BVEa4pNd3KqkqUPs=; b=GMYQBh6WtXAaT5vNg8hi9Kb7xMdP3NL5qvzhh7Ue+yitvRoS2SOSlMiAf34qHAUOYb fxbnbFHZlBEtGe5Dl1hVQT1yA49nnbTthLHge+Pdh0Qv22zejYyAiivtcBg+ous2chQ9 nDhlQu96I30StM5J6gnplhjyT+qyeJEVbxKpp+xMSoNAXousbBAJirlV1a/CrEyefBhO pI8q4n+Itugi/jPAQrP/0j2b6ipq4nt8miMBop9exEii3zQzzyPmh8XNEtoV+yW8RBS2 zk/iIl8kAp8QzxOoM46ukJRXafhKCM9e6QCgoVq4mW5BBz+409Ab+Y+/+T7iT6wRw7NQ EUAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rs5Tku62bnXK35H0Ulh2hfV6Nn9BVEa4pNd3KqkqUPs=; b=JWsyH8jahA7voU5S7m+zoxkyOVr3Qukooluc9Rf1DrFkJtqhHhXNWLE9o4xg6UXiB9 +q9LY++eJS+8IffhXHont87njiICZsC0rNfw+V7IyfeDKfNgcTMIuPMi6Zeg+6SmUALX 7ar6cZD9L635m5rHVpEiSJawGgNpSRy9R0PJFWakfGI6ERRyTHCOCFPMMfKl3NV1/RRN TWnE4i3biQga8eci/NBFF+XGbrD7r3GkIU9db8bAR7L79fuNhyodENWTHct8zhx/VXjK iRmFkeaY0lJ+77KqSiFVTaZMordLN3ZS96oDdI4ZAkXq3AHe6U5Wb25+7DnvYXTJbjND 2AEQ== X-Gm-Message-State: AOAM530cwVMmmRDXBF9jV9QcYb4in6xQpkYxh+e2Pzpd1kR5P8MdX9WR odiGCWuga4PXJJQW9jg56MpANg== X-Google-Smtp-Source: ABdhPJz2tiiZiLS+hXn/+gHFSIX1wmyP8hppIZxSTGQIgnCL75/acuIPebWpw5ZoRZACvU+9n9ydSw== X-Received: by 2002:a92:da49:: with SMTP id p9mr1010706ilq.89.1631165780802; Wed, 08 Sep 2021 22:36:20 -0700 (PDT) Received: from google.com (194.225.68.34.bc.googleusercontent.com. [34.68.225.194]) by smtp.gmail.com with ESMTPSA id c11sm424815ilu.74.2021.09.08.22.36.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Sep 2021 22:36:20 -0700 (PDT) Date: Thu, 9 Sep 2021 05:36:16 +0000 From: Oliver Upton To: Raghavendra Rao Ananta Cc: Paolo Bonzini , Marc Zyngier , Andrew Jones , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Peter Shier , Ricardo Koller , Reiji Watanabe , Jing Zhang , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH v4 18/18] KVM: selftests: vgic_init: Pull REDIST_REGION_ATTR_ADDR from vgic.h Message-ID: References: <20210909013818.1191270-1-rananta@google.com> <20210909013818.1191270-19-rananta@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210909013818.1191270-19-rananta@google.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Sep 09, 2021 at 01:38:18AM +0000, Raghavendra Rao Ananta wrote: > Pull the definition of REDIST_REGION_ATTR_ADDR from vgic.h. > > Signed-off-by: Raghavendra Rao Ananta > --- > tools/testing/selftests/kvm/aarch64/vgic_init.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Just squash this into the commit where you hoist it into vgic.h. It is fine to glob it together with the other vgic changes since you're dropping it into a completely new header file. -- Thanks, Oliver