From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 824DDC433FE for ; Thu, 9 Sep 2021 14:41:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C54161222 for ; Thu, 9 Sep 2021 14:41:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1350798AbhIIOmV (ORCPT ); Thu, 9 Sep 2021 10:42:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347204AbhIIOmQ (ORCPT ); Thu, 9 Sep 2021 10:42:16 -0400 Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D44CC077581 for ; Thu, 9 Sep 2021 07:06:24 -0700 (PDT) Received: by mail-pl1-x633.google.com with SMTP id n4so1123033plh.9 for ; Thu, 09 Sep 2021 07:06:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=L8cDWmvCb4eOy7vGO37SrXUiP73ZTPhnnqWMVCnZKbw=; b=HfwNGyoSZrV4f3V7zT2kav9EMAC9qMpLvHk5yVzNXe42jf4uTRlOa7EOuFDEeypemL BAedshFTqgxWd0P3C7xWqTMPcxDKu7YU4b13Mqsw5niZauVRS4Hd0DBaoi/9DOy6621h MXeqknSlPpHh/p+mvmqmDefBPrrEFb7AIPzyE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=L8cDWmvCb4eOy7vGO37SrXUiP73ZTPhnnqWMVCnZKbw=; b=P9rAGXbFlhgLTNBbOjspGANp6P654i06Ptz+b+CzflaDtjtIhk8TFjV6iXBYGPo3ka HnSk1mpe21d5UL3qqfbIdRVZ9toIIZGcdVO7h6eOYaOc/A0MXuzK6G5kO2cux1aDKiET r97r+ckAYuwLXP10E2ZCS7Xa06il17Inr6y1H5vgzeyG7XUzJvP4EuWGgc2OWOEe94PE gezYtevXuaDzGSfp8/QRqWuEwa5FFcalso3Wd1VSUsDZOUrjwsyOG/1JbMgE5KN8aytp kCw+dTVwupOKWK/PE5GAtA3TfAOh77K4ehk5YXLJ6HCV5WcFYSeuzwJv0jdkHjI8SYvp 6qwg== X-Gm-Message-State: AOAM533J49OLMNu1IigfOGq8sbL2xHWSkGsn0nz5uQPd+E+YsNeYjeoR Bl+SQHuvRBw4RrnZXK7ySpgodQ== X-Google-Smtp-Source: ABdhPJziK5kHfyO9p4YECF5ExYztPTeAX5R3q/XOTyZf29rNhAiWZ7bJ7anxKxSntk4vC+pRtcDqlA== X-Received: by 2002:a17:90b:1085:: with SMTP id gj5mr3775623pjb.66.1631196383841; Thu, 09 Sep 2021 07:06:23 -0700 (PDT) Received: from localhost ([2620:15c:202:201:27cc:a1d4:ed44:e1de]) by smtp.gmail.com with UTF8SMTPSA id e5sm2372644pjv.44.2021.09.09.07.06.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Sep 2021 07:06:22 -0700 (PDT) Date: Thu, 9 Sep 2021 07:06:21 -0700 From: Matthias Kaehlcke To: rajpat@codeaurora.org Cc: Andy Gross , Bjorn Andersson , Rob Herring , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, rnayak@codeaurora.org, saiprakash.ranjan@codeaurora.org, msavaliy@qti.qualcomm.com, skakit@codeaurora.org, sboyd@kernel.org, dianders@chromium.org Subject: Re: [PATCH V7 3/7] arm64: dts: sc7280: Add QUPv3 wrapper_0 nodes Message-ID: References: <1630643340-10373-1-git-send-email-rajpat@codeaurora.org> <1630643340-10373-4-git-send-email-rajpat@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Sep 09, 2021 at 10:16:04AM +0530, rajpat@codeaurora.org wrote: > On 2021-09-03 22:03, Matthias Kaehlcke wrote: > > On Fri, Sep 03, 2021 at 09:58:56AM +0530, Rajesh Patil wrote: > > > From: Roja Rani Yarubandi > > > > > > Add QUPv3 wrapper_0 DT nodes for SC7280 SoC. > > > > > > Signed-off-by: Roja Rani Yarubandi > > > Signed-off-by: Rajesh Patil > > > --- > > > arch/arm64/boot/dts/qcom/sc7280.dtsi | 684 > > > ++++++++++++++++++++++++++++++++++- > > > 1 file changed, 682 insertions(+), 2 deletions(-) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi > > > b/arch/arm64/boot/dts/qcom/sc7280.dtsi > > > index 7ec9871..5c6a1d7 100644 > > > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi > > > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi > > > > > > ... > > > > > > + qup_spi0_data_clk: qup-spi0-data-clk { > > > + pins = "gpio0", "gpio1", "gpio2"; > > > + function = "qup00"; > > > + }; > > > + > > > + qup_spi0_cs: qup-spi0-cs { > > > + pins = "gpio3"; > > > + function = "qup00"; > > > + }; > > > > > > I think we still want this for all SPI ports, which existed in previous > > versions: > > > > qup_spi0_cs_gpio: qup-spi0-cs-gpio { > > pins = "gpio3"; > > function = "gpio"; > > }; > > > > It just shouldn't be selected together with 'qup_spiN_cs'. > > > > Maybe a follow up patch would be good enough, so: > > > > Reviewed-by: Matthias Kaehlcke > > > ok.shall we add qup_spiN_cs_gpio for all spi ports Yes