From: Phillip Potter <phil@philpotter.co.uk>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Lukas Prediger <lumip@lumip.de>,
axboe@kernel.dk, hch@infradead.org, linux-kernel@vger.kernel.org,
linux-block@vger.kernel.org
Subject: Re: [PATCH v2] drivers/cdrom: improved ioctl for media change detection
Date: Fri, 10 Sep 2021 08:59:56 +0100 [thread overview]
Message-ID: <YTsQfBwSPkZasDff@equinox> (raw)
In-Reply-To: <10f60086-2be0-d26d-dfa6-fe128772a409@infradead.org>
On Thu, Sep 09, 2021 at 06:25:35PM -0700, Randy Dunlap wrote:
> I have no problem with Jens's suggestion. It would look more like this:
>
> +{
> + __s64 last_media_change; /* Timestamp of the last detected media
> + * change in ms. May be set by caller, updated
> + * upon successful return of ioctl.
> + */
> + __u64 media_flags; /* various <struct> flags */
>
> #define MEDIA_CHANGED 0x1 /* Set to 1 by ioctl if last detected media */
> /* other bits of media_flags available for future use */
>
>
> and not having __u64 has_changed;
> which is overkill for a flag.
>
> --
> ~Randy
>
Yeah I like this, good idea. Thanks.
Regards,
Phil
next prev parent reply other threads:[~2021-09-10 8:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-29 14:37 [PATCH v2] drivers/cdrom: improved ioctl for media change detection Lukas Prediger
2021-09-06 20:11 ` Jens Axboe
2021-09-06 22:57 ` Phillip Potter
2021-09-08 23:51 ` Phillip Potter
2021-09-09 18:04 ` Lukas Prediger
2021-09-09 23:07 ` Phillip Potter
2021-09-07 6:35 ` Christoph Hellwig
2021-09-09 0:17 ` Phillip Potter
2021-09-09 0:42 ` Randy Dunlap
2021-09-09 18:05 ` Lukas Prediger
2021-09-09 23:20 ` Phillip Potter
2021-09-10 1:25 ` Randy Dunlap
2021-09-10 7:59 ` Phillip Potter [this message]
2021-09-09 23:00 ` Phillip Potter
-- strict thread matches above, loose matches on Subject: below --
2021-08-31 18:08 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YTsQfBwSPkZasDff@equinox \
--to=phil@philpotter.co.uk \
--cc=axboe@kernel.dk \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumip@lumip.de \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.