From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cyril Hrubis Date: Fri, 10 Sep 2021 16:33:06 +0200 Subject: [LTP] [PATCH 4/8] syscalls/setresgid02: Convert to new API In-Reply-To: <20210909155126.2720-4-mdoucha@suse.cz> References: <20210909155126.2720-1-mdoucha@suse.cz> <20210909155126.2720-4-mdoucha@suse.cz> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ltp@lists.linux.it Hi! I've pushed patches up to this point, thanks. For the rest it has to be decided if we will use TST_EXP_FAIL() or not. I've also did a minor changes to this patch, see below. > +/*\ > + * [Description] > + * > + * Verify that setresgid() will successfully set the expected GID when called > + * by root with the following combinations of arguments: > + * 1. setresgid(-1, -1, -1) > + * 2. setresgid(-1, -1, other) > + * 3. setresgid(-1, other, -1) > + * 4. setresgid(other, -1, -1) > + * 5. setresgid(root, root, root) > + * 6. setresgid(root, main, main) > + */ I've reformatted this part so that it rendes as a list in the asciidoc syntax. > struct test_case_t { /* test case structure */ > - uid_t *rgid; /* real GID */ > - uid_t *egid; /* effective GID */ > - uid_t *sgid; /* saved GID */ > - struct passwd *exp_rgid; /* Expected real GID */ > - struct passwd *exp_egid; /* Expected effective GID */ > - struct passwd *exp_sgid; /* Expected saved GID */ > + gid_t *rgid; /* real GID */ > + gid_t *egid; /* effective GID */ > + gid_t *sgid; /* saved GID */ > + gid_t *exp_rgid; /* Expected real GID */ > + gid_t *exp_egid; /* Expected effective GID */ > + gid_t *exp_sgid; /* Expected saved GID */ > char *desc; /* Test description */ > }; And also got rid of these useless comments, that were commenting the obvious. -- Cyril Hrubis chrubis@suse.cz From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC409C433EF for ; Fri, 10 Sep 2021 14:33:04 +0000 (UTC) Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E6D6610F8 for ; Fri, 10 Sep 2021 14:33:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2E6D6610F8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux.it Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 5828A3C96A2 for ; Fri, 10 Sep 2021 16:33:01 +0200 (CEST) Received: from in-3.smtp.seeweb.it (in-3.smtp.seeweb.it [IPv6:2001:4b78:1:20::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id DEB613C05AE for ; Fri, 10 Sep 2021 16:32:51 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-3.smtp.seeweb.it (Postfix) with ESMTPS id E4F221A00E02 for ; Fri, 10 Sep 2021 16:32:50 +0200 (CEST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 5C45620211; Fri, 10 Sep 2021 14:32:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1631284370; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0gCvHaFoaErwZzq8spVYY8j7DbpH/CPgcbOQt2V5IEI=; b=206L+5vmmo3KJcInxsempdJtTN6qyVFo6yJ8DKRXsTVNWmvpFp9ktQEEORSQdtjnGrJSNz XRfLvgMrJO4L/3a/+GAWeQ8O/ArtYVybcP8QTssQtSKDm/ereurR+UwAiHrHgoaLHl56pL GsNJnJ14ByhEGm0Pc7fAw4YDvKmY6zo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1631284370; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0gCvHaFoaErwZzq8spVYY8j7DbpH/CPgcbOQt2V5IEI=; b=uVEZhzEe10jU5Y+mVEQxR9X4LECC82HqwvpcR2ZpaUfWIHyOWH/gV+k6WFD6VfF1o1wbPS TQH4YKJAUsiBSoBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 3EE0413D38; Fri, 10 Sep 2021 14:32:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 9nFGDpJsO2ElbQAAMHmgww (envelope-from ); Fri, 10 Sep 2021 14:32:50 +0000 Date: Fri, 10 Sep 2021 16:33:06 +0200 From: Cyril Hrubis To: Martin Doucha Message-ID: References: <20210909155126.2720-1-mdoucha@suse.cz> <20210909155126.2720-4-mdoucha@suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210909155126.2720-4-mdoucha@suse.cz> X-Virus-Scanned: clamav-milter 0.102.4 at in-3.smtp.seeweb.it X-Virus-Status: Clean Subject: Re: [LTP] [PATCH 4/8] syscalls/setresgid02: Convert to new API X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ltp@lists.linux.it Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Message-ID: <20210910143306.Epow_mX5jyyqok4Dys7mtCQGGWRq9MG2ta0MJbZ2q-c@z> Hi! I've pushed patches up to this point, thanks. For the rest it has to be decided if we will use TST_EXP_FAIL() or not. I've also did a minor changes to this patch, see below. > +/*\ > + * [Description] > + * > + * Verify that setresgid() will successfully set the expected GID when called > + * by root with the following combinations of arguments: > + * 1. setresgid(-1, -1, -1) > + * 2. setresgid(-1, -1, other) > + * 3. setresgid(-1, other, -1) > + * 4. setresgid(other, -1, -1) > + * 5. setresgid(root, root, root) > + * 6. setresgid(root, main, main) > + */ I've reformatted this part so that it rendes as a list in the asciidoc syntax. > struct test_case_t { /* test case structure */ > - uid_t *rgid; /* real GID */ > - uid_t *egid; /* effective GID */ > - uid_t *sgid; /* saved GID */ > - struct passwd *exp_rgid; /* Expected real GID */ > - struct passwd *exp_egid; /* Expected effective GID */ > - struct passwd *exp_sgid; /* Expected saved GID */ > + gid_t *rgid; /* real GID */ > + gid_t *egid; /* effective GID */ > + gid_t *sgid; /* saved GID */ > + gid_t *exp_rgid; /* Expected real GID */ > + gid_t *exp_egid; /* Expected effective GID */ > + gid_t *exp_sgid; /* Expected saved GID */ > char *desc; /* Test description */ > }; And also got rid of these useless comments, that were commenting the obvious. -- Cyril Hrubis chrubis@suse.cz -- Mailing list info: https://lists.linux.it/listinfo/ltp