From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61F0AC4332F for ; Fri, 24 Sep 2021 08:20:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43A0761090 for ; Fri, 24 Sep 2021 08:20:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244685AbhIXIVU (ORCPT ); Fri, 24 Sep 2021 04:21:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:35862 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244581AbhIXIVI (ORCPT ); Fri, 24 Sep 2021 04:21:08 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 5F9C361090; Fri, 24 Sep 2021 08:19:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1632471575; bh=j+vSA3Y0V/smgE9MwWDNyABdIKkpb0NSjB17vddCwKU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2ZEWM4dnakVSJI5Vad6T84jyZU3UbXt94wc5Q0qpTBoom46kKft2cb4t2h03yAqOr qSmsxNQ+4zOx+ucfIkzD7AfzDfIf+c6NkR396zqqKO1JC87J/hOg1hOPKf6LuG6rEa jeePjimb6egKcfQMJC3SE/entj7CjGJ8xmYLYhcs= Date: Fri, 24 Sep 2021 10:19:33 +0200 From: Greg Kroah-Hartman To: Zhiwei Yang Cc: Felipe Balbi , linux-usb@vger.kernel.org Subject: Re: [PATCH] USB: phy: tahvo:replace "%p" with "%pK" Message-ID: References: <20210924075913.31584-1-yangzhiwei@uniontech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210924075913.31584-1-yangzhiwei@uniontech.com> Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Fri, Sep 24, 2021 at 03:59:13PM +0800, Zhiwei Yang wrote: > Use "%pK" to avoid kernel address leaked > > Signed-off-by: Zhiwei Yang > --- > drivers/usb/phy/phy-tahvo.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c > index baebb1f5a973..5dc600fadc5f 100644 > --- a/drivers/usb/phy/phy-tahvo.c > +++ b/drivers/usb/phy/phy-tahvo.c > @@ -194,7 +194,7 @@ static int tahvo_usb_set_host(struct usb_otg *otg, struct usb_bus *host) > struct tahvo_usb *tu = container_of(otg->usb_phy, struct tahvo_usb, > phy); > > - dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, host); > + dev_dbg(&tu->pt_dev->dev, "%s %pK\n", __func__, host); > > mutex_lock(&tu->serialize); > > @@ -224,7 +224,7 @@ static int tahvo_usb_set_peripheral(struct usb_otg *otg, > struct tahvo_usb *tu = container_of(otg->usb_phy, struct tahvo_usb, > phy); > > - dev_dbg(&tu->pt_dev->dev, "%s %p\n", __func__, gadget); > + dev_dbg(&tu->pt_dev->dev, "%s %pK\n", __func__, gadget); > > mutex_lock(&tu->serialize); > > -- > 2.20.1 > > > Both of these lines should just be removed as ftrace can be (and should be) used instead for stuff like "did the kernel get to this function?" that these lines seem to be for. So can you just resubmit this as removing those lines? thanks, greg k-h