From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B026C433EF for ; Fri, 24 Sep 2021 15:36:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A9EF60EE9 for ; Fri, 24 Sep 2021 15:36:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4A9EF60EE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9A50A88DA9; Fri, 24 Sep 2021 15:36:04 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4842188DA9; Fri, 24 Sep 2021 15:36:03 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10116"; a="224143568" X-IronPort-AV: E=Sophos;i="5.85,320,1624345200"; d="scan'208";a="224143568" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2021 08:36:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,320,1624345200"; d="scan'208";a="559665040" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by fmsmga002.fm.intel.com with SMTP; 24 Sep 2021 08:35:59 -0700 Received: by stinkbox (sSMTP sendmail emulation); Fri, 24 Sep 2021 18:35:58 +0300 Date: Fri, 24 Sep 2021 18:35:58 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Matthew Auld Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Matthew Brost Message-ID: References: <20210924144646.4096402-1-matthew.auld@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210924144646.4096402-1-matthew.auld@intel.com> X-Patchwork-Hint: comment Subject: Re: [Intel-gfx] [PATCH] drm/i915: remember to call i915_sw_fence_fini X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Fri, Sep 24, 2021 at 03:46:46PM +0100, Matthew Auld wrote: > Seems to fix some object-debug splat which appeared while debugging > something unrelated. > > v2: s/guc_blocked/guc_state.blocked/ > > Signed-off-by: Matthew Auld > Cc: Ville Syrjälä > Cc: Matthew Brost Seems to help. Tested-by: Ville Syrjälä Bonus points if someone can figure out how this getting past CI in its current state. I can trigger it very easily by pretty much running any igt. Though for some reason it doesn't always trigger on the first run of an igt after boot, sometimes takes a few runs. Dunno if the checks are a bit lazy or something. > --- > drivers/gpu/drm/i915/gt/intel_context.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/gt/intel_context.c b/drivers/gpu/drm/i915/gt/intel_context.c > index ff637147b1a9..e9a0cad5c34d 100644 > --- a/drivers/gpu/drm/i915/gt/intel_context.c > +++ b/drivers/gpu/drm/i915/gt/intel_context.c > @@ -419,6 +419,7 @@ void intel_context_fini(struct intel_context *ce) > > mutex_destroy(&ce->pin_mutex); > i915_active_fini(&ce->active); > + i915_sw_fence_fini(&ce->guc_state.blocked); > } > > void i915_context_module_exit(void) > -- > 2.26.3 -- Ville Syrjälä Intel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E5FAC433EF for ; Fri, 24 Sep 2021 15:36:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D827861107 for ; Fri, 24 Sep 2021 15:36:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D827861107 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F0BD089147; Fri, 24 Sep 2021 15:36:04 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4842188DA9; Fri, 24 Sep 2021 15:36:03 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10116"; a="224143568" X-IronPort-AV: E=Sophos;i="5.85,320,1624345200"; d="scan'208";a="224143568" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Sep 2021 08:36:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,320,1624345200"; d="scan'208";a="559665040" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.171]) by fmsmga002.fm.intel.com with SMTP; 24 Sep 2021 08:35:59 -0700 Received: by stinkbox (sSMTP sendmail emulation); Fri, 24 Sep 2021 18:35:58 +0300 Date: Fri, 24 Sep 2021 18:35:58 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Matthew Auld Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Matthew Brost Subject: Re: [PATCH] drm/i915: remember to call i915_sw_fence_fini Message-ID: References: <20210924144646.4096402-1-matthew.auld@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210924144646.4096402-1-matthew.auld@intel.com> X-Patchwork-Hint: comment X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Sep 24, 2021 at 03:46:46PM +0100, Matthew Auld wrote: > Seems to fix some object-debug splat which appeared while debugging > something unrelated. > > v2: s/guc_blocked/guc_state.blocked/ > > Signed-off-by: Matthew Auld > Cc: Ville Syrjälä > Cc: Matthew Brost Seems to help. Tested-by: Ville Syrjälä Bonus points if someone can figure out how this getting past CI in its current state. I can trigger it very easily by pretty much running any igt. Though for some reason it doesn't always trigger on the first run of an igt after boot, sometimes takes a few runs. Dunno if the checks are a bit lazy or something. > --- > drivers/gpu/drm/i915/gt/intel_context.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/i915/gt/intel_context.c b/drivers/gpu/drm/i915/gt/intel_context.c > index ff637147b1a9..e9a0cad5c34d 100644 > --- a/drivers/gpu/drm/i915/gt/intel_context.c > +++ b/drivers/gpu/drm/i915/gt/intel_context.c > @@ -419,6 +419,7 @@ void intel_context_fini(struct intel_context *ce) > > mutex_destroy(&ce->pin_mutex); > i915_active_fini(&ce->active); > + i915_sw_fence_fini(&ce->guc_state.blocked); > } > > void i915_context_module_exit(void) > -- > 2.26.3 -- Ville Syrjälä Intel