From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Xu Wang <vulab@iscas.ac.cn>
Cc: <Damien.LeMoal@wdc.com>, <konrad.wilk@oracle.com>,
<axboe@kernel.dk>, <xen-devel@lists.xenproject.org>,
<linux-block@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] xen-blkback: Remove needless request_queue NULL pointer check
Date: Tue, 14 Sep 2021 09:58:46 +0200 [thread overview]
Message-ID: <YUBWNkD3lECHrhAp@MacBook-Air-de-Roger.local> (raw)
In-Reply-To: <20210910035918.24907-1-vulab@iscas.ac.cn>
On Fri, Sep 10, 2021 at 03:59:18AM +0000, Xu Wang wrote:
> The request_queue pointer returned from bdev_get_queue() shall
> never be NULL, so the null check is unnecessary, just remove it.
There are other places in the code where the return of bdev_get_queue
is checked to not be NULL, like __blkdev_issue_discard. Should those
also be changed?
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Regards, Roger.
prev parent reply other threads:[~2021-09-14 8:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-10 3:59 [PATCH v2] xen-blkback: Remove needless request_queue NULL pointer check Xu Wang
2021-09-14 7:58 ` Roger Pau Monné [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUBWNkD3lECHrhAp@MacBook-Air-de-Roger.local \
--to=roger.pau@citrix.com \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=konrad.wilk@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.