From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D8B7C433EF for ; Tue, 14 Sep 2021 15:09:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA6E8610A6 for ; Tue, 14 Sep 2021 15:09:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EA6E8610A6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jRGHdRilxu290BlRfBHMiIoOKQ8h8Cma2VEYI/itrnw=; b=bmJ4RpQRazI9xy CFGlqEJCAHaJEf9CIy2sx/3JPnK8FNQ7nJe96CIoBlRxtkz/Y7/0L/GBdntLZE4ar0/AS/CvydPyu b8v4g7ZiC2D0brp/wcRYJu7GD0TSycDSZeTk2eiML++uU+QF+bYEcefcyUD4He7M4YiqOTX/xRRvs Ro0HSUnrjJCcDm/f7svcDy50u6sAecCWJxYPPmId9A9UVkhWFZygrkhS60QHcDCzFusMHYUc+xrzI oconSdaS0Go490D8i3D5GtsWvuayxbq+CyMYNXh3vWhRgCAmX0uTApcNd5+Hv2SuwAtsuyaC6kJp3 yW4LPHBc2jtW845o5HMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQA1w-0068e6-Jd; Tue, 14 Sep 2021 15:07:28 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQA1U-0068Wj-Hn for linux-arm-kernel@lists.infradead.org; Tue, 14 Sep 2021 15:07:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3zXpFvWRnaMxxy1LOJuYLJV7+e+aR8hTQQKhDCrOJh8=; b=tjO3A+YKEZcwwYhJu78vyphei3 vLHFE1CD1HG7orcfsQnKFrPMEaE2gc8e3HFjdHiKXcjLm//WagkQfzzPkl3UCaMnHJxsMSwNaboe9 eTDoIoeeFJIBuvUuVxPtr78QMvvglaVPQ/m9R069Mn66q1q31jBoWyJNPZaP71w463NghC7e3U4T8 I/U3U+mTjVUR4wGMP2prKIlWyYSH7gX/j8SvyVl5jbIoBe5tbz5iIqvPwQkzV38nlWTrbzpaYjo7A QomxA6xOmwMyo4Y32s7bZGRJjtLgORBPY6fob+nqFJM/gbi0AJGjjk1j+i2ZknYTYMO/nGxdxmigb edpCPjSA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:45096) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mQA1Q-000500-Fn; Tue, 14 Sep 2021 16:06:55 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1mQA1N-00035c-Se; Tue, 14 Sep 2021 16:06:53 +0100 Date: Tue, 14 Sep 2021 16:06:53 +0100 From: "Russell King (Oracle)" To: Fabio Estevam Cc: shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org, o.rempel@pengutronix.de, andrew@lunn.ch, john.weber@technexion.com Subject: Re: [PATCH] ARM: dts: Fix Ethernet support Message-ID: References: <20210914144946.2010617-1-festevam@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210914144946.2010617-1-festevam@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210914_080700_775428_0D09C56A X-CRM114-Status: GOOD ( 19.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 14, 2021 at 11:49:46AM -0300, Fabio Estevam wrote: > Currently, it is no longer possible to retrieve a DHCP address > on the imx6qdl-pico board. > > This issue has been exposed by commit f5d9aa79dfdf ("ARM: imx6q: > remove clk-out fixup for the Atheros AR8031 and AR8035 PHYs"). > > Fix it by describing the qca,clk-out-frequency property as suggested > by the commit above. > > Fixes: 98670a0bb0ef14bbb3 ("ARM: dts: imx6qdl: Add imx6qdl-pico support") > Signed-off-by: Fabio Estevam > --- > arch/arm/boot/dts/imx6qdl-pico.dtsi | 13 ++++++++++++- > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx6qdl-pico.dtsi b/arch/arm/boot/dts/imx6qdl-pico.dtsi > index 5de4ccb97916..0a55e1e583ae 100644 > --- a/arch/arm/boot/dts/imx6qdl-pico.dtsi > +++ b/arch/arm/boot/dts/imx6qdl-pico.dtsi > @@ -175,8 +175,19 @@ &fec { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_enet>; > phy-mode = "rgmii-id"; > - phy-reset-gpios = <&gpio1 26 GPIO_ACTIVE_LOW>; > status = "okay"; > + > + mdio { > + #address-cells = <1>; > + #size-cells = <0>; > + > + phy: ethernet-phy@1 { > + reg = <1>; > + qca,clk-out-frequency = <125000000>; > + reset-gpios = <&gpio1 26 GPIO_ACTIVE_LOW>; > + reset-assert-us = <10000>; > + }; > + }; > }; > > &hdmi { Do you really want to move the reset properties? Have you tested kexec? Moving the reset into the phy node without a compatible risks not being able to read the PHY ID and not being able to detect the presence of the PHY. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel