From: Alexey Dobriyan <adobriyan@gmail.com>
To: tiwai@suse.de
Cc: alsa-devel@alsa-project.org
Subject: [PATCH] pcxhr: "fix" PCXHR_REG_TO_PORT definition
Date: Tue, 14 Sep 2021 14:08:47 +0300 [thread overview]
Message-ID: <YUCCv47sm4zf9OVO@localhost.localdomain> (raw)
The following preprocessor directive is non-compliant:
#undef PCXHR_REG_TO_PORT(x)
gcc warns about extra tokens but nobody sees them as they are under if
branch which is never parsed.
Make it an #error, it is not clear to me what the author meant.
Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---
sound/pci/pcxhr/pcxhr_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/sound/pci/pcxhr/pcxhr_core.c
+++ b/sound/pci/pcxhr/pcxhr_core.c
@@ -52,7 +52,7 @@
#define PCXHR_DSP 2
#if (PCXHR_DSP_OFFSET_MAX > PCXHR_PLX_OFFSET_MIN)
-#undef PCXHR_REG_TO_PORT(x)
+#error PCXHR_REG_TO_PORT(x)
#else
#define PCXHR_REG_TO_PORT(x) ((x)>PCXHR_DSP_OFFSET_MAX ? PCXHR_PLX : PCXHR_DSP)
#endif
next reply other threads:[~2021-09-14 11:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-14 11:08 Alexey Dobriyan [this message]
2021-09-16 9:09 ` [PATCH] pcxhr: "fix" PCXHR_REG_TO_PORT definition Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUCCv47sm4zf9OVO@localhost.localdomain \
--to=adobriyan@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.