From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0EECC433EF for ; Tue, 14 Sep 2021 16:02:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C89360EE5 for ; Tue, 14 Sep 2021 16:02:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9C89360EE5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fvR14h+8SAs2UlyfILbS1zBQJw2Lrm9CaZiwajVIiO0=; b=o4LVdEoaqACeFZ YgDSUrV/e17BFTaHbGfjTY8pNXndGRkB4SJ2RAQLcgwOdz9XpG2ceXuwIGH95iOeCpfZ3Pj8DwMe0 QyJVI8LcmdM58wzjichsF4DGHG4pEbH2r3CRj+T96RlrAyC2GTMTaGVcdeCRhjRK08U3OThx6EHve 9UpSHqOrO+CPW0dsHVQSEDS2YRXhWZyhoeLyx1os6nURq6uNpbdkoizQD1Y5KViuMgVC/82OsVS9C 5bxqrKSSVx2c05EmiIQKOMbX7cya6NYWrlk5cwZqVD9BQweS9aM4p2zQxeV1QHwhgb+c5KZcq77r/ /mdE9CPFz1j7eqDc0TWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQAr8-006Ld1-IU; Tue, 14 Sep 2021 16:00:23 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mQAqT-006LIO-Gf for linux-arm-kernel@lists.infradead.org; Tue, 14 Sep 2021 15:59:42 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=yP9sqpmeviA1gb8gdGm9Zr+sde7rymb2vu5e6GQu/qg=; b=DDxkZfiV6LZzhfKWyqCXV3BhOw QQgPt6wYz+nyhuYoBzaMdZICvs/MIrii8ETTiOfOOCa4wqAbXpitBrFSsmOgFusg/DHNyn8CqEhYg PXARVojjKYadX+59MKV9KVTZMnAcLKo43wQQXWIzbEHdYDF4BBEJ6FDrtr+TZ8tgN2O8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mQAqN-006cRo-UL; Tue, 14 Sep 2021 17:59:35 +0200 Date: Tue, 14 Sep 2021 17:59:35 +0200 From: Andrew Lunn To: Daniel Palmer Cc: devicetree@vger.kernel.org, robh+dt@kernel.org, maz@kernel.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, romain.perier@gmail.com Subject: Re: [PATCH 0/3] SigmaStar SSD20XD GPIO interrupt controller Message-ID: References: <20210914100415.1549208-1-daniel@0x0f.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210914100415.1549208-1-daniel@0x0f.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210914_085941_630731_87CC2C30 X-CRM114-Status: GOOD ( 13.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 14, 2021 at 07:04:12PM +0900, Daniel Palmer wrote: > In new SigmaStar SoCs they have moved away from having a few > interrupt capable GPIOs and instead have chained yet another > interrupt controller in to provide interrupt support for > all of the GPIOs. > > I'm hardly an IRQ expert so I expect I've made a total > mess of this. No one else was going to write this driver > so I had a go. Hi Daniel How are the GPIOs mapped to the interrupts? Is it a simple 1:1? The GPIO core has some support for the GPIO drivers to be also interrupt controllers. So if this interrupt control is dedicated to GPIO, you would be better to make it part of the GPIO driver. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DCD3C433EF for ; Tue, 14 Sep 2021 15:59:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3546361155 for ; Tue, 14 Sep 2021 15:59:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235048AbhINQAz (ORCPT ); Tue, 14 Sep 2021 12:00:55 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:40944 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235098AbhINQAz (ORCPT ); Tue, 14 Sep 2021 12:00:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=yP9sqpmeviA1gb8gdGm9Zr+sde7rymb2vu5e6GQu/qg=; b=DDxkZfiV6LZzhfKWyqCXV3BhOw QQgPt6wYz+nyhuYoBzaMdZICvs/MIrii8ETTiOfOOCa4wqAbXpitBrFSsmOgFusg/DHNyn8CqEhYg PXARVojjKYadX+59MKV9KVTZMnAcLKo43wQQXWIzbEHdYDF4BBEJ6FDrtr+TZ8tgN2O8=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1mQAqN-006cRo-UL; Tue, 14 Sep 2021 17:59:35 +0200 Date: Tue, 14 Sep 2021 17:59:35 +0200 From: Andrew Lunn To: Daniel Palmer Cc: devicetree@vger.kernel.org, robh+dt@kernel.org, maz@kernel.org, tglx@linutronix.de, linux-arm-kernel@lists.infradead.org, romain.perier@gmail.com Subject: Re: [PATCH 0/3] SigmaStar SSD20XD GPIO interrupt controller Message-ID: References: <20210914100415.1549208-1-daniel@0x0f.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210914100415.1549208-1-daniel@0x0f.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Sep 14, 2021 at 07:04:12PM +0900, Daniel Palmer wrote: > In new SigmaStar SoCs they have moved away from having a few > interrupt capable GPIOs and instead have chained yet another > interrupt controller in to provide interrupt support for > all of the GPIOs. > > I'm hardly an IRQ expert so I expect I've made a total > mess of this. No one else was going to write this driver > so I had a go. Hi Daniel How are the GPIOs mapped to the interrupts? Is it a simple 1:1? The GPIO core has some support for the GPIO drivers to be also interrupt controllers. So if this interrupt control is dedicated to GPIO, you would be better to make it part of the GPIO driver. Andrew