All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
	martin.botka@somainline.org,
	angelogioacchino.delregno@somainline.org,
	marijn.suijten@somainline.org, jamipkettunen@somainline.org,
	Rob Herring <robh@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Sebastian Reichel <sre@kernel.org>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Hector Martin <marcan@marcan.st>, Vinod Koul <vkoul@kernel.org>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Andy Gross <agross@kernel.org>,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 16/18] arm64: dts: qcom: sm6350: Add iommus property to USB1
Date: Tue, 14 Sep 2021 11:14:30 -0500	[thread overview]
Message-ID: <YUDKZh5bEiXUspFV@builder.lan> (raw)
In-Reply-To: <20210828131814.29589-16-konrad.dybcio@somainline.org>

On Sat 28 Aug 08:18 CDT 2021, Konrad Dybcio wrote:

> This is required for us to be able to access the associated registers, which
> are (on at least some devices) gated by default.
> 

Please either merge this with the patch that introduces the SMMU (which
I presume causes this "issue") or introduce the SMMU earlier in the
series.

Regards,
Bjorn

> Signed-off-by: Konrad Dybcio <konrad.dybcio@somainline.org>
> ---
>  arch/arm64/boot/dts/qcom/sm6350.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm6350.dtsi b/arch/arm64/boot/dts/qcom/sm6350.dtsi
> index a3a1f0e63ace..95e69d9f8657 100644
> --- a/arch/arm64/boot/dts/qcom/sm6350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6350.dtsi
> @@ -584,6 +584,7 @@ usb_1_dwc3: dwc3@a600000 {
>  				compatible = "snps,dwc3";
>  				reg = <0 0x0a600000 0 0xcd00>;
>  				interrupts = <GIC_SPI 133 IRQ_TYPE_LEVEL_HIGH>;
> +				iommus = <&apps_smmu 0x540 0x0>;
>  				snps,dis_u2_susphy_quirk;
>  				snps,dis_enblslpm_quirk;
>  				snps,has-lpm-erratum;
> -- 
> 2.33.0
> 

  reply	other threads:[~2021-09-14 16:14 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-28 13:17 [PATCH v2 01/18] dt-bindings: arm: cpus: Add Kryo 560 CPUs Konrad Dybcio
2021-08-28 13:17 ` [PATCH v2 02/18] arm64: dts: qcom: Add SM6350 device tree Konrad Dybcio
2021-08-28 15:55   ` Maulik Shah
2021-08-28 16:22     ` Konrad Dybcio
2021-08-28 19:43       ` Maulik Shah
2021-08-28 13:17 ` [PATCH v2 03/18] arm64: dts: qcom: sm6350: Add LLCC node Konrad Dybcio
2021-08-28 13:17 ` [PATCH v2 04/18] arm64: dts: qcom: sm6350: Add RPMHCC node Konrad Dybcio
2021-08-28 13:18 ` [PATCH v2 05/18] arm64: dts: qcom: sm6350: Add GCC node Konrad Dybcio
2021-08-28 13:18 ` [PATCH v2 06/18] arm64: dts: qcom: sm6350: Add TLMM block node Konrad Dybcio
2021-08-28 15:47   ` Maulik Shah
2021-08-28 15:49     ` Konrad Dybcio
2021-08-28 13:18 ` [PATCH v2 07/18] arm64: dts: qcom: sm6350: Add USB1 nodes Konrad Dybcio
2021-08-28 13:18 ` [PATCH v2 08/18] arm64: dts: qcom: sm6350: Add cpufreq-hw support Konrad Dybcio
2021-08-28 13:18 ` [PATCH v2 09/18] arm64: dts: qcom: sm6350: Add TSENS nodes Konrad Dybcio
2021-08-28 13:18 ` [PATCH v2 10/18] arm64: dts: qcom: sm6350: Add AOSS_QMP Konrad Dybcio
2021-08-28 19:16   ` Maulik Shah
2021-08-28 13:18 ` [PATCH v2 11/18] arm64: dts: qcom: sm6350: Add SPMI bus Konrad Dybcio
2021-08-28 13:18 ` [PATCH v2 12/18] arm64: dts: qcom: sm6350: Add PRNG node Konrad Dybcio
2021-08-28 13:18 ` [PATCH v2 13/18] arm64: dts: qcom: sm6350: Add RPMHPD and BCM voter Konrad Dybcio
2021-08-28 13:18 ` [PATCH v2 14/18] arm64: dts: qcom: sm6350: Add SDHCI1/2 nodes Konrad Dybcio
2021-08-28 13:18 ` [PATCH v2 15/18] arm64: dts: qcom: sm6350: Add apps_smmu Konrad Dybcio
2021-08-28 13:18 ` [PATCH v2 16/18] arm64: dts: qcom: sm6350: Add iommus property to USB1 Konrad Dybcio
2021-09-14 16:14   ` Bjorn Andersson [this message]
2021-08-28 13:18 ` [PATCH v2 17/18] arm64: dts: qcom: Add device tree for Sony Xperia 10 III Konrad Dybcio
2021-09-14 16:19   ` Bjorn Andersson
2021-08-28 13:18 ` [PATCH v2 18/18] arm64: dts: qcom: pm6150l: Add missing include Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YUDKZh5bEiXUspFV@builder.lan \
    --to=bjorn.andersson@linaro.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=agross@kernel.org \
    --cc=angelogioacchino.delregno@somainline.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jamipkettunen@somainline.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=marcan@marcan.st \
    --cc=marijn.suijten@somainline.org \
    --cc=martin.botka@somainline.org \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=sre@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=viresh.kumar@linaro.org \
    --cc=vkoul@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.