From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mQm4B-0001iu-G9 for mharc-qemu-trivial@gnu.org; Thu, 16 Sep 2021 03:44:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36754) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQm4A-0001i0-3M for qemu-trivial@nongnu.org; Thu, 16 Sep 2021 03:44:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:41504) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQm46-0005Nq-EV for qemu-trivial@nongnu.org; Thu, 16 Sep 2021 03:44:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631778253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wn+nhpg2TTS5xbETIvwCun9JyvZlQMDRvn6pXiV0kds=; b=X4ANH6LYfiNCuZF6YJd+zfTtiMl1S0QazO5EJlLu8iigccZaOsYRS7dH//Dg/ZAEZOgCwJ hf6JlWau+XjUKJlI+U7Cabq6g5wxH7q7xGEjTcYW6eMBfb9z4b6Csgk6U296jugYugias7 9fp0XUzvErUAselDylNsSH32+vuVu4E= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-100-6PCD7awVM86kLXRSs9BmTw-1; Thu, 16 Sep 2021 03:44:11 -0400 X-MC-Unique: 6PCD7awVM86kLXRSs9BmTw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AB5798E3C1F; Thu, 16 Sep 2021 07:43:30 +0000 (UTC) Received: from redhat.com (unknown [10.39.194.102]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0DD5226E51; Thu, 16 Sep 2021 07:43:28 +0000 (UTC) Date: Thu, 16 Sep 2021 09:43:27 +0200 From: Kevin Wolf To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-devel@nongnu.org, QEMU Trivial , qemu-block@nongnu.org, Qing Wang Subject: Re: [PATCH] qemu-storage-daemon: Only display FUSE help when FUSE is built-in Message-ID: References: <20210816180442.2000642-1-philmd@redhat.com> <152eb50e-621f-cbac-4748-dc689aa08635@redhat.com> MIME-Version: 1.0 In-Reply-To: <152eb50e-621f-cbac-4748-dc689aa08635@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.39, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Sep 2021 07:44:18 -0000 Am 15.09.2021 um 23:36 hat Philippe Mathieu-Daudé geschrieben: > ping & Cc'ing qemu-trivial@ (reviewed twice) ... > > On 8/16/21 8:04 PM, Philippe Mathieu-Daudé wrote: > > When configuring QEMU with --disable-fuse, the qemu-storage-daemon > > still reports FUSE command line options in its help: > > > > $ qemu-storage-daemon -h > > Usage: qemu-storage-daemon [options] > > QEMU storage daemon > > > > --export [type=]fuse,id=,node-name=,mountpoint= > > [,growable=on|off][,writable=on|off] > > export the specified block node over FUSE > > > > Remove this help message when FUSE is disabled, to avoid: > > > > $ qemu-storage-daemon --export fuse > > qemu-storage-daemon: --export fuse: Invalid parameter 'fuse' > > > > Reported-by: Qing Wang > > Signed-off-by: Philippe Mathieu-Daudé Thanks, applied to the block branch. Kevin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FA8DC433F5 for ; Thu, 16 Sep 2021 07:45:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C96F960F6D for ; Thu, 16 Sep 2021 07:45:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C96F960F6D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:43156 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQm4p-0002V6-OT for qemu-devel@archiver.kernel.org; Thu, 16 Sep 2021 03:44:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36774) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQm4A-0001i1-21 for qemu-devel@nongnu.org; Thu, 16 Sep 2021 03:44:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:31688) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQm46-0005Nr-HI for qemu-devel@nongnu.org; Thu, 16 Sep 2021 03:44:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631778253; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wn+nhpg2TTS5xbETIvwCun9JyvZlQMDRvn6pXiV0kds=; b=X4ANH6LYfiNCuZF6YJd+zfTtiMl1S0QazO5EJlLu8iigccZaOsYRS7dH//Dg/ZAEZOgCwJ hf6JlWau+XjUKJlI+U7Cabq6g5wxH7q7xGEjTcYW6eMBfb9z4b6Csgk6U296jugYugias7 9fp0XUzvErUAselDylNsSH32+vuVu4E= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-100-6PCD7awVM86kLXRSs9BmTw-1; Thu, 16 Sep 2021 03:44:11 -0400 X-MC-Unique: 6PCD7awVM86kLXRSs9BmTw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id AB5798E3C1F; Thu, 16 Sep 2021 07:43:30 +0000 (UTC) Received: from redhat.com (unknown [10.39.194.102]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0DD5226E51; Thu, 16 Sep 2021 07:43:28 +0000 (UTC) Date: Thu, 16 Sep 2021 09:43:27 +0200 From: Kevin Wolf To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Subject: Re: [PATCH] qemu-storage-daemon: Only display FUSE help when FUSE is built-in Message-ID: References: <20210816180442.2000642-1-philmd@redhat.com> <152eb50e-621f-cbac-4748-dc689aa08635@redhat.com> MIME-Version: 1.0 In-Reply-To: <152eb50e-621f-cbac-4748-dc689aa08635@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kwolf@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.39, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: QEMU Trivial , Qing Wang , qemu-devel@nongnu.org, qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 15.09.2021 um 23:36 hat Philippe Mathieu-Daudé geschrieben: > ping & Cc'ing qemu-trivial@ (reviewed twice) ... > > On 8/16/21 8:04 PM, Philippe Mathieu-Daudé wrote: > > When configuring QEMU with --disable-fuse, the qemu-storage-daemon > > still reports FUSE command line options in its help: > > > > $ qemu-storage-daemon -h > > Usage: qemu-storage-daemon [options] > > QEMU storage daemon > > > > --export [type=]fuse,id=,node-name=,mountpoint= > > [,growable=on|off][,writable=on|off] > > export the specified block node over FUSE > > > > Remove this help message when FUSE is disabled, to avoid: > > > > $ qemu-storage-daemon --export fuse > > qemu-storage-daemon: --export fuse: Invalid parameter 'fuse' > > > > Reported-by: Qing Wang > > Signed-off-by: Philippe Mathieu-Daudé Thanks, applied to the block branch. Kevin