From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D864C433EF for ; Thu, 16 Sep 2021 10:30:14 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CEBF361108 for ; Thu, 16 Sep 2021 10:30:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CEBF361108 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=alien8.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.188332.337460 (Exim 4.92) (envelope-from ) id 1mQoeS-0005f5-J4; Thu, 16 Sep 2021 10:29:56 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 188332.337460; Thu, 16 Sep 2021 10:29:56 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mQoeS-0005ey-GB; Thu, 16 Sep 2021 10:29:56 +0000 Received: by outflank-mailman (input) for mailman id 188332; Thu, 16 Sep 2021 10:29:55 +0000 Received: from us1-rack-iad1.inumbo.com ([172.99.69.81]) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1mQoeR-0005el-5U for xen-devel@lists.xenproject.org; Thu, 16 Sep 2021 10:29:55 +0000 Received: from mail.skyhub.de (unknown [5.9.137.197]) by us1-rack-iad1.inumbo.com (Halon) with ESMTPS id 1d14273e-8dc6-4da1-a940-28d85bde6683; Thu, 16 Sep 2021 10:29:53 +0000 (UTC) Received: from zn.tnic (p200300ec2f11c600b77f9e345fbfb487.dip0.t-ipconnect.de [IPv6:2003:ec:2f11:c600:b77f:9e34:5fbf:b487]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 1E3DB1EC01DF; Thu, 16 Sep 2021 12:29:48 +0200 (CEST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 1d14273e-8dc6-4da1-a940-28d85bde6683 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1631788188; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=EXpt8wshiO7ImZN+Zx5zekJn4i6gD7QW4fNVEzzyMB0=; b=jdKCZeacNO/kKHUWytZdn5Fjo98CAZEQp+DgI7I37Kq2atS39x82DLxp+PzrfJ6w/OMpOx 2kRvyfMEU9NGc0BdDMyQFTyKr41mebgtFFj1rEwSkta4odAJx3N6y0DSrQaVrO5hfk6wCD w9bRZIOCbxUdY5+wJ29B3EVPzm2K9/U= Date: Thu, 16 Sep 2021 12:29:41 +0200 From: Borislav Petkov To: Mike Rapoport Cc: Juergen Gross , Jan Beulich , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= , xen-devel@lists.xenproject.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/setup: call early_reserve_memory() earlier Message-ID: References: <20210914094108.22482-1-jgross@suse.com> <6cdc71dc-c26d-5c59-b7dd-0eb47ab9c861@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Thu, Sep 16, 2021 at 12:09:27PM +0300, Mike Rapoport wrote: > I think the first sentence about reserving memory before memblock > allocations are possible is important and I think we should keep it. I expanded that comment this way: /* * Do some memory reservations *before* memory is added to memblock, so * memblock allocations won't overwrite it. * * After this point, everything still needed from the boot loader or * firmware or kernel text should be early reserved or marked not RAM in * e820. All other memory is free game. * * This call needs to happen before e820__memory_setup() which calls the * xen_memory_setup() on Xen dom0 which relies on the fact that those * early reservations have happened already. */ -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette