From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD72572 for ; Sat, 18 Sep 2021 06:53:35 +0000 (UTC) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id CA0B45C00A6; Sat, 18 Sep 2021 02:53:34 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sat, 18 Sep 2021 02:53:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=OHpUYmcaiCXOKK/cbi97jbouzAU O2aCwXqN74T/WwtI=; b=flOMp1lFJhm059m05SWMNqLW1PlhxvLCeNvZFvSmtE8 Bi792k1KG5ZJ7g0ERIjrJA83oF9m1zMpULIbAVa0ZVmheHNgfMRPoyslqCgchXy8 hnW1tYWeBgacKgX907rI6rUzT8Adgdmo6jLqJ0FUyP2lpQPqg1xLykqK+iF3lFyn 0UNVRm1/Ygb5dKwF3HKAAI7WD0Yqp0MqCmJXdYrjoKICjI1I0vUGmmNgPuQnoB/V 69KF/CIwW6b2g0eE3BywwyPiJ02lTIOQAjKHiryWGt6VaXw/2nfrm25J/6b1r6Bi 2Vx+Vp0A6GMuvm+y+0s8HJxcoKoeaeLSUY6Xp4Na8jw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=OHpUYm caiCXOKK/cbi97jbouzAUO2aCwXqN74T/WwtI=; b=tT7BLRbi9onljWBCMvszy3 prOSCPZQyx0+b9UHP2t1SdZ0G8PTKesFGmFsISuPKD3wA1y3WcrgZQkbwqXHZ3s+ D59w0BxGglOMbfvA/5sOXUjKvizlzpCcwvd6rSObZJPEwQNvmSgiETGINfWw7KE/ wjJZmjqU+FGI1BuAkc/gIQEwIOrPBQviL23qlgvN2blRYvBL2hxZ+vfuYcIuQiSS P34FO1XY6X5bmauuSfK3T25c9NN7D8w4uNrL3Xd4CrRYT1ZauTUURca/ygnauF1c PgesaDB0/oyCjJIEtTFTSVXOGmuzPFSk5iMNEHouSalXHMprI8rWbK7CiXw2vCUA == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudehjedgudduudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjsehttd ertddttddvnecuhfhrohhmpefirhgvghcumffjuceoghhrvghgsehkrhhorghhrdgtohhm qeenucggtffrrghtthgvrhhnpeevueehjefgfffgiedvudekvdektdelleelgefhleejie eugeegveeuuddukedvteenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgr ihhlfhhrohhmpehgrhgvgheskhhrohgrhhdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 18 Sep 2021 02:53:33 -0400 (EDT) Date: Sat, 18 Sep 2021 08:53:15 +0200 From: Greg KH To: ua1422@gmail.com Cc: linux-staging@lists.linux.dev Subject: Re: [PATCH] Staging: wlan-ng: Fix warning messages generated by checkpatch.pl Message-ID: References: <20210917182542.52733-1-ua1422@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210917182542.52733-1-ua1422@gmail.com> On Fri, Sep 17, 2021 at 11:25:42AM -0700, ua1422@gmail.com wrote: > From: Usman Ansari > > Signed-off-by: Usman Ansari > Description: Address the following checkpatch warning: > > WARNING: Commit log lines starting with '#' are dropped by git as comments > --- > drivers/staging/wlan-ng/cfg80211.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/wlan-ng/cfg80211.c b/drivers/staging/wlan-ng/cfg80211.c > index 7951bd63816f..f03dc1e59db1 100644 > --- a/drivers/staging/wlan-ng/cfg80211.c > +++ b/drivers/staging/wlan-ng/cfg80211.c > @@ -1,7 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 > /* cfg80211 Interface for prism2_usb module */ > -#include "hfa384x.h" > -#include "prism2mgmt.h" > + #include "hfa384x.h" > + #include "prism2mgmt.h" > > /* Prism2 channel/frequency/bitrate declarations */ > static const struct ieee80211_channel prism2_channels[] = { > @@ -28,7 +28,7 @@ static const struct ieee80211_rate prism2_rates[] = { > { .bitrate = 110 } > }; > > -#define PRISM2_NUM_CIPHER_SUITES 2 > + #define PRISM2_NUM_CIPHER_SUITES 2 > static const u32 prism2_cipher_suites[PRISM2_NUM_CIPHER_SUITES] = { > WLAN_CIPHER_SUITE_WEP40, > WLAN_CIPHER_SUITE_WEP104 > -- > 2.25.1 > Hi, This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him a patch that has triggered this response. He used to manually respond to these common problems, but in order to save his sanity (he kept writing the same thing over and over, yet to different people), I was created. Hopefully you will not take offence and will fix the problem in your patch and resubmit it so that it can be accepted into the Linux kernel tree. You are receiving this message because of the following common error(s) as indicated below: - Your patch does not have a Signed-off-by: line. Please read the kernel file, Documentation/SubmittingPatches and resend it after adding that line. Note, the line needs to be in the body of the email, before the patch, not at the bottom of the patch or in the email signature. - You did not specify a description of why the patch is needed, or possibly, any description at all, in the email body. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what is needed in order to properly describe the change. - You did not write a descriptive Subject: for the patch, allowing Greg, and everyone else, to know what this patch is all about. Please read the section entitled "The canonical patch format" in the kernel file, Documentation/SubmittingPatches for what a proper Subject: line should look like. If you wish to discuss this problem further, or you have questions about how to resolve this issue, please feel free to respond to this email and Greg will reply once he has dug out from the pending patches received from other developers. thanks, greg k-h's patch email bot