From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80A2C72 for ; Sun, 19 Sep 2021 06:38:37 +0000 (UTC) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 9F1EA320039A; Sun, 19 Sep 2021 02:38:36 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 19 Sep 2021 02:38:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=+iMtLpWBusMdRyq8TiDCF2XyQMC 8az/X7x3RmzlHJkQ=; b=lBlMvGAkYTDK50RYyVObzJH9csRap4eDr4F45Cnt8YY /YfXH/T7eH1mbfA5lMBCMo4Mm3b5c+Yjf79ynflKQrg7ZnsCGmY7bN1Wwor8MtxP jPZFPoWk6ecaGaoGQaYAo0B+mJGZRyfmiYygd7TOeDKWCPM0JYxAYd0x3XcXlfzw sdRsFy/gUtMC4MjDLuruoVnJvptB8yIKqI1N31QbVG6V6Oh6J9gI/7YThm+grYEF oLA1uMlANsPAivwdXL84Os7YSO113moz5n6R/b5I6fbD/ZDL6PZYRMuYKus1hWQA Hh2RC/FrlUxhFzTW/JxJufhfaleCgsuaLnN4uLI/SfQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=+iMtLp WBusMdRyq8TiDCF2XyQMC8az/X7x3RmzlHJkQ=; b=YcwTDWijIeN5O5kHpbf+jj dnhKuoRlQgKDmBTwYIP8Sqn56G2YpE+7tyXhlfJxsuaZ9klmxm8rsmrzwM7GfxGu +2fveInYDX2ecJDq4Y0zaSZnEtgdkB1jpTqg06uEKqjwIENrBX1hAydcB7j0tQ3K dm3IDO5Vng19WPsfnWIRcW+hlwhaAythqYOLTVJvnUJX/UaIeA+VqFWiRgEcCt9S B8WqlfPHsxjglmCjW6UvlN2MiFxOtQzxj20RSplYhURudg0d7wBOowlt+02/uucr 3l6lcC93Nw/AULlNuyMSIpvbtlBM6zJ4ChLZOltknejhlq+45NYc/ZVIhhjmYnPQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudehledguddtiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepveeuhe ejgfffgfeivddukedvkedtleelleeghfeljeeiueeggeevueduudekvdetnecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorg hhrdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 19 Sep 2021 02:38:34 -0400 (EDT) Date: Sun, 19 Sep 2021 08:38:16 +0200 From: Greg KH To: "Usman S. Ansari" Cc: linux-staging@lists.linux.dev Subject: Re: [PATCH] Staging: wlan-ng: Fix warning messages generated by checkpatch.pl Message-ID: References: <20210917182542.52733-1-ua1422@gmail.com> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, Sep 18, 2021 at 11:29:42AM -0700, Usman S. Ansari wrote: > On Fri, Sep 17, 2021 at 11:53 PM Greg KH wrote: > > > On Fri, Sep 17, 2021 at 11:25:42AM -0700, ua1422@gmail.com wrote: > > > From: Usman Ansari > > > > > > Signed-off-by: Usman Ansari > > > Description: Address the following checkpatch warning: > > > > > > WARNING: Commit log lines starting with '#' are dropped by git as > > comments > > > --- > > > drivers/staging/wlan-ng/cfg80211.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/staging/wlan-ng/cfg80211.c > > b/drivers/staging/wlan-ng/cfg80211.c > > > index 7951bd63816f..f03dc1e59db1 100644 > > > --- a/drivers/staging/wlan-ng/cfg80211.c > > > +++ b/drivers/staging/wlan-ng/cfg80211.c > > > @@ -1,7 +1,7 @@ > > > // SPDX-License-Identifier: GPL-2.0 > > > /* cfg80211 Interface for prism2_usb module */ > > > -#include "hfa384x.h" > > > -#include "prism2mgmt.h" > > > + #include "hfa384x.h" > > > + #include "prism2mgmt.h" > > > > > > /* Prism2 channel/frequency/bitrate declarations */ > > > static const struct ieee80211_channel prism2_channels[] = { > > > @@ -28,7 +28,7 @@ static const struct ieee80211_rate prism2_rates[] = { > > > { .bitrate = 110 } > > > }; > > > > > > -#define PRISM2_NUM_CIPHER_SUITES 2 > > > + #define PRISM2_NUM_CIPHER_SUITES 2 > > > static const u32 prism2_cipher_suites[PRISM2_NUM_CIPHER_SUITES] = { > > > WLAN_CIPHER_SUITE_WEP40, > > > WLAN_CIPHER_SUITE_WEP104 > > > -- > > > 2.25.1 > > > > > > > Hi, > > > > This is the friendly patch-bot of Greg Kroah-Hartman. You have sent him > > a patch that has triggered this response. He used to manually respond > > to these common problems, but in order to save his sanity (he kept > > writing the same thing over and over, yet to different people), I was > > created. Hopefully you will not take offence and will fix the problem > > in your patch and resubmit it so that it can be accepted into the Linux > > kernel tree. > > > > You are receiving this message because of the following common error(s) > > as indicated below: > > > > - Your patch does not have a Signed-off-by: line. Please read the > > kernel file, Documentation/SubmittingPatches and resend it after > > adding that line. Note, the line needs to be in the body of the > > email, before the patch, not at the bottom of the patch or in the > > email signature. > > > > - You did not specify a description of why the patch is needed, or > > possibly, any description at all, in the email body. Please read the > > section entitled "The canonical patch format" in the kernel file, > > Documentation/SubmittingPatches for what is needed in order to > > properly describe the change. > > > > - You did not write a descriptive Subject: for the patch, allowing Greg, > > and everyone else, to know what this patch is all about. Please read > > the section entitled "The canonical patch format" in the kernel file, > > Documentation/SubmittingPatches for what a proper Subject: line should > > look like. > > > > If you wish to discuss this problem further, or you have questions about > > how to resolve this issue, please feel free to respond to this email and > > Greg will reply once he has dug out from the pending patches received > > from other developers. > > > > thanks, > > > > greg k-h's patch email bot > > > > Hi Greg, > > I think I have covered all the items listed in your email bot reply. Please > let me know if the patch is not meeting the expectations. It is not, sorry. Please read the documentation. Also look at your patch itself, it is not correct. good luck! greg k-h