From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Matteo Croce <mcroce@linux.microsoft.com>
Cc: dwarves@vger.kernel.org
Subject: Re: [PATCH] CMakeList.txt: don't download libbpf source when system library is used
Date: Mon, 20 Sep 2021 18:16:00 -0300 [thread overview]
Message-ID: <YUj6EPoZ5VsxE1Dl@kernel.org> (raw)
In-Reply-To: <20210920164452.44529-1-mcroce@linux.microsoft.com>
Em Mon, Sep 20, 2021 at 06:44:52PM +0200, Matteo Croce escreveu:
> From: Matteo Croce <mcroce@microsoft.com>
>
> The build system always download the libbpf submodule, regardless if
> we're using the embedded or the system version.
> Download the libbpf source only if we're using the embedded one.
Thanks, applied.
- Arnaldo
> Signed-off-by: Matteo Croce <mcroce@microsoft.com>
> ---
> CMakeLists.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index 8523bce..2ab66e4 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -65,7 +65,7 @@ find_package(Python3 QUIET)
>
> # make sure git submodule(s) are checked out
> find_package(Git QUIET)
> -if(GIT_FOUND AND EXISTS "${PROJECT_SOURCE_DIR}/.git")
> +if(LIBBPF_EMBEDDED AND GIT_FOUND AND EXISTS "${PROJECT_SOURCE_DIR}/.git")
> # Update submodules as needed
> option(GIT_SUBMODULE "Check submodules during build" ON)
> if(GIT_SUBMODULE)
> --
> 2.31.1
--
- Arnaldo
prev parent reply other threads:[~2021-09-20 21:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 16:44 [PATCH] CMakeList.txt: don't download libbpf source when system library is used Matteo Croce
2021-09-20 21:16 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUj6EPoZ5VsxE1Dl@kernel.org \
--to=acme@kernel.org \
--cc=dwarves@vger.kernel.org \
--cc=mcroce@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.