From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf daemon: Avoid msan warnings on send_cmd
Date: Tue, 21 Sep 2021 16:25:58 -0300 [thread overview]
Message-ID: <YUoxxkBQvMHNqHXo@kernel.org> (raw)
In-Reply-To: <CAP-5=fUzNak==X63zWDkMTsU8UYBACOtevED3ZR4Thruc0cWWg@mail.gmail.com>
Em Tue, Sep 21, 2021 at 10:45:45AM -0700, Ian Rogers escreveu:
> On Wed, Jun 16, 2021 at 10:55 PM Ian Rogers <irogers@google.com> wrote:
>
> > As a full union is always sent, ensure all bytes of the union are
> > initialized with memset to avoid msan warnings of use of uninitialized
> > memory.
> >
> > An example warning from the daemon test:
> >
> > Uninitialized bytes in __interceptor_write at offset 71 inside
> > [0x7ffd98da6280, 72)
> > ==11602==WARNING: MemorySanitizer: use-of-uninitialized-value
> > #0 0x5597edccdbe4 in ion tools/lib/perf/lib.c:18:6
> > #1 0x5597edccdbe4 in writen tools/lib/perf/lib.c:47:9
> > #2 0x5597ed221d30 in send_cmd tools/perf/builtin-daemon.c:1376:22
> > #3 0x5597ed21b48c in cmd_daemon tools/perf/builtin-daemon.c
> > #4 0x5597ed1d6b67 in run_builtin tools/perf/perf.c:313:11
> > #5 0x5597ed1d6036 in handle_internal_command tools/perf/perf.c:365:8
> > #6 0x5597ed1d6036 in run_argv tools/perf/perf.c:409:2
> > #7 0x5597ed1d6036 in main tools/perf/perf.c:539:3
> >
> > SUMMARY: MemorySanitizer: use-of-uninitialized-value
> > tools/lib/perf/lib.c:18:6 in ion
> > Exiting
> >
> > Signed-off-by: Ian Rogers <irogers@google.com>
> >
>
> This one appears to still be outstanding. Ping.
Thanks, applied.
- Arnaldo
prev parent reply other threads:[~2021-09-21 19:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 5:55 [PATCH] perf daemon: Avoid msan warnings on send_cmd Ian Rogers
[not found] ` <CAP-5=fUzNak==X63zWDkMTsU8UYBACOtevED3ZR4Thruc0cWWg@mail.gmail.com>
2021-09-21 19:25 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUoxxkBQvMHNqHXo@kernel.org \
--to=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.