From: Cyril Hrubis <chrubis@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: LTP List <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH v2] lib: shell: Fix timeout process races
Date: Wed, 22 Sep 2021 11:31:55 +0200 [thread overview]
Message-ID: <YUr4C3VOYI4qtS/F@yuki> (raw)
In-Reply-To: <CAEemH2etot5qBfTWkk3JqRZ1ywTo75M7Vu-ZhXvnQgVqcZovBw@mail.gmail.com>
Hi!
> > > Agreed, that sounds like a great method.
> >
> > Should I send v3 or can I commit v2 with this change?
> >
>
> V3 please, I will help test it all.
Ok, will send ASAP.
> I just think of setsid(), is that works and better than setpgid(0, 0)?
For moving the process out of the process group setpgid() is enough, we
use it in the lib/tst_test.c for the fork_testrun() in order to track
all children of the test process as well.
I do not think that we need a new session here, that would probably have
strange side effects, for instance it would isolate the tst_timeout_kill
process from the terminal the tests were started in.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2021-09-22 9:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 12:21 [LTP] [PATCH v2] lib: shell: Fix timeout process races Cyril Hrubis
2021-09-20 16:11 ` Petr Vorel
2021-09-21 3:27 ` Li Wang
2021-09-21 11:30 ` Cyril Hrubis
2021-09-22 4:30 ` Li Wang
2021-09-22 9:02 ` Cyril Hrubis
2021-09-22 9:13 ` Li Wang
2021-09-22 9:21 ` Cyril Hrubis
2021-09-22 9:22 ` Li Wang
2021-09-22 9:31 ` Cyril Hrubis [this message]
2021-09-22 9:39 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YUr4C3VOYI4qtS/F@yuki \
--to=chrubis@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.