From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mT4jk-0000Us-8X for mharc-qemu-riscv@gnu.org; Wed, 22 Sep 2021 12:04:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT4je-0000Ry-5Q for qemu-riscv@nongnu.org; Wed, 22 Sep 2021 12:04:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:56392) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT4jb-0004TJ-R0 for qemu-riscv@nongnu.org; Wed, 22 Sep 2021 12:04:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632326674; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QebOB2SYHOmYM3jUpMCe05d9zHZjO5/ZfL4UGrTq+EM=; b=KXFb/L2ebMSRDbiP66SurAVdffcyz1NvHMiAd9K8moeWHjm8fNLv/ePmewu+iKeE16TXI+ VaxaCa1rw26m1uuf5NAt1ttWLGGGa4XjTPZXCOd18hEoUmZD4YMk1alc0bi0VYDtRpFH14 8NWhTb/Fw8/oz49I4hmPV5YjNejns/0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-18-7eIC7RurO66dIJH9eiFOlg-1; Wed, 22 Sep 2021 12:04:16 -0400 X-MC-Unique: 7eIC7RurO66dIJH9eiFOlg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C88551923768; Wed, 22 Sep 2021 16:04:11 +0000 (UTC) Received: from redhat.com (unknown [10.39.195.69]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4BE661865D; Wed, 22 Sep 2021 16:02:27 +0000 (UTC) Date: Wed, 22 Sep 2021 17:02:24 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Cc: qemu-devel@nongnu.org, Greg Kurz , Bin Meng , Yoshinori Sato , Stafford Horne , Cornelia Huck , David Hildenbrand , "Edgar E. Iglesias" , Jiaxun Yang , Peter Xu , Christian Borntraeger , qemu-ppc@nongnu.org, Mark Cave-Ayland , Paolo Bonzini , qemu-arm@nongnu.org, Michael Rolnik , Peter Maydell , Palmer Dabbelt , Alistair Francis , Halil Pasic , Taylor Simpson , Gerd Hoffmann , qemu-riscv@nongnu.org, Max Filippov , Yuval Shaia , Bastian Koppelmann , Artyom Tarasenko , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Thomas Huth , Aleksandar Rikalo , David Gibson , Marcel Apfelbaum , Laurent Vivier , "Dr. David Alan Gilbert" , Eduardo Habkost , Marek Vasut , Aurelien Jarno , qemu-s390x@nongnu.org, Laurent Vivier , Eric Blake , Richard Henderson , Chris Wulff Subject: Re: [PATCH v2 01/53] docs/devel: rename file for writing monitor commands Message-ID: Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20210914142042.1655100-1-berrange@redhat.com> <20210914142042.1655100-2-berrange@redhat.com> <87a6k74rsl.fsf@dusky.pond.sub.org> MIME-Version: 1.0 In-Reply-To: <87a6k74rsl.fsf@dusky.pond.sub.org> User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) DKIMWL_WL_HIGH=-1.472, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Sep 2021 16:04:39 -0000 On Mon, Sep 20, 2021 at 09:42:02AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > The file already covers writing new style HMP commands, in addition to > > the QMP commands, so it deserves a more general name. > > > > Signed-off-by: Daniel P. Berrangé > > --- > > docs/devel/index.rst | 2 +- > > ...riting-qmp-commands.rst => writing-monitor-commands.rst} | 6 +++--- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > rename docs/devel/{writing-qmp-commands.rst => writing-monitor-commands.rst} (99%) > > > > diff --git a/docs/devel/index.rst b/docs/devel/index.rst > > index f95df10b3e..7c25177c5d 100644 > > --- a/docs/devel/index.rst > > +++ b/docs/devel/index.rst > > @@ -44,4 +44,4 @@ modifying QEMU's source code. > > ebpf_rss > > vfio-migration > > qapi-code-gen > > - writing-qmp-commands > > + writing-monitor-commands > > diff --git a/docs/devel/writing-qmp-commands.rst b/docs/devel/writing-monitor-commands.rst > > similarity index 99% > > rename from docs/devel/writing-qmp-commands.rst > > rename to docs/devel/writing-monitor-commands.rst > > index 6a10a06c48..497c9ce0d5 100644 > > --- a/docs/devel/writing-qmp-commands.rst > > +++ b/docs/devel/writing-monitor-commands.rst > > @@ -1,8 +1,8 @@ > > -How to write QMP commands using the QAPI framework > > -================================================== > > +How to write monitor commands > > +============================= > > > > This document is a step-by-step guide on how to write new QMP commands using > > -the QAPI framework. It also shows how to implement new style HMP commands. > > +the QAPI framework and new style HMP commands. > > Recommend to drop "new style", here and in the commit message. Ok, will do. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:ac2:5978:0:0:0:0:0 with SMTP id h24csp320784lfp; Wed, 22 Sep 2021 09:06:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwC2Fr+KM2+Z5fzYy14vVRzHk2pqIlqG392wBHcdW9t3PQToqrm2AYbIqqu4M1+e9hSriAE X-Received: by 2002:a67:c81a:: with SMTP id u26mr489565vsk.33.1632326812794; Wed, 22 Sep 2021 09:06:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1632326812; cv=none; d=google.com; s=arc-20160816; b=FnDyIPkgoFW82K1uAOTPUfPwFqjq0n1ZICNkTRcRDJk2VmUihKFeXT7lFZtyWiWLKW wHC26sJZ43XZocIuWrOMSyfwoXkXFYMWx4+qz+oTVk+spACh3KhbRyPKDxo/h155lZwp 6CquwW6y0y6UdEn13FzBu/uO34ohfbWmsPqf4kd5UkYsvjSdhtkxBne3KxGz8kK5FEQd imc3OYZ7IdAjazYWDn5rMgVE0el6HEj/oAWGB4BNsYZce7e46A+2qzAPBunBFgef9wFe l/H/a4IgP7u0WAaJ/BnAaQwzjU36WgTrFyhZXsc/Rh9tGo1K1Rw0TD6MKT5/tMH7Nyms ys7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:content-disposition:user-agent :in-reply-to:mime-version:references:message-id:subject:to:from:date :dkim-signature; bh=QebOB2SYHOmYM3jUpMCe05d9zHZjO5/ZfL4UGrTq+EM=; b=vGKNBuBfEeEkLNtcu4nU4W+rQyrpnZddpeoIoaSOJuNcwFDQgd+r43gGL4WfAHRd6h /6133sHozfwTtrDm48+gvbLryPhMqH/5qtO0wD0w+HcGaug8ponuAYquVsvSonl+4D9S NRmGQLHxNUvBHWZ2NjIs3C5ImBbbr02G3lZt0ndBc/6HFv1P+gL5m+VPZnhU2vr3C4pO XpWV4bCvJC7KJ9czhFrKPHbz4gs8ntcZw+3nMvGsCwmcgHA2DWy9vcOMeqZaNG9cCwfX AzkFbx7r/o1/i9kuiBGtHaNt9poIGa2bykEGiR5Wim9Fg0+pg5acNh0AwDGoLlYurMT4 y0TQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=ejX35bdM; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id h28si1789413vsg.450.2021.09.22.09.06.52 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 22 Sep 2021 09:06:52 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=ejX35bdM; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:47002 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mT4lm-0001BS-Su for alex.bennee@linaro.org; Wed, 22 Sep 2021 12:06:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT4jc-0000Nz-Kc for qemu-arm@nongnu.org; Wed, 22 Sep 2021 12:04:36 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:25003) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT4jY-0004PA-87 for qemu-arm@nongnu.org; Wed, 22 Sep 2021 12:04:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632326670; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QebOB2SYHOmYM3jUpMCe05d9zHZjO5/ZfL4UGrTq+EM=; b=ejX35bdMmV60vaxQDfiQ0T6xYXxkY3xe779kUBMkCCOH5wKmsAlfQ3WxWJrKp1i9nTCW7P 7P8Xe5ePjVwPmuy6Mk1B2OBjITGoyi5bC5TD0pG7qoueQldhPnXXleEUZCOnOIa9zvGpeB +geXWqYpDp7wV8EUjHBvmNnRV4Nw0sI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-18-7eIC7RurO66dIJH9eiFOlg-1; Wed, 22 Sep 2021 12:04:16 -0400 X-MC-Unique: 7eIC7RurO66dIJH9eiFOlg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C88551923768; Wed, 22 Sep 2021 16:04:11 +0000 (UTC) Received: from redhat.com (unknown [10.39.195.69]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4BE661865D; Wed, 22 Sep 2021 16:02:27 +0000 (UTC) Date: Wed, 22 Sep 2021 17:02:24 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Subject: Re: [PATCH v2 01/53] docs/devel: rename file for writing monitor commands Message-ID: References: <20210914142042.1655100-1-berrange@redhat.com> <20210914142042.1655100-2-berrange@redhat.com> <87a6k74rsl.fsf@dusky.pond.sub.org> MIME-Version: 1.0 In-Reply-To: <87a6k74rsl.fsf@dusky.pond.sub.org> User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -23 X-Spam_score: -2.4 X-Spam_bar: -- X-Spam_report: (-2.4 / 5.0 requ) DKIMWL_WL_HIGH=-1.472, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Peter Maydell , Chris Wulff , David Hildenbrand , Bin Meng , Mark Cave-Ayland , qemu-devel@nongnu.org, Jiaxun Yang , Laurent Vivier , Max Filippov , Taylor Simpson , Alistair Francis , Gerd Hoffmann , Eric Blake , Marek Vasut , Yoshinori Sato , Halil Pasic , Christian Borntraeger , Marcel Apfelbaum , Palmer Dabbelt , Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , Richard Henderson , Greg Kurz , Yuval Shaia , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Michael Rolnik , Peter Xu , Stafford Horne , David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , Cornelia Huck , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-ppc@nongnu.org, Aurelien Jarno , Paolo Bonzini , Aleksandar Rikalo , "Dr. David Alan Gilbert" Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: mV+IsTOlWDjC On Mon, Sep 20, 2021 at 09:42:02AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > The file already covers writing new style HMP commands, in addition to > > the QMP commands, so it deserves a more general name. > > > > Signed-off-by: Daniel P. Berrangé > > --- > > docs/devel/index.rst | 2 +- > > ...riting-qmp-commands.rst => writing-monitor-commands.rst} | 6 +++--- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > rename docs/devel/{writing-qmp-commands.rst => writing-monitor-commands.rst} (99%) > > > > diff --git a/docs/devel/index.rst b/docs/devel/index.rst > > index f95df10b3e..7c25177c5d 100644 > > --- a/docs/devel/index.rst > > +++ b/docs/devel/index.rst > > @@ -44,4 +44,4 @@ modifying QEMU's source code. > > ebpf_rss > > vfio-migration > > qapi-code-gen > > - writing-qmp-commands > > + writing-monitor-commands > > diff --git a/docs/devel/writing-qmp-commands.rst b/docs/devel/writing-monitor-commands.rst > > similarity index 99% > > rename from docs/devel/writing-qmp-commands.rst > > rename to docs/devel/writing-monitor-commands.rst > > index 6a10a06c48..497c9ce0d5 100644 > > --- a/docs/devel/writing-qmp-commands.rst > > +++ b/docs/devel/writing-monitor-commands.rst > > @@ -1,8 +1,8 @@ > > -How to write QMP commands using the QAPI framework > > -================================================== > > +How to write monitor commands > > +============================= > > > > This document is a step-by-step guide on how to write new QMP commands using > > -the QAPI framework. It also shows how to implement new style HMP commands. > > +the QAPI framework and new style HMP commands. > > Recommend to drop "new style", here and in the commit message. Ok, will do. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B7D5C433EF for ; Wed, 22 Sep 2021 16:09:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC9E661090 for ; Wed, 22 Sep 2021 16:09:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CC9E661090 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:51228 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mT4o3-00043O-37 for qemu-devel@archiver.kernel.org; Wed, 22 Sep 2021 12:09:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT4ja-0000J1-W7 for qemu-devel@nongnu.org; Wed, 22 Sep 2021 12:04:35 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:59206) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mT4jX-0004Oy-Ru for qemu-devel@nongnu.org; Wed, 22 Sep 2021 12:04:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1632326670; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QebOB2SYHOmYM3jUpMCe05d9zHZjO5/ZfL4UGrTq+EM=; b=ejX35bdMmV60vaxQDfiQ0T6xYXxkY3xe779kUBMkCCOH5wKmsAlfQ3WxWJrKp1i9nTCW7P 7P8Xe5ePjVwPmuy6Mk1B2OBjITGoyi5bC5TD0pG7qoueQldhPnXXleEUZCOnOIa9zvGpeB +geXWqYpDp7wV8EUjHBvmNnRV4Nw0sI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-18-7eIC7RurO66dIJH9eiFOlg-1; Wed, 22 Sep 2021 12:04:16 -0400 X-MC-Unique: 7eIC7RurO66dIJH9eiFOlg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C88551923768; Wed, 22 Sep 2021 16:04:11 +0000 (UTC) Received: from redhat.com (unknown [10.39.195.69]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4BE661865D; Wed, 22 Sep 2021 16:02:27 +0000 (UTC) Date: Wed, 22 Sep 2021 17:02:24 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Markus Armbruster Subject: Re: [PATCH v2 01/53] docs/devel: rename file for writing monitor commands Message-ID: References: <20210914142042.1655100-1-berrange@redhat.com> <20210914142042.1655100-2-berrange@redhat.com> <87a6k74rsl.fsf@dusky.pond.sub.org> MIME-Version: 1.0 In-Reply-To: <87a6k74rsl.fsf@dusky.pond.sub.org> User-Agent: Mutt/2.0.7 (2021-05-04) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.472, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: Peter Maydell , Chris Wulff , David Hildenbrand , Bin Meng , Mark Cave-Ayland , qemu-devel@nongnu.org, Laurent Vivier , Max Filippov , Taylor Simpson , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Eric Blake , Marek Vasut , Yoshinori Sato , Halil Pasic , Christian Borntraeger , Palmer Dabbelt , Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , Richard Henderson , Greg Kurz , Yuval Shaia , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Michael Rolnik , Peter Xu , Stafford Horne , David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , Cornelia Huck , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , qemu-ppc@nongnu.org, Aurelien Jarno , Paolo Bonzini , Aleksandar Rikalo , "Dr. David Alan Gilbert" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Sep 20, 2021 at 09:42:02AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > The file already covers writing new style HMP commands, in addition to > > the QMP commands, so it deserves a more general name. > > > > Signed-off-by: Daniel P. Berrangé > > --- > > docs/devel/index.rst | 2 +- > > ...riting-qmp-commands.rst => writing-monitor-commands.rst} | 6 +++--- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > rename docs/devel/{writing-qmp-commands.rst => writing-monitor-commands.rst} (99%) > > > > diff --git a/docs/devel/index.rst b/docs/devel/index.rst > > index f95df10b3e..7c25177c5d 100644 > > --- a/docs/devel/index.rst > > +++ b/docs/devel/index.rst > > @@ -44,4 +44,4 @@ modifying QEMU's source code. > > ebpf_rss > > vfio-migration > > qapi-code-gen > > - writing-qmp-commands > > + writing-monitor-commands > > diff --git a/docs/devel/writing-qmp-commands.rst b/docs/devel/writing-monitor-commands.rst > > similarity index 99% > > rename from docs/devel/writing-qmp-commands.rst > > rename to docs/devel/writing-monitor-commands.rst > > index 6a10a06c48..497c9ce0d5 100644 > > --- a/docs/devel/writing-qmp-commands.rst > > +++ b/docs/devel/writing-monitor-commands.rst > > @@ -1,8 +1,8 @@ > > -How to write QMP commands using the QAPI framework > > -================================================== > > +How to write monitor commands > > +============================= > > > > This document is a step-by-step guide on how to write new QMP commands using > > -the QAPI framework. It also shows how to implement new style HMP commands. > > +the QAPI framework and new style HMP commands. > > Recommend to drop "new style", here and in the commit message. Ok, will do. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|