From: Tony Lindgren <tony@atomide.com>
To: Adam Ford <aford173@gmail.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Chunyan Zhang <zhang.chunyan@linaro.org>,
Faiz Abbas <faiz_abbas@ti.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Santosh Shilimkar <ssantosh@kernel.org>,
linux-mmc <linux-mmc@vger.kernel.org>,
Linux-OMAP <linux-omap@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH 1/5] dt-bindings: sdhci-omap: Update binding for legacy SoCs
Date: Wed, 6 Oct 2021 08:03:24 +0300 [thread overview]
Message-ID: <YV0uHN9N73YbWUsK@atomide.com> (raw)
In-Reply-To: <CAHCN7xLBi09oHa75SxOc=CJ3hHZCNTxn6Z7m0NwuMcLY8+UL6g@mail.gmail.com>
* Adam Ford <aford173@gmail.com> [211005 10:46]:
> On Tue, Oct 5, 2021 at 3:04 AM Tony Lindgren <tony@atomide.com> wrote:
> >
> > Hi,
> >
> > * Adam Ford <aford173@gmail.com> [211002 13:29]:
> > > I noticed that you added omap3 compatibility to the driver and the
> > > bindings, but no device tree changes for omap3.dtsi to enable this.
> > > Is there anything holding back?
> >
> > There is at least the wl1251 quirk handling missing as I mentioned in
> > the cover letter. I guess we could enable sdhci except for wl1251 users
> > though.
>
> Sorry, I guess I missed the cover letter. I didn't see any obvious
> differences between the drivers other than the hsmmc driver enumerated
> before the DMA, so it threw some splat indicating that. The newer
> driver appears to enumerate after the DMA, so that message
> disappeared.
OK
> > > I modified omap3.dtsi and changed the compatible flag to
> > > ti,omap3-sdhci and it boots from SD card just fine. For some reason,
> > > I cannot get the wl1283 to function, but the driver probes, so I need
> > > to spend some time investigating this.
> > >
> > > If i can get my wl1283 working again, I'll reply with a tested note.
> > > I hope to have more time tomorrow, but i can't do it any more today.
> >
> > I don't have wl1283 omap3 devices online, but I have tested that the
> > sdhci patches do work with wl12xx and mwifiex drivers. Did you figure
> > out why your wl1283 is not working with sdhci?
>
> I did get it working. It was a MAC address issue. I didn't properly
> set the MAC address. Once I did, it worked just fine.
>
> I think I sent a 2nd reply with a tested-by message.
OK good to hear, thanks for testing :)
Regards,
Tony
next prev parent reply other threads:[~2021-10-06 5:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 6:57 [PATCHv2 0/5] More SoCs for sdhci-omap to deprecate omap_hsmmc Tony Lindgren
2021-09-30 6:57 ` [PATCH 1/5] dt-bindings: sdhci-omap: Update binding for legacy SoCs Tony Lindgren
2021-10-02 13:29 ` Adam Ford
2021-10-05 8:04 ` Tony Lindgren
2021-10-05 10:45 ` Adam Ford
2021-10-06 5:03 ` Tony Lindgren [this message]
2021-10-02 16:15 ` Adam Ford
2021-09-30 6:57 ` [PATCH 2/5] mmc: sdhci-omap: Handle voltages to add support omap4 Tony Lindgren
2021-09-30 6:57 ` [PATCH 3/5] mmc: sdhci-omap: Add omap_offset to support omap3 and earlier Tony Lindgren
2021-09-30 6:57 ` [PATCH 4/5] mmc: sdhci-omap: Implement PM runtime functions Tony Lindgren
2021-10-08 14:43 ` Ulf Hansson
2021-10-11 5:23 ` Tony Lindgren
2021-10-12 9:05 ` Ulf Hansson
2021-10-12 9:18 ` Tony Lindgren
2021-09-30 6:57 ` [PATCH 5/5] mmc: sdhci-omap: Configure optional wakeirq Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2021-09-21 11:15 [PATCH 0/5] More SoCs for sdhci-omap to deprecate omap_hsmmc Tony Lindgren
2021-09-21 11:15 ` [PATCH 1/5] dt-bindings: sdhci-omap: Update binding for legacy SoCs Tony Lindgren
2021-09-23 22:30 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV0uHN9N73YbWUsK@atomide.com \
--to=tony@atomide.com \
--cc=adrian.hunter@intel.com \
--cc=aford173@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=faiz_abbas@ti.com \
--cc=kishon@ti.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh@kernel.org \
--cc=ssantosh@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=zhang.chunyan@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.