From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B7FDC433EF for ; Wed, 6 Oct 2021 13:32:07 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D8B2961075 for ; Wed, 6 Oct 2021 13:32:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D8B2961075 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633527126; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=UWh6xMgedLncpsMJQyY8BfhX3KZAmQVOWcXXRqPZpaA=; b=U1YbO++UrmRQcMphi4OHFX2zjsINFHfNfRwNBiSnelbsUtVvhxHwL0unMv1qBUceRjb/0g NzVxe56K01KNaeogfhKNS0G9UbLOzk5Rj6UN7gwZpRJa6tvaiyx4eEVtGYVKJFRRRSmd/f mITFweafsm0OFFx5fFrSVFakSnhzzms= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-405-eLdBzYq4Mue67EKvcAZV2Q-1; Wed, 06 Oct 2021 09:32:03 -0400 X-MC-Unique: eLdBzYq4Mue67EKvcAZV2Q-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D9AE810168CE; Wed, 6 Oct 2021 13:31:58 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C01B45F4EE; Wed, 6 Oct 2021 13:31:58 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 97A594E9F4; Wed, 6 Oct 2021 13:31:58 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 196DSViS014912 for ; Wed, 6 Oct 2021 09:28:31 -0400 Received: by smtp.corp.redhat.com (Postfix) id 2CFB52026D64; Wed, 6 Oct 2021 13:28:31 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast05.extmail.prod.ext.rdu2.redhat.com [10.11.55.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 28FB22026D48 for ; Wed, 6 Oct 2021 13:28:22 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D0644805C1D for ; Wed, 6 Oct 2021 13:28:22 +0000 (UTC) Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-58-LAq0YU5dMOCtYQZ0KI-F_A-1; Wed, 06 Oct 2021 09:28:21 -0400 X-MC-Unique: LAq0YU5dMOCtYQZ0KI-F_A-1 Received: by mail-qt1-f197.google.com with SMTP id r13-20020ac86d2d000000b002a755d36425so2261660qtu.14 for ; Wed, 06 Oct 2021 06:28:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1tJD1MyAZSMlO+w5dHejgDl1BZyQkw7PrMG9J/BwPx4=; b=wRqjdlw9tjOdL7/xO3R5DRC5u1YANzRqtpTK6TJo23Aj9QL3I0ofb+BGrm1nSDtinQ LovrzhMnIbXLr6e9TwRc8jrjpQhZ2uUOdT+wV1dw5L8OydFtFstmJHCp6MBPle3QDwwv krS53rVkzI+Txh6OU6fidA0JpuNzaaEvw7pTm56at1oHSkT68b9sJORjznBynIenYdLF qaNBh0MbF9t38zPMdrqIp5htpk5+l3/6KMQxKiTeCV9uBxVGglSWSUeL8puiX9ZEPYvb vEGVeFOAFj04ycudUxMHCdQx0ES1d/3Rq1BGCWuQ5+jG7vPBnpnvPsuLEfMZCkcKXZ26 ezsg== X-Gm-Message-State: AOAM531tDgje0uzM4lwhUouB0GPHJcZCb6S2aplbHCDinm5wQbEDCEyL 8rKiBeouHUNVpeoV1WFq9ExJODGmbwvImGJIW44cHqPzuZlyQ5d8qmlBb1j1QhhIODhdP9ku9xf 7LRegv9h04mWEmQ== X-Received: by 2002:a05:622a:614:: with SMTP id z20mr26023526qta.232.1633526901338; Wed, 06 Oct 2021 06:28:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwQYqJgkQDoER0wVjEnhGOvfMferVnYWL3MCFbh+T5SgAmvWHhmeJb7yIfGG5UVXT07/2sCPA== X-Received: by 2002:a05:622a:614:: with SMTP id z20mr26023510qta.232.1633526901173; Wed, 06 Oct 2021 06:28:21 -0700 (PDT) Received: from localhost (pool-68-160-176-52.bstnma.fios.verizon.net. [68.160.176.52]) by smtp.gmail.com with ESMTPSA id m1sm1131877qtu.59.2021.10.06.06.28.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Oct 2021 06:28:20 -0700 (PDT) Date: Wed, 6 Oct 2021 09:28:20 -0400 From: Mike Snitzer To: linux-block@vger.kernel.org, Jens Axboe Message-ID: References: <20210929163600.52141-1-ebiggers@kernel.org> <20210929163600.52141-4-ebiggers@kernel.org> MIME-Version: 1.0 In-Reply-To: <20210929163600.52141-4-ebiggers@kernel.org> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: dm-devel@redhat.com Cc: Satya Tangirala , dm-devel@redhat.com, linux-mmc@vger.kernel.org, Ulf Hansson , linux-scsi@vger.kernel.org Subject: Re: [dm-devel] [PATCH v4 3/4] blk-crypto: rename blk_keyslot_manager to blk_crypto_profile X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Sep 29 2021 at 12:35P -0400, Eric Biggers wrote: > From: Eric Biggers > > blk_keyslot_manager is misnamed because it doesn't necessarily manage > keyslots. It actually does several different things: > > - Contains the crypto capabilities of the device. > > - Provides functions to control the inline encryption hardware. > Originally these were just for programming/evicting keyslots; > however, new functionality (hardware-wrapped keys) will require new > functions here which are unrelated to keyslots. Moreover, > device-mapper devices already (ab)use "keyslot_evict" to pass key > eviction requests to their underlying devices even though > device-mapper devices don't have any keyslots themselves (so it > really should be "evict_key", not "keyslot_evict"). > > - Sometimes (but not always!) it manages keyslots. Originally it > always did, but device-mapper devices don't have keyslots > themselves, so they use a "passthrough keyslot manager" which > doesn't actually manage keyslots. This hack works, but the > terminology is unnatural. Also, some hardware doesn't have keyslots > and thus also uses a "passthrough keyslot manager" (support for such > hardware is yet to be upstreamed, but it will happen eventually). > > Let's stop having keyslot managers which don't actually manage keyslots. > Instead, rename blk_keyslot_manager to blk_crypto_profile. > > This is a fairly big change, since for consistency it also has to update > keyslot manager-related function names, variable names, and comments -- > not just the actual struct name. However it's still a fairly > straightforward change, as it doesn't change any actual functionality. > > Acked-by: Ulf Hansson # For MMC > Signed-off-by: Eric Biggers Unfortunate how fiddley this change forced you to get but it looks like you've done a very solid job of cleaning it all up to be consistent. Reviewed-by: Mike Snitzer -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6523C433EF for ; Wed, 6 Oct 2021 13:28:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98D3860E9C for ; Wed, 6 Oct 2021 13:28:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231532AbhJFNaR (ORCPT ); Wed, 6 Oct 2021 09:30:17 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:44719 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230077AbhJFNaP (ORCPT ); Wed, 6 Oct 2021 09:30:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633526902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1tJD1MyAZSMlO+w5dHejgDl1BZyQkw7PrMG9J/BwPx4=; b=Ax0NXD/9LgNZJ+Y+nwoVdqtuG/pOhYCOMCyBssx/lVgR34jWiBIa1YUsv/4/xN4i/YELxY nF8n0gRv/MxLN772d4KUa/bjo+waN/SF/ZSxEaH6hx4Bda5brvNkk3NTKd7DUh/N7S/XpA YyWmOu7d8tg0LcAIo2gUolVqHUx52Pk= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-230-O1eZQBxvNKylX3LcmLRbig-1; Wed, 06 Oct 2021 09:28:22 -0400 X-MC-Unique: O1eZQBxvNKylX3LcmLRbig-1 Received: by mail-qt1-f198.google.com with SMTP id h10-20020ac8584a000000b002a712bc435fso2237357qth.20 for ; Wed, 06 Oct 2021 06:28:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=1tJD1MyAZSMlO+w5dHejgDl1BZyQkw7PrMG9J/BwPx4=; b=vZ8vHfqAO7VUFK6CPQghPO4q5F74oq4QRQ+mqch2/DkCkPXMNF02I8AEtT0sqqbZhS HLLtu17wYZs++7BkbyIMDru7xv1d+FodhFVRLRnA58Snu0YxJOMe6AY5lnMyQECHHFWn SKLRHHc6N5S55WNpMShIwrthgVr8pO9C5yl/qg5EUtDdbsOSXC1TSQkVXfQNHiw8hOuL kYXoBx97PeRQKBG8gJoOAN7OObbLoE7Kr2FjRBl8UbkUbE2jnhGfDFee4jYRbu4LcoO9 m5llj4zhkNJnuQRXaQELzLdkxz37Tb/8V+w3wQJTZs6R9k2ydRmktYTFnKWu7PYtc4Af CYvQ== X-Gm-Message-State: AOAM531mnjgzvnOJPTuX53CYaiQKHzF38EDPr5PliLRE04Q/rikGBp7j 7boAuTqxsWM47DRb8WCGRmH+MQmw9QqiTWUJDbHB3xxs6hgNhDvJOI1/LCQixorelV8eaMU4V5O lnw0LXkGLUTG+rDT7PB8Jp+DDK7O/t6WrpqQpqoF+a7AuNPAdxp47dv2J4bAocIE7hreC/cU6 X-Received: by 2002:a05:622a:614:: with SMTP id z20mr26023538qta.232.1633526901406; Wed, 06 Oct 2021 06:28:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwQYqJgkQDoER0wVjEnhGOvfMferVnYWL3MCFbh+T5SgAmvWHhmeJb7yIfGG5UVXT07/2sCPA== X-Received: by 2002:a05:622a:614:: with SMTP id z20mr26023510qta.232.1633526901173; Wed, 06 Oct 2021 06:28:21 -0700 (PDT) Received: from localhost (pool-68-160-176-52.bstnma.fios.verizon.net. [68.160.176.52]) by smtp.gmail.com with ESMTPSA id m1sm1131877qtu.59.2021.10.06.06.28.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 Oct 2021 06:28:20 -0700 (PDT) Date: Wed, 6 Oct 2021 09:28:20 -0400 From: Mike Snitzer To: linux-block@vger.kernel.org, Jens Axboe Cc: Satya Tangirala , dm-devel@redhat.com, linux-mmc@vger.kernel.org, linux-scsi@vger.kernel.org, Ulf Hansson Subject: Re: [PATCH v4 3/4] blk-crypto: rename blk_keyslot_manager to blk_crypto_profile Message-ID: References: <20210929163600.52141-1-ebiggers@kernel.org> <20210929163600.52141-4-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210929163600.52141-4-ebiggers@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Sep 29 2021 at 12:35P -0400, Eric Biggers wrote: > From: Eric Biggers > > blk_keyslot_manager is misnamed because it doesn't necessarily manage > keyslots. It actually does several different things: > > - Contains the crypto capabilities of the device. > > - Provides functions to control the inline encryption hardware. > Originally these were just for programming/evicting keyslots; > however, new functionality (hardware-wrapped keys) will require new > functions here which are unrelated to keyslots. Moreover, > device-mapper devices already (ab)use "keyslot_evict" to pass key > eviction requests to their underlying devices even though > device-mapper devices don't have any keyslots themselves (so it > really should be "evict_key", not "keyslot_evict"). > > - Sometimes (but not always!) it manages keyslots. Originally it > always did, but device-mapper devices don't have keyslots > themselves, so they use a "passthrough keyslot manager" which > doesn't actually manage keyslots. This hack works, but the > terminology is unnatural. Also, some hardware doesn't have keyslots > and thus also uses a "passthrough keyslot manager" (support for such > hardware is yet to be upstreamed, but it will happen eventually). > > Let's stop having keyslot managers which don't actually manage keyslots. > Instead, rename blk_keyslot_manager to blk_crypto_profile. > > This is a fairly big change, since for consistency it also has to update > keyslot manager-related function names, variable names, and comments -- > not just the actual struct name. However it's still a fairly > straightforward change, as it doesn't change any actual functionality. > > Acked-by: Ulf Hansson # For MMC > Signed-off-by: Eric Biggers Unfortunate how fiddley this change forced you to get but it looks like you've done a very solid job of cleaning it all up to be consistent. Reviewed-by: Mike Snitzer