From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 487D5C433FE for ; Wed, 6 Oct 2021 16:08:23 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01C7A610EA for ; Wed, 6 Oct 2021 16:08:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 01C7A610EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BBD3E836; Wed, 6 Oct 2021 18:07:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BBD3E836 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1633536499; bh=21rO1Ta+V+Y0VJIs4/EBNiK1Q8BTUVwSJqeKW0hOtcA=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=j2GKX5Gs5zqvautcXB/SQCrdDAy2vOysTZT5EeVVKIhWW/XERTGT1TgeBZWYv6yXZ XQnTU/mvgFbsmGkjBRg0gguYRULG0ZaP2iMAWrWvxITBOX+37Y8v2zH/K59REpye5J agZZ7UlqLKwBcJ7htWraETFqmMZVJsmlJfoFlr5w= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 41231F80229; Wed, 6 Oct 2021 18:07:29 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id CE0BBF80240; Wed, 6 Oct 2021 18:07:27 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B0327F8010B for ; Wed, 6 Oct 2021 18:07:23 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B0327F8010B X-IronPort-AV: E=McAfee;i="6200,9189,10129"; a="213153340" X-IronPort-AV: E=Sophos;i="5.85,352,1624345200"; d="scan'208";a="213153340" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 09:05:54 -0700 X-IronPort-AV: E=Sophos;i="5.85,352,1624345200"; d="scan'208";a="568222307" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 09:05:50 -0700 Received: from andy by smile with local (Exim 4.95) (envelope-from ) id 1mY9QR-009FXV-97; Wed, 06 Oct 2021 19:05:47 +0300 Date: Wed, 6 Oct 2021 19:05:47 +0300 From: Andy Shevchenko To: Mark Brown Subject: Re: [PATCH v1 2/4] ASoC: Intel: bytcr_rt5640: Use temporary variable for struct device Message-ID: References: <20211006150442.16503-1-andriy.shevchenko@linux.intel.com> <20211006150442.16503-2-andriy.shevchenko@linux.intel.com> <4b81a10dca78e286a9f806464b97111b5a15a91e.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , Jie Yang , Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Hans de Goede , Joe Perches X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Wed, Oct 06, 2021 at 04:48:57PM +0100, Mark Brown wrote: > On Wed, Oct 06, 2021 at 06:44:07PM +0300, Andy Shevchenko wrote: > > On Wed, Oct 06, 2021 at 08:21:01AM -0700, Joe Perches wrote: > > > > Some will complain about a lack of commit message. > > > Yeah, sorry for that, it wasn't deliberate. I forgot to run `git msg-filter` > > on these three patches to add it. > > > Mark, do you want me resend entire bunch(es) or just starting from these > > patches? Or...? > > If you're adding a commit message with automation it's probably not > adding any value. What do you mean? I add it exceptionally for the same (by nature) patches. What do you expect to be altered in these three, if the idea behind the change is very well the same? -- With Best Regards, Andy Shevchenko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F7C7C433EF for ; Wed, 6 Oct 2021 16:10:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4251B610E6 for ; Wed, 6 Oct 2021 16:10:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239319AbhJFQMS (ORCPT ); Wed, 6 Oct 2021 12:12:18 -0400 Received: from mga14.intel.com ([192.55.52.115]:29074 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230021AbhJFQMQ (ORCPT ); Wed, 6 Oct 2021 12:12:16 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10129"; a="226342179" X-IronPort-AV: E=Sophos;i="5.85,352,1624345200"; d="scan'208";a="226342179" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 09:05:53 -0700 X-IronPort-AV: E=Sophos;i="5.85,352,1624345200"; d="scan'208";a="568222307" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2021 09:05:50 -0700 Received: from andy by smile with local (Exim 4.95) (envelope-from ) id 1mY9QR-009FXV-97; Wed, 06 Oct 2021 19:05:47 +0300 Date: Wed, 6 Oct 2021 19:05:47 +0300 From: Andy Shevchenko To: Mark Brown Cc: Joe Perches , Pierre-Louis Bossart , Hans de Goede , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Cezary Rojewski , Liam Girdwood , Jie Yang , Jaroslav Kysela , Takashi Iwai Subject: Re: [PATCH v1 2/4] ASoC: Intel: bytcr_rt5640: Use temporary variable for struct device Message-ID: References: <20211006150442.16503-1-andriy.shevchenko@linux.intel.com> <20211006150442.16503-2-andriy.shevchenko@linux.intel.com> <4b81a10dca78e286a9f806464b97111b5a15a91e.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 06, 2021 at 04:48:57PM +0100, Mark Brown wrote: > On Wed, Oct 06, 2021 at 06:44:07PM +0300, Andy Shevchenko wrote: > > On Wed, Oct 06, 2021 at 08:21:01AM -0700, Joe Perches wrote: > > > > Some will complain about a lack of commit message. > > > Yeah, sorry for that, it wasn't deliberate. I forgot to run `git msg-filter` > > on these three patches to add it. > > > Mark, do you want me resend entire bunch(es) or just starting from these > > patches? Or...? > > If you're adding a commit message with automation it's probably not > adding any value. What do you mean? I add it exceptionally for the same (by nature) patches. What do you expect to be altered in these three, if the idea behind the change is very well the same? -- With Best Regards, Andy Shevchenko