From: Matthias Kaehlcke <mka@chromium.org>
To: Balakrishna Godavarthi <bgodavar@codeaurora.org>
Cc: marcel@holtmann.org, bjorn.andersson@linaro.org,
johan.hedberg@gmail.com, linux-kernel@vger.kernel.org,
linux-bluetooth@vger.kernel.org, hemantg@codeaurora.org,
linux-arm-msm@vger.kernel.org, rjliao@codeaurora.org,
pharish@codeaurora.org, abhishekpandit@chromium.org
Subject: Re: [PATCH v1 2/2] arm64: dts: qcom: sc7280: update bluetooth node in SC7280 IDP2 board
Date: Wed, 6 Oct 2021 10:39:34 -0700 [thread overview]
Message-ID: <YV3fVjd5ngQhuA4K@google.com> (raw)
In-Reply-To: <1633523403-32264-2-git-send-email-bgodavar@codeaurora.org>
On Wed, Oct 06, 2021 at 06:00:03PM +0530, Balakrishna Godavarthi wrote:
> Subject: arm64: dts: qcom: sc7280: update bluetooth node in SC7280 IDP2 board
Not super helpful, what does 'update' mean?
It might be easier to have a single patch for both IDP boards, since
the Bluetooth node is added in the common sc7280-idp.dtsi board,
rather than explaining what this patch does :)
> This patch updates bluetooth node in SC7280 IDP2 board.
>
> Signed-off-by: Balakrishna Godavarthi <bgodavar@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sc7280-idp2.dts | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp2.dts b/arch/arm64/boot/dts/qcom/sc7280-idp2.dts
> index 1fc2add..5c8d54b 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-idp2.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-idp2.dts
> @@ -15,9 +15,15 @@
>
> aliases {
> serial0 = &uart5;
> + bluetooth0 = &bluetooth;
> + hsuart0 = &uart7;
> };
Sort aliases alphabetically
>
> chosen {
> stdout-path = "serial0:115200n8";
> };
> };
> +
> +&bluetooth: wcn6750-bt {
&bluetooth {
> + vddio-supply = <&vreg_l18b_1p8>;
nit: if it's not really common across IDP boards or a default, you could
leave it unconfigured in sc7280-idp.dtsi, and set in both board files.
Just an idea, with only two boards it doesn't really matter too much.
next prev parent reply other threads:[~2021-10-06 17:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-06 12:30 [PATCH v1 1/2] arm64: dts: qcom: sc7280: Add bluetooth node on SC7280 IDP board Balakrishna Godavarthi
2021-10-06 12:30 ` [PATCH v1 2/2] arm64: dts: qcom: sc7280: update bluetooth node in SC7280 IDP2 board Balakrishna Godavarthi
2021-10-06 16:48 ` Dmitry Baryshkov
2021-10-12 10:02 ` bgodavar
2021-10-06 17:39 ` Matthias Kaehlcke [this message]
2021-10-12 10:01 ` bgodavar
2021-10-06 17:26 ` [PATCH v1 1/2] arm64: dts: qcom: sc7280: Add bluetooth node on SC7280 IDP board Matthias Kaehlcke
2021-10-12 9:55 ` bgodavar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV3fVjd5ngQhuA4K@google.com \
--to=mka@chromium.org \
--cc=abhishekpandit@chromium.org \
--cc=bgodavar@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=hemantg@codeaurora.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=pharish@codeaurora.org \
--cc=rjliao@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.