From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Pratyush Yadav <p.yadav@ti.com>
Cc: "Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Nikhil Devshatwar" <nikhil.nd@ti.com>,
"Tomi Valkeinen" <tomi.valkeinen@ideasonboard.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
"Benoit Parrot" <bparrot@ti.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v4 07/11] media: Re-structure TI platform drivers
Date: Thu, 7 Oct 2021 02:46:59 +0300 [thread overview]
Message-ID: <YV41c2ortuLLXky9@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20210915120240.21572-8-p.yadav@ti.com>
Hi Pratyush,
Thank you for the patch.
On Wed, Sep 15, 2021 at 05:32:36PM +0530, Pratyush Yadav wrote:
> The ti-vpe/ sub-directory does not only contain the VPE-specific things.
> It also contains the CAL driver, which is a completely different
> subsystem. This is also not a good place to add new drivers for other TI
> platforms since they will all get mixed up.
>
> Separate the VPE and CAL parts into different sub-directories and rename
> the ti-vpe/ sub-directory to ti/. This is now the place where new TI
> platform drivers can be added.
That looks much better :-)
> Signed-off-by: Pratyush Yadav <p.yadav@ti.com>
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Compile tested only. There should be no functional change.
>
> (no changes since v3)
>
> Changes in v3:
> - Add Tomi's R-by.
>
> Changes in v2:
> - New in v2.
>
> MAINTAINERS | 3 ++-
> drivers/media/platform/Makefile | 2 +-
> drivers/media/platform/ti/Makefile | 3 +++
> drivers/media/platform/ti/cal/Makefile | 3 +++
> drivers/media/platform/{ti-vpe => ti/cal}/cal-camerarx.c | 0
> drivers/media/platform/{ti-vpe => ti/cal}/cal-video.c | 0
> drivers/media/platform/{ti-vpe => ti/cal}/cal.c | 0
> drivers/media/platform/{ti-vpe => ti/cal}/cal.h | 0
> drivers/media/platform/{ti-vpe => ti/cal}/cal_regs.h | 0
> drivers/media/platform/{ti-vpe => ti/vpe}/Makefile | 4 ----
> drivers/media/platform/{ti-vpe => ti/vpe}/csc.c | 0
> drivers/media/platform/{ti-vpe => ti/vpe}/csc.h | 0
> drivers/media/platform/{ti-vpe => ti/vpe}/sc.c | 0
> drivers/media/platform/{ti-vpe => ti/vpe}/sc.h | 0
> drivers/media/platform/{ti-vpe => ti/vpe}/sc_coeff.h | 0
> drivers/media/platform/{ti-vpe => ti/vpe}/vpdma.c | 0
> drivers/media/platform/{ti-vpe => ti/vpe}/vpdma.h | 0
> drivers/media/platform/{ti-vpe => ti/vpe}/vpdma_priv.h | 0
> drivers/media/platform/{ti-vpe => ti/vpe}/vpe.c | 0
> drivers/media/platform/{ti-vpe => ti/vpe}/vpe_regs.h | 0
> 20 files changed, 9 insertions(+), 6 deletions(-)
> create mode 100644 drivers/media/platform/ti/Makefile
> create mode 100644 drivers/media/platform/ti/cal/Makefile
> rename drivers/media/platform/{ti-vpe => ti/cal}/cal-camerarx.c (100%)
> rename drivers/media/platform/{ti-vpe => ti/cal}/cal-video.c (100%)
> rename drivers/media/platform/{ti-vpe => ti/cal}/cal.c (100%)
> rename drivers/media/platform/{ti-vpe => ti/cal}/cal.h (100%)
> rename drivers/media/platform/{ti-vpe => ti/cal}/cal_regs.h (100%)
> rename drivers/media/platform/{ti-vpe => ti/vpe}/Makefile (78%)
> rename drivers/media/platform/{ti-vpe => ti/vpe}/csc.c (100%)
> rename drivers/media/platform/{ti-vpe => ti/vpe}/csc.h (100%)
> rename drivers/media/platform/{ti-vpe => ti/vpe}/sc.c (100%)
> rename drivers/media/platform/{ti-vpe => ti/vpe}/sc.h (100%)
> rename drivers/media/platform/{ti-vpe => ti/vpe}/sc_coeff.h (100%)
> rename drivers/media/platform/{ti-vpe => ti/vpe}/vpdma.c (100%)
> rename drivers/media/platform/{ti-vpe => ti/vpe}/vpdma.h (100%)
> rename drivers/media/platform/{ti-vpe => ti/vpe}/vpdma_priv.h (100%)
> rename drivers/media/platform/{ti-vpe => ti/vpe}/vpe.c (100%)
> rename drivers/media/platform/{ti-vpe => ti/vpe}/vpe_regs.h (100%)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index cad1289793db..62bc4a949ae1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18829,7 +18829,8 @@ W: http://linuxtv.org/
> Q: http://patchwork.linuxtv.org/project/linux-media/list/
> F: Documentation/devicetree/bindings/media/ti,cal.yaml
> F: Documentation/devicetree/bindings/media/ti,vpe.yaml
> -F: drivers/media/platform/ti-vpe/
> +F: drivers/media/platform/ti/cal/
> +F: drivers/media/platform/ti/vpe/
>
> TI WILINK WIRELESS DRIVERS
> L: linux-wireless@vger.kernel.org
> diff --git a/drivers/media/platform/Makefile b/drivers/media/platform/Makefile
> index 73ce083c2fc6..26d15b377a79 100644
> --- a/drivers/media/platform/Makefile
> +++ b/drivers/media/platform/Makefile
> @@ -15,7 +15,7 @@ obj-$(CONFIG_VIDEO_PXA27x) += pxa_camera.o
>
> obj-$(CONFIG_VIDEO_VIU) += fsl-viu.o
>
> -obj-y += ti-vpe/
> +obj-y += ti/
>
> obj-$(CONFIG_VIDEO_MX2_EMMAPRP) += mx2_emmaprp.o
> obj-$(CONFIG_VIDEO_CODA) += coda/
> diff --git a/drivers/media/platform/ti/Makefile b/drivers/media/platform/ti/Makefile
> new file mode 100644
> index 000000000000..bbc737ccbbea
> --- /dev/null
> +++ b/drivers/media/platform/ti/Makefile
> @@ -0,0 +1,3 @@
> +# SPDX-License-Identifier: GPL-2.0
> +obj-y += cal/
> +obj-y += vpe/
> diff --git a/drivers/media/platform/ti/cal/Makefile b/drivers/media/platform/ti/cal/Makefile
> new file mode 100644
> index 000000000000..45ac35585f0b
> --- /dev/null
> +++ b/drivers/media/platform/ti/cal/Makefile
> @@ -0,0 +1,3 @@
> +# SPDX-License-Identifier: GPL-2.0
> +obj-$(CONFIG_VIDEO_TI_CAL) += ti-cal.o
> +ti-cal-y := cal.o cal-camerarx.o cal-video.o
> diff --git a/drivers/media/platform/ti-vpe/cal-camerarx.c b/drivers/media/platform/ti/cal/cal-camerarx.c
> similarity index 100%
> rename from drivers/media/platform/ti-vpe/cal-camerarx.c
> rename to drivers/media/platform/ti/cal/cal-camerarx.c
> diff --git a/drivers/media/platform/ti-vpe/cal-video.c b/drivers/media/platform/ti/cal/cal-video.c
> similarity index 100%
> rename from drivers/media/platform/ti-vpe/cal-video.c
> rename to drivers/media/platform/ti/cal/cal-video.c
> diff --git a/drivers/media/platform/ti-vpe/cal.c b/drivers/media/platform/ti/cal/cal.c
> similarity index 100%
> rename from drivers/media/platform/ti-vpe/cal.c
> rename to drivers/media/platform/ti/cal/cal.c
> diff --git a/drivers/media/platform/ti-vpe/cal.h b/drivers/media/platform/ti/cal/cal.h
> similarity index 100%
> rename from drivers/media/platform/ti-vpe/cal.h
> rename to drivers/media/platform/ti/cal/cal.h
> diff --git a/drivers/media/platform/ti-vpe/cal_regs.h b/drivers/media/platform/ti/cal/cal_regs.h
> similarity index 100%
> rename from drivers/media/platform/ti-vpe/cal_regs.h
> rename to drivers/media/platform/ti/cal/cal_regs.h
> diff --git a/drivers/media/platform/ti-vpe/Makefile b/drivers/media/platform/ti/vpe/Makefile
> similarity index 78%
> rename from drivers/media/platform/ti-vpe/Makefile
> rename to drivers/media/platform/ti/vpe/Makefile
> index ad624056e039..3fadfe084f87 100644
> --- a/drivers/media/platform/ti-vpe/Makefile
> +++ b/drivers/media/platform/ti/vpe/Makefile
> @@ -10,7 +10,3 @@ ti-sc-y := sc.o
> ti-csc-y := csc.o
>
> ccflags-$(CONFIG_VIDEO_TI_VPE_DEBUG) += -DDEBUG
> -
> -obj-$(CONFIG_VIDEO_TI_CAL) += ti-cal.o
> -
> -ti-cal-y := cal.o cal-camerarx.o cal-video.o
> diff --git a/drivers/media/platform/ti-vpe/csc.c b/drivers/media/platform/ti/vpe/csc.c
> similarity index 100%
> rename from drivers/media/platform/ti-vpe/csc.c
> rename to drivers/media/platform/ti/vpe/csc.c
> diff --git a/drivers/media/platform/ti-vpe/csc.h b/drivers/media/platform/ti/vpe/csc.h
> similarity index 100%
> rename from drivers/media/platform/ti-vpe/csc.h
> rename to drivers/media/platform/ti/vpe/csc.h
> diff --git a/drivers/media/platform/ti-vpe/sc.c b/drivers/media/platform/ti/vpe/sc.c
> similarity index 100%
> rename from drivers/media/platform/ti-vpe/sc.c
> rename to drivers/media/platform/ti/vpe/sc.c
> diff --git a/drivers/media/platform/ti-vpe/sc.h b/drivers/media/platform/ti/vpe/sc.h
> similarity index 100%
> rename from drivers/media/platform/ti-vpe/sc.h
> rename to drivers/media/platform/ti/vpe/sc.h
> diff --git a/drivers/media/platform/ti-vpe/sc_coeff.h b/drivers/media/platform/ti/vpe/sc_coeff.h
> similarity index 100%
> rename from drivers/media/platform/ti-vpe/sc_coeff.h
> rename to drivers/media/platform/ti/vpe/sc_coeff.h
> diff --git a/drivers/media/platform/ti-vpe/vpdma.c b/drivers/media/platform/ti/vpe/vpdma.c
> similarity index 100%
> rename from drivers/media/platform/ti-vpe/vpdma.c
> rename to drivers/media/platform/ti/vpe/vpdma.c
> diff --git a/drivers/media/platform/ti-vpe/vpdma.h b/drivers/media/platform/ti/vpe/vpdma.h
> similarity index 100%
> rename from drivers/media/platform/ti-vpe/vpdma.h
> rename to drivers/media/platform/ti/vpe/vpdma.h
> diff --git a/drivers/media/platform/ti-vpe/vpdma_priv.h b/drivers/media/platform/ti/vpe/vpdma_priv.h
> similarity index 100%
> rename from drivers/media/platform/ti-vpe/vpdma_priv.h
> rename to drivers/media/platform/ti/vpe/vpdma_priv.h
> diff --git a/drivers/media/platform/ti-vpe/vpe.c b/drivers/media/platform/ti/vpe/vpe.c
> similarity index 100%
> rename from drivers/media/platform/ti-vpe/vpe.c
> rename to drivers/media/platform/ti/vpe/vpe.c
> diff --git a/drivers/media/platform/ti-vpe/vpe_regs.h b/drivers/media/platform/ti/vpe/vpe_regs.h
> similarity index 100%
> rename from drivers/media/platform/ti-vpe/vpe_regs.h
> rename to drivers/media/platform/ti/vpe/vpe_regs.h
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2021-10-06 23:47 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 12:02 [PATCH v4 00/11] CSI2RX support on J721E Pratyush Yadav
2021-09-15 12:02 ` [PATCH v4 01/11] media: cadence: csi2rx: Unregister v4l2 async notifier Pratyush Yadav
2021-10-06 23:31 ` Laurent Pinchart
2021-10-07 12:19 ` Pratyush Yadav
2021-09-15 12:02 ` [PATCH v4 02/11] media: cadence: csi2rx: Add external DPHY support Pratyush Yadav
2021-10-06 20:19 ` Sakari Ailus
2021-10-06 21:01 ` Pratyush Yadav
2021-10-06 23:40 ` Laurent Pinchart
2021-09-15 12:02 ` [PATCH v4 03/11] media: cadence: csi2rx: Soft reset the streams before starting capture Pratyush Yadav
2021-10-06 23:41 ` Laurent Pinchart
2021-09-15 12:02 ` [PATCH v4 04/11] media: cadence: csi2rx: Set the STOP bit when stopping a stream Pratyush Yadav
2021-10-06 23:42 ` Laurent Pinchart
2021-09-15 12:02 ` [PATCH v4 05/11] media: cadence: csi2rx: Fix stream data configuration Pratyush Yadav
2021-10-06 23:44 ` Laurent Pinchart
2021-09-15 12:02 ` [PATCH v4 06/11] media: cadence: csi2rx: Populate subdev devnode Pratyush Yadav
2021-10-06 23:45 ` Laurent Pinchart
2021-09-15 12:02 ` [PATCH v4 07/11] media: Re-structure TI platform drivers Pratyush Yadav
2021-10-06 23:46 ` Laurent Pinchart [this message]
2021-09-15 12:02 ` [PATCH v4 08/11] media: ti: Add CSI2RX support for J721E Pratyush Yadav
2021-10-06 20:28 ` Sakari Ailus
2021-10-06 21:01 ` Pratyush Yadav
2021-10-06 21:08 ` Sakari Ailus
2021-09-15 12:02 ` [PATCH v4 09/11] media: dt-bindings: Make sure items in data-lanes are unique Pratyush Yadav
2021-09-21 21:31 ` Rob Herring
2021-10-06 23:47 ` Laurent Pinchart
2021-09-15 12:02 ` [PATCH v4 10/11] media: dt-bindings: Add DT bindings for TI J721E CSI2RX driver Pratyush Yadav
2021-09-21 21:32 ` Rob Herring
2021-10-06 23:49 ` Laurent Pinchart
2021-09-15 12:02 ` [PATCH v4 11/11] media: dt-bindings: Convert Cadence CSI2RX binding to YAML Pratyush Yadav
2021-09-21 21:35 ` Rob Herring
2021-10-06 23:54 ` Laurent Pinchart
2021-10-07 12:16 ` Pratyush Yadav
2021-10-06 8:21 ` [PATCH v4 00/11] CSI2RX support on J721E Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV41c2ortuLLXky9@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=bparrot@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mripard@kernel.org \
--cc=nikhil.nd@ti.com \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=p.yadav@ti.com \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.