From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: Dave Airlie <airlied@gmail.com>, intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [RFC PATCH 0/8] drm/i915/display: refactor plane config + pin out
Date: Thu, 7 Oct 2021 14:09:15 +0300 [thread overview]
Message-ID: <YV7VWyYyeNF4ep0d@intel.com> (raw)
In-Reply-To: <87ee8xyumd.fsf@intel.com>
On Thu, Oct 07, 2021 at 01:52:42PM +0300, Jani Nikula wrote:
> On Thu, 07 Oct 2021, Dave Airlie <airlied@gmail.com> wrote:
> > This is another series in the refactor intel_display.c into more manageable
> > places.
> >
> > This moves the initial plane config and all the fb pin/unpin code out.
> >
> > It also refactors both a little to make the interfaces cleaner.
>
> I had a few nitpicks I commented on. Overall this looks good to me, but
> I'd like Ville's input on the code movement at the high level, are the
> split and files sane etc. I can do the detailed review after that.
Some of it feels a bit ad-hoc, but I don't really have a better
idea for splitting some of these right now. So might as well go
with this I guess. cscope will find the stuff for me in the end,
at least after I remember to have it reindex.
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2021-10-07 11:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-07 3:13 [Intel-gfx] [RFC PATCH 0/8] drm/i915/display: refactor plane config + pin out Dave Airlie
2021-10-07 3:13 ` [Intel-gfx] [PATCH 1/8] drm/i915/display: move plane prepare/cleanup to intel_atomic_plane.c Dave Airlie
2021-10-07 3:13 ` [Intel-gfx] [PATCH 2/8] drm/i915/display: move intel_plane_uses_fence to inline Dave Airlie
2021-10-07 8:58 ` Jani Nikula
2021-10-07 3:13 ` [Intel-gfx] [PATCH 3/8] drm/i915/display: refactor out initial plane config for crtcs Dave Airlie
2021-10-07 3:13 ` [Intel-gfx] [PATCH 4/8] drm/i915/display: refactor initial plane config to a separate file Dave Airlie
2021-10-07 10:48 ` Jani Nikula
2021-10-07 3:13 ` [Intel-gfx] [PATCH 5/8] drm/i915/display: move pin/unpin fb/plane code to a new file Dave Airlie
2021-10-07 3:13 ` [Intel-gfx] [PATCH 6/8] drm/i915/display: refactor fbdev pin/unpin out into functions Dave Airlie
2021-10-07 3:13 ` [Intel-gfx] [PATCH 7/8] drm/i915/display: move fbdev pin code into fb_pin Dave Airlie
2021-10-07 3:13 ` [Intel-gfx] [PATCH 8/8] drm/i915/display: drop unused parameter to dpt pin Dave Airlie
2021-10-07 3:36 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: refactor plane config + pin out Patchwork
2021-10-07 3:37 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2021-10-07 4:09 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-10-07 5:29 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-10-07 10:52 ` [Intel-gfx] [RFC PATCH 0/8] " Jani Nikula
2021-10-07 11:09 ` Ville Syrjälä [this message]
2021-10-12 4:18 ` Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YV7VWyYyeNF4ep0d@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=airlied@gmail.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.