From: Andrew Lunn <andrew@lunn.ch>
To: Christian Lamparter <chunkeey@gmail.com>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next v1] net: ethernet: emac: utilize of_net's of_get_mac_address()
Date: Sun, 26 Sep 2021 16:35:09 +0200 [thread overview]
Message-ID: <YVCFHT7F2e6OOThM@lunn.ch> (raw)
In-Reply-To: <20210926095648.244445-1-chunkeey@gmail.com>
> + err = of_get_mac_address(np, dev->ndev->dev_addr);
> + if (err) {
> + if (err != -EPROBE_DEFER)
> + dev_err(&dev->ofdev->dev, "Can't get valid [local-]mac-address from OF !\n");
> + return err;
I think there is a helper which does the if (err != -EPRODE_DEFER)
then print, but i cannot remember its name. Probably the script kids
will come along and convert it for you.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2021-09-26 14:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-26 9:56 [PATCH net-next v1] net: ethernet: emac: utilize of_net's of_get_mac_address() Christian Lamparter
2021-09-26 14:35 ` Andrew Lunn [this message]
2021-09-27 12:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YVCFHT7F2e6OOThM@lunn.ch \
--to=andrew@lunn.ch \
--cc=chunkeey@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.