All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
	gregkh@linuxfoundation.org, shubhrajyoti.datta@gmail.com,
	git@xilinx.com
Subject: Re: [PATCH v3 1/2] dt-binding: usb: xilinx: Add clocking node
Date: Mon, 27 Sep 2021 14:00:46 -0500	[thread overview]
Message-ID: <YVIU3gnpGe8JVdz/@robh.at.kernel.org> (raw)
In-Reply-To: <625a34188da7fcc4132b8717afd3d69e6bdc3316.1632307026.git.shubhrajyoti.datta@xilinx.com>

On Wed, Sep 22, 2021 at 04:41:25PM +0530, Shubhrajyoti Datta wrote:
> Add a clocking node for xilinx udc.
> 
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> ---
>  Documentation/devicetree/bindings/usb/xlnx,usb2.yaml | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/xlnx,usb2.yaml b/Documentation/devicetree/bindings/usb/xlnx,usb2.yaml
> index b8acc415eaf1..39213806ac79 100644
> --- a/Documentation/devicetree/bindings/usb/xlnx,usb2.yaml
> +++ b/Documentation/devicetree/bindings/usb/xlnx,usb2.yaml
> @@ -24,6 +24,14 @@ properties:
>        If present, hardware has dma capability.
>      type: boolean
>  
> +  clocks:
> +    minItems: 1
> +
> +  clock-name:

I think you meant 'clock-names'.

> +    const: "s_axi_aclk"

Don't need quotes.

> +    description: |
> +      Input clock name.

That's every 'clock-names'. You can drop description.

> +
>  required:
>    - compatible
>    - reg
> -- 
> 2.25.1
> 
> 

  reply	other threads:[~2021-09-27 19:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22 11:11 [PATCH v3 0/2] usb: gadget: Add clock support Shubhrajyoti Datta
2021-09-22 11:11 ` [PATCH v3 1/2] dt-binding: usb: xilinx: Add clocking node Shubhrajyoti Datta
2021-09-27 19:00   ` Rob Herring [this message]
2021-09-22 11:11 ` [PATCH v3 2/2] usb: gadget: udc-xilinx: Add clock support Shubhrajyoti Datta
2021-09-22 11:54   ` Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YVIU3gnpGe8JVdz/@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=git@xilinx.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=shubhrajyoti.datta@gmail.com \
    --cc=shubhrajyoti.datta@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.