From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED7CEC433EF for ; Mon, 27 Sep 2021 20:42:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B39ED60EFD for ; Mon, 27 Sep 2021 20:42:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B39ED60EFD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DY724QyQrouot2MW6Ttf62fBeplnWy1HPrcMajb43J0=; b=pOXCxCg9UD9QSk WuMHcdViioQS9zpOnsFSrPmL/Ko+JyBwnOgVJIOu3qlZHCuiuxgPOg3JCWy5v3futqk7OJyEy1C+9 qLWUfVdPSMN2n7pZnegxpns5Smc5+mRy3dNDAnzO4/pwUDd9CLsFqBSX165OMYl2E5bHyWmJOsfB3 npT+Jh4TVKJfgQEzYmqT6MD5+hld4s+m+ydeHyThPqGJP2H/OdXljVBiXE9HS8wJbvWNf46XU1D2H g8yM0uU13I5iHYfPZjQSKigcqfhPuQTWNQTJz3nLuZiuwQeXhHlVwVHarPLkmwfxiHsKY1MpsaDXF glRE4tQNX3CNqOjUCgrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUxRg-004DLW-MF; Mon, 27 Sep 2021 20:41:52 +0000 Received: from mail-ot1-x336.google.com ([2607:f8b0:4864:20::336]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUxRc-004DJe-Sp for ath10k@lists.infradead.org; Mon, 27 Sep 2021 20:41:50 +0000 Received: by mail-ot1-x336.google.com with SMTP id h9-20020a9d2f09000000b005453f95356cso26073680otb.11 for ; Mon, 27 Sep 2021 13:41:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pUZgLCnNelRAaV+g7H8XGqFTT9YZLErJSXLJYla4RJo=; b=dCoaJUF0HSoSC1tmNX6q8Fh6kJv7c6jk49XmhH2vq1ANKmz6EeVyVtD2Pcxxxh8aXz /W0bzAWmoH3iHlFtKt4RHhcy9v4nMv6BEyBk34D8UUa8oCh+yyJJBwKYrK5zxFL+VJ5W mmk25gMJbff0s4JgjQlL73M1frtzFLhhSSeKsoMfON0N7To1FwqmZevw+vpH964FuN5+ VDs07R1JX2daPpe7GTVjL3t8b85VIkNR+VDjVjC7aEfatwsh4ieB21gaSPHVc9FrfLe4 JK9GpMcv5K/VRzrKmX8WZg1LZAmnWcollVG6hxmBajWBFIxazJts7JTsm6AsqVhgOO/o pUCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pUZgLCnNelRAaV+g7H8XGqFTT9YZLErJSXLJYla4RJo=; b=hxZikxjumleXipHHUpIIPLt1uyOXk3Dj242cAxeonXubzZFVn0HS4+xjDc+LYxFnMH tO86eDbfa9nZOfBbyGXzfvCoblwUWe/XOa0lDFT4ymBrbMNMLObmFtuhivdq5ejIJyS4 Ny4kDQxtg/6+2C8of/Ssjc/OF2lFexYOe+z7x1e3Ox4jC/r3UWRXn5+6gb0NhPz8K7uC dG7wiDCYQR/ej65KrHM38pgGr9/HkP+hmU9Ih/2NXe00cBVMPY7r6396sWgNfQeZGb81 aa/dLnslLqikGHGZhR2HiVb4IqfJ/TSJZymFapKRieduIK+yrw8IkxnZc9FApl5n9tsu M9aA== X-Gm-Message-State: AOAM532yPxPJRcwtckyQ4yses5uMQZQlwouJzyttfHM56sqIfI8tAR5I Cg6dokl1Vhkxgf5CiIsP1uI9Wg== X-Google-Smtp-Source: ABdhPJydeIzDJHtHzGeBz5+87mWnwkDNbaEe+ql2n9gGjNC+NklvZH2OYxM0vWlXO7E/L2MFCogIbA== X-Received: by 2002:a9d:6a0f:: with SMTP id g15mr1832465otn.126.1632775307597; Mon, 27 Sep 2021 13:41:47 -0700 (PDT) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id a8sm4414108oos.46.2021.09.27.13.41.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 13:41:47 -0700 (PDT) Date: Mon, 27 Sep 2021 13:42:22 -0700 From: Bjorn Andersson To: Arnd Bergmann Cc: John Stultz , Arnd Bergmann , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Joerg Roedel , Will Deacon , Mauro Carvalho Chehab , Ulf Hansson , Alex Elder , "David S. Miller" , Jakub Kicinski , Kalle Valo , Andy Gross , Linus Walleij , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Linux Kernel Mailing List , linux-arm-msm , dri-devel , freedreno , "open list:IOMMU DRIVERS" , Linux Media Mailing List , linux-mmc , Networking , ath10k@lists.infradead.org, linux-wireless , "open list:GPIO SUBSYSTEM" , Linux ARM , linux-sunxi@lists.linux.dev Subject: Re: [PATCH] [RFC] qcom_scm: hide Kconfig symbol Message-ID: References: <20210927152412.2900928-1-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210927_134149_006391_D8C72721 X-CRM114-Status: GOOD ( 27.80 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+ath10k=archiver.kernel.org@lists.infradead.org On Mon 27 Sep 13:15 PDT 2021, Arnd Bergmann wrote: > On Mon, Sep 27, 2021 at 9:52 PM Bjorn Andersson > wrote: > > On Mon 27 Sep 08:22 PDT 2021, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > - To avoid a circular dependency chain involving RESET_CONTROLLER > > > and PINCTRL_SUNXI, change the 'depends on RESET_CONTROLLER' in > > > the latter one to 'select'. > > > > Can you please help me understand why this is part of the same patch? > > This can be done as a preparatory patch if we decide to do it this way, > for the review it seemed better to spell out that this is required. > > I still hope that we can avoid adding another 'select RESET_CONTROLLER' > if someone can figure out what to do instead. > Okay, thanks. > The problem here is that QCOM_SCM selects RESET_CONTROLLER, > and turning that into 'depends on' would in turn mean that any driver that > wants to select QCOM_SCM would have to have the same RESET_CONTROLLER > dependency. > Right, and that will just be another thing we'll get wrong across the tree. > An easier option might be to find a way to build QCOM_SCM without > RESET_CONTROLLER for compile testing purposes. I don't know > what would break from that. > Afaict the reset API is properly stubbed and RESET_CONTROLLER is a bool, so I think we can simply drop the "select" and the kernel will still compile fine in all combinations. When it comes to runtime, we currently select RESET_CONTROLLER from the Qualcomm common clocks. If that is dropped (why would it...) it seems possible to build a custom kernel for msm8916 that we can boot and miss the stubbed out "mss restart" reset line from the SCM. So, let's just drop the select RESET_CONTROLLER from SCM for now. Regards, Bjorn _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B77EEC433FE for ; Mon, 27 Sep 2021 20:41:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A0C4361074 for ; Mon, 27 Sep 2021 20:41:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236589AbhI0Un1 (ORCPT ); Mon, 27 Sep 2021 16:43:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60614 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236477AbhI0Un0 (ORCPT ); Mon, 27 Sep 2021 16:43:26 -0400 Received: from mail-ot1-x330.google.com (mail-ot1-x330.google.com [IPv6:2607:f8b0:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E662C061769 for ; Mon, 27 Sep 2021 13:41:48 -0700 (PDT) Received: by mail-ot1-x330.google.com with SMTP id l16-20020a9d6a90000000b0053b71f7dc83so26135368otq.7 for ; Mon, 27 Sep 2021 13:41:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pUZgLCnNelRAaV+g7H8XGqFTT9YZLErJSXLJYla4RJo=; b=dCoaJUF0HSoSC1tmNX6q8Fh6kJv7c6jk49XmhH2vq1ANKmz6EeVyVtD2Pcxxxh8aXz /W0bzAWmoH3iHlFtKt4RHhcy9v4nMv6BEyBk34D8UUa8oCh+yyJJBwKYrK5zxFL+VJ5W mmk25gMJbff0s4JgjQlL73M1frtzFLhhSSeKsoMfON0N7To1FwqmZevw+vpH964FuN5+ VDs07R1JX2daPpe7GTVjL3t8b85VIkNR+VDjVjC7aEfatwsh4ieB21gaSPHVc9FrfLe4 JK9GpMcv5K/VRzrKmX8WZg1LZAmnWcollVG6hxmBajWBFIxazJts7JTsm6AsqVhgOO/o pUCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pUZgLCnNelRAaV+g7H8XGqFTT9YZLErJSXLJYla4RJo=; b=sUbfYx1GvsuloM2/lXEVC2J1ijQtDOEtNNsWPB97afyjKperWNPbZOM8VZJdR9I1oR PnE05pr4d2APJgf7jzhTOHP8Oq4X+Oxy2uN3D1Nswg370TaSZUswk6FN7L1EYFs79YDd S/yuwagKJs816842cFyA8WH1FG9pox/xDmuqL9eMoHc2btB9B6HoDpE+UK5gHS1K/vdp 8jAMJrQ68kVWvE5f3jxSAr/6I7ft81Y0aKTiaOPnWaY1widw062Lffytqb5x8T01kUv+ IBM5tfJOuJpS6DjVx6wmLQhrz63aUsrtKyiwRRECXBjdf9gyQdliJJlkT9eAjh+p1WHa nJtw== X-Gm-Message-State: AOAM530jlBg5BNafYC/k8paLCdmTTmRuQJuknPOvYVLpbDExWkvHawVU wURs58iTvTp7YA3z+LJCXbS+Gw== X-Google-Smtp-Source: ABdhPJydeIzDJHtHzGeBz5+87mWnwkDNbaEe+ql2n9gGjNC+NklvZH2OYxM0vWlXO7E/L2MFCogIbA== X-Received: by 2002:a9d:6a0f:: with SMTP id g15mr1832465otn.126.1632775307597; Mon, 27 Sep 2021 13:41:47 -0700 (PDT) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id a8sm4414108oos.46.2021.09.27.13.41.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 13:41:47 -0700 (PDT) Date: Mon, 27 Sep 2021 13:42:22 -0700 From: Bjorn Andersson To: Arnd Bergmann Cc: John Stultz , Arnd Bergmann , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Joerg Roedel , Will Deacon , Mauro Carvalho Chehab , Ulf Hansson , Alex Elder , "David S. Miller" , Jakub Kicinski , Kalle Valo , Andy Gross , Linus Walleij , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Linux Kernel Mailing List , linux-arm-msm , dri-devel , freedreno , "open list:IOMMU DRIVERS" , Linux Media Mailing List , linux-mmc , Networking , ath10k@lists.infradead.org, linux-wireless , "open list:GPIO SUBSYSTEM" , Linux ARM , linux-sunxi@lists.linux.dev Subject: Re: [PATCH] [RFC] qcom_scm: hide Kconfig symbol Message-ID: References: <20210927152412.2900928-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon 27 Sep 13:15 PDT 2021, Arnd Bergmann wrote: > On Mon, Sep 27, 2021 at 9:52 PM Bjorn Andersson > wrote: > > On Mon 27 Sep 08:22 PDT 2021, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > - To avoid a circular dependency chain involving RESET_CONTROLLER > > > and PINCTRL_SUNXI, change the 'depends on RESET_CONTROLLER' in > > > the latter one to 'select'. > > > > Can you please help me understand why this is part of the same patch? > > This can be done as a preparatory patch if we decide to do it this way, > for the review it seemed better to spell out that this is required. > > I still hope that we can avoid adding another 'select RESET_CONTROLLER' > if someone can figure out what to do instead. > Okay, thanks. > The problem here is that QCOM_SCM selects RESET_CONTROLLER, > and turning that into 'depends on' would in turn mean that any driver that > wants to select QCOM_SCM would have to have the same RESET_CONTROLLER > dependency. > Right, and that will just be another thing we'll get wrong across the tree. > An easier option might be to find a way to build QCOM_SCM without > RESET_CONTROLLER for compile testing purposes. I don't know > what would break from that. > Afaict the reset API is properly stubbed and RESET_CONTROLLER is a bool, so I think we can simply drop the "select" and the kernel will still compile fine in all combinations. When it comes to runtime, we currently select RESET_CONTROLLER from the Qualcomm common clocks. If that is dropped (why would it...) it seems possible to build a custom kernel for msm8916 that we can boot and miss the stubbed out "mss restart" reset line from the SCM. So, let's just drop the select RESET_CONTROLLER from SCM for now. Regards, Bjorn From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5037CC43217 for ; Mon, 27 Sep 2021 20:41:52 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 094BD60EFD for ; Mon, 27 Sep 2021 20:41:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 094BD60EFD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C491381000; Mon, 27 Sep 2021 20:41:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mIkM-bGd__A0; Mon, 27 Sep 2021 20:41:51 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id B9ACD80FF2; Mon, 27 Sep 2021 20:41:50 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 90D83C001C; Mon, 27 Sep 2021 20:41:50 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id D90B3C000F for ; Mon, 27 Sep 2021 20:41:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id BAE24404B6 for ; Mon, 27 Sep 2021 20:41:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=linaro.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id MNNLvbAtxi4m for ; Mon, 27 Sep 2021 20:41:48 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-ot1-x331.google.com (mail-ot1-x331.google.com [IPv6:2607:f8b0:4864:20::331]) by smtp4.osuosl.org (Postfix) with ESMTPS id 9D2D8404B4 for ; Mon, 27 Sep 2021 20:41:48 +0000 (UTC) Received: by mail-ot1-x331.google.com with SMTP id l7-20020a0568302b0700b0051c0181deebso26073768otv.12 for ; Mon, 27 Sep 2021 13:41:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pUZgLCnNelRAaV+g7H8XGqFTT9YZLErJSXLJYla4RJo=; b=dCoaJUF0HSoSC1tmNX6q8Fh6kJv7c6jk49XmhH2vq1ANKmz6EeVyVtD2Pcxxxh8aXz /W0bzAWmoH3iHlFtKt4RHhcy9v4nMv6BEyBk34D8UUa8oCh+yyJJBwKYrK5zxFL+VJ5W mmk25gMJbff0s4JgjQlL73M1frtzFLhhSSeKsoMfON0N7To1FwqmZevw+vpH964FuN5+ VDs07R1JX2daPpe7GTVjL3t8b85VIkNR+VDjVjC7aEfatwsh4ieB21gaSPHVc9FrfLe4 JK9GpMcv5K/VRzrKmX8WZg1LZAmnWcollVG6hxmBajWBFIxazJts7JTsm6AsqVhgOO/o pUCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pUZgLCnNelRAaV+g7H8XGqFTT9YZLErJSXLJYla4RJo=; b=bNkfIe3LHEJWXZaSSGkm9f+M4hyzIr5S11g5NJm5HHTxkEjgoGnZSwn4W6xoewSmC5 EJ/kGdUBcDSKxUHP+LZ1vRdqVHu1lOZbHjpAbCsiF53Z0JFDQpSqcp62o7haf9cOzKy3 G3B1AGeKtOzct8ZRwA8YnQ7LDmZT2+8ysysSIn5H6OMekMdDGk9KSIeoZKaHZwvKk7hP YdrYsT9etjhy/sZh6yqtps3H5jT6vandROdmDHuIGVlHJRjPmIU8bBvJ1GR+GWa+lcSQ pn/XVZJricR+zrZIKxqfjD0iPMphbmpUzZHOo/B0SwLjxP2HDPDZ6I/+3/99aJLl8zoH k8ew== X-Gm-Message-State: AOAM533CJCtkxgr94lZkCt93HcYPYK6itKdm2hjz+Foku9bSvmyUTxUE e67F8J+imUlhQKESUHY1q9A6EQ== X-Google-Smtp-Source: ABdhPJydeIzDJHtHzGeBz5+87mWnwkDNbaEe+ql2n9gGjNC+NklvZH2OYxM0vWlXO7E/L2MFCogIbA== X-Received: by 2002:a9d:6a0f:: with SMTP id g15mr1832465otn.126.1632775307597; Mon, 27 Sep 2021 13:41:47 -0700 (PDT) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id a8sm4414108oos.46.2021.09.27.13.41.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 13:41:47 -0700 (PDT) Date: Mon, 27 Sep 2021 13:42:22 -0700 From: Bjorn Andersson To: Arnd Bergmann Subject: Re: [PATCH] [RFC] qcom_scm: hide Kconfig symbol Message-ID: References: <20210927152412.2900928-1-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Cc: Mark Rutland , Ulf Hansson , David Airlie , linux-wireless , Linus Walleij , dri-devel , ath10k@lists.infradead.org, Will Deacon , "open list:IOMMU DRIVERS" , Jernej Skrabec , Chen-Yu Tsai , Andy Gross , Linux ARM , Jakub Kicinski , linux-sunxi@lists.linux.dev, Linux Media Mailing List , Arnd Bergmann , linux-arm-msm , Maxime Ripard , "open list:GPIO SUBSYSTEM" , John Stultz , Mauro Carvalho Chehab , Sean Paul , Kalle Valo , Alex Elder , Networking , linux-mmc , Linux Kernel Mailing List , Daniel Vetter , Sudeep Holla , freedreno , "David S. Miller" X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" On Mon 27 Sep 13:15 PDT 2021, Arnd Bergmann wrote: > On Mon, Sep 27, 2021 at 9:52 PM Bjorn Andersson > wrote: > > On Mon 27 Sep 08:22 PDT 2021, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > - To avoid a circular dependency chain involving RESET_CONTROLLER > > > and PINCTRL_SUNXI, change the 'depends on RESET_CONTROLLER' in > > > the latter one to 'select'. > > > > Can you please help me understand why this is part of the same patch? > > This can be done as a preparatory patch if we decide to do it this way, > for the review it seemed better to spell out that this is required. > > I still hope that we can avoid adding another 'select RESET_CONTROLLER' > if someone can figure out what to do instead. > Okay, thanks. > The problem here is that QCOM_SCM selects RESET_CONTROLLER, > and turning that into 'depends on' would in turn mean that any driver that > wants to select QCOM_SCM would have to have the same RESET_CONTROLLER > dependency. > Right, and that will just be another thing we'll get wrong across the tree. > An easier option might be to find a way to build QCOM_SCM without > RESET_CONTROLLER for compile testing purposes. I don't know > what would break from that. > Afaict the reset API is properly stubbed and RESET_CONTROLLER is a bool, so I think we can simply drop the "select" and the kernel will still compile fine in all combinations. When it comes to runtime, we currently select RESET_CONTROLLER from the Qualcomm common clocks. If that is dropped (why would it...) it seems possible to build a custom kernel for msm8916 that we can boot and miss the stubbed out "mss restart" reset line from the SCM. So, let's just drop the select RESET_CONTROLLER from SCM for now. Regards, Bjorn _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB7FCC433F5 for ; Mon, 27 Sep 2021 20:43:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95B4A610FC for ; Mon, 27 Sep 2021 20:43:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 95B4A610FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5x1cISau4EQkbgHv/5CbKwPjOX8W5OjD52jCn6fCHKg=; b=pbLiZUkZDZ6s+L 80VGEP0I9Rpy2BBHU+3hX41EXRi5hTK5zYfUi6TGMGkwNCCEGt34irZTLRTLg0K6eLJmFa3e6gZvR 9VqNKNglyYZoO7llRtpTR6A8TrUGJ/+3CNwLetEy5BKfkLoVpYYud7bHiy5A0BDY3V0e63DpwpRRo 9F132nUu9atvYznYt15yLrf9gxlkueGMuZFDre+0xD7DPCHtKvHv0f0wbF59EByv9zVNZQKLDsFrE NVTBh+ZOmT5ey+t6FgOYI6hWRBZCfCksayRqMxElynilTuFnFCaF/1GHtaPM0qJSIOOUZcIllJ34/ wYlmQ1Arfc4L6ZeDT4nA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUxRl-004DMt-2O; Mon, 27 Sep 2021 20:41:57 +0000 Received: from mail-ot1-x329.google.com ([2607:f8b0:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mUxRc-004DJf-Tj for linux-arm-kernel@lists.infradead.org; Mon, 27 Sep 2021 20:41:50 +0000 Received: by mail-ot1-x329.google.com with SMTP id r43-20020a05683044ab00b0054716b40005so19246085otv.4 for ; Mon, 27 Sep 2021 13:41:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pUZgLCnNelRAaV+g7H8XGqFTT9YZLErJSXLJYla4RJo=; b=dCoaJUF0HSoSC1tmNX6q8Fh6kJv7c6jk49XmhH2vq1ANKmz6EeVyVtD2Pcxxxh8aXz /W0bzAWmoH3iHlFtKt4RHhcy9v4nMv6BEyBk34D8UUa8oCh+yyJJBwKYrK5zxFL+VJ5W mmk25gMJbff0s4JgjQlL73M1frtzFLhhSSeKsoMfON0N7To1FwqmZevw+vpH964FuN5+ VDs07R1JX2daPpe7GTVjL3t8b85VIkNR+VDjVjC7aEfatwsh4ieB21gaSPHVc9FrfLe4 JK9GpMcv5K/VRzrKmX8WZg1LZAmnWcollVG6hxmBajWBFIxazJts7JTsm6AsqVhgOO/o pUCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pUZgLCnNelRAaV+g7H8XGqFTT9YZLErJSXLJYla4RJo=; b=wmn5gc0TJ/jiEBFCJQQmiFMZIFWn49wwYMtPDj0FLLZgpb+/53t1M32Cx/iecpun/q eDNwy68RrAAVCUxSn7jCB1r64EzWtgmfb946oYR7hvZC+NXJRWj1oNTv0HBQdPY9AP2W TXGlPJlrNCu28/++T1aHvQKAyYO64PBfXev95ae6xV1HUweBYqEFPq27IU2Y8bARf0Wk maejjHxpHGnrIP0IuCx4bObAlgLfvY1UD1yWXavx1m7arIZTsGVtyJMzcJNYJnkMqA2V VpinqCNwBS9pwAAQCKqUP8yiRxxZEV9LeV+7zbWnHAuuP1H+2VyaROKffT1Kgu1GMwWV t5xg== X-Gm-Message-State: AOAM532qXjQi7b3lwTTjE/24G6o/OEFaQxVNC+mCZrCcA//uyOq0bmvc SFaEfktEFjf0LwM+yg2yARMk3A== X-Google-Smtp-Source: ABdhPJydeIzDJHtHzGeBz5+87mWnwkDNbaEe+ql2n9gGjNC+NklvZH2OYxM0vWlXO7E/L2MFCogIbA== X-Received: by 2002:a9d:6a0f:: with SMTP id g15mr1832465otn.126.1632775307597; Mon, 27 Sep 2021 13:41:47 -0700 (PDT) Received: from ripper (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id a8sm4414108oos.46.2021.09.27.13.41.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Sep 2021 13:41:47 -0700 (PDT) Date: Mon, 27 Sep 2021 13:42:22 -0700 From: Bjorn Andersson To: Arnd Bergmann Cc: John Stultz , Arnd Bergmann , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Joerg Roedel , Will Deacon , Mauro Carvalho Chehab , Ulf Hansson , Alex Elder , "David S. Miller" , Jakub Kicinski , Kalle Valo , Andy Gross , Linus Walleij , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Linux Kernel Mailing List , linux-arm-msm , dri-devel , freedreno , "open list:IOMMU DRIVERS" , Linux Media Mailing List , linux-mmc , Networking , ath10k@lists.infradead.org, linux-wireless , "open list:GPIO SUBSYSTEM" , Linux ARM , linux-sunxi@lists.linux.dev Subject: Re: [PATCH] [RFC] qcom_scm: hide Kconfig symbol Message-ID: References: <20210927152412.2900928-1-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210927_134149_007882_173E5B6F X-CRM114-Status: GOOD ( 29.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon 27 Sep 13:15 PDT 2021, Arnd Bergmann wrote: > On Mon, Sep 27, 2021 at 9:52 PM Bjorn Andersson > wrote: > > On Mon 27 Sep 08:22 PDT 2021, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > - To avoid a circular dependency chain involving RESET_CONTROLLER > > > and PINCTRL_SUNXI, change the 'depends on RESET_CONTROLLER' in > > > the latter one to 'select'. > > > > Can you please help me understand why this is part of the same patch? > > This can be done as a preparatory patch if we decide to do it this way, > for the review it seemed better to spell out that this is required. > > I still hope that we can avoid adding another 'select RESET_CONTROLLER' > if someone can figure out what to do instead. > Okay, thanks. > The problem here is that QCOM_SCM selects RESET_CONTROLLER, > and turning that into 'depends on' would in turn mean that any driver that > wants to select QCOM_SCM would have to have the same RESET_CONTROLLER > dependency. > Right, and that will just be another thing we'll get wrong across the tree. > An easier option might be to find a way to build QCOM_SCM without > RESET_CONTROLLER for compile testing purposes. I don't know > what would break from that. > Afaict the reset API is properly stubbed and RESET_CONTROLLER is a bool, so I think we can simply drop the "select" and the kernel will still compile fine in all combinations. When it comes to runtime, we currently select RESET_CONTROLLER from the Qualcomm common clocks. If that is dropped (why would it...) it seems possible to build a custom kernel for msm8916 that we can boot and miss the stubbed out "mss restart" reset line from the SCM. So, let's just drop the select RESET_CONTROLLER from SCM for now. Regards, Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel